From nobody Wed Nov 19 08:46:10 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1615308502; cv=none; d=zohomail.com; s=zohoarc; b=bqZEf5e/+ZPISaW1e7YYZKdCgI4qEi7TiqNVg/N6P3lIFHuo5gESLnIsJzOXfD/JFZw7dLyaH+YN2D0kJWbKMUs/pPFrhfdVxu2GIriH0/R/b47I5UOxuw78Fuo3aIFvXU39VuQTxHndx9rzqxqFZ/KTPqvoxkLp5/u9nTawdTw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1615308502; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=uJkC/FaooZirGuu0VHFDubkoDlztZCrLbkateUX9i2Q=; b=jkp451Exk3aGCtB18GmCtb8HgQlEuyuJlPbuX5pPvDohij8EJpX4iUKKlAg+yzNrXj4KIXWtcbKNyh+57pys0khIXqX3V/ShxPdU/sGghXRdiuyWMA4W/lUhIe2qRp+9BkEc4GLnGQzIViXIvoKa37uSsnF5lTdzolSbyA508w4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1615308502925462.2756167175628; Tue, 9 Mar 2021 08:48:22 -0800 (PST) Received: from localhost ([::1]:52832 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lJfWv-0005U8-RA for importer@patchew.org; Tue, 09 Mar 2021 11:48:21 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:37120) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lJefk-0004z9-Qz for qemu-devel@nongnu.org; Tue, 09 Mar 2021 10:53:24 -0500 Received: from mail-oi1-x22c.google.com ([2607:f8b0:4864:20::22c]:36609) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lJefd-0001Ge-Bj for qemu-devel@nongnu.org; Tue, 09 Mar 2021 10:53:24 -0500 Received: by mail-oi1-x22c.google.com with SMTP id o22so5674990oic.3 for ; Tue, 09 Mar 2021 07:53:16 -0800 (PST) Received: from localhost.localdomain (fixed-187-189-51-144.totalplay.net. [187.189.51.144]) by smtp.gmail.com with ESMTPSA id b14sm2952539ooj.26.2021.03.09.07.53.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Mar 2021 07:53:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=uJkC/FaooZirGuu0VHFDubkoDlztZCrLbkateUX9i2Q=; b=QoHwiL9y4fzf+dOnsRyy5W6s+l4wLngmQ+/gNxTJhChHcL3uz9vhjUZmanKsPU9DYs C0KGGUwt1vM9YSObJbOgRtrvQFg4yOVMuypeazoXsk9f8chybDaBltywLFfwigGex/Yr /UsjzLRQZFZrDg9MPvgiWyl5S/UbCe5Jrx/dEkDikxZPrsJ24stN7f+/CQnPuANJj78C YOXp6pEM6o34Sxj75oOpb5YUimMvNC1YZmb2JFvymZ6XIoJDh7kJyVI+unFEdFUZWNIW hAHB3CbVcJ+EaUG+kf3n5ivgPCi9vwJm142lFohBTMhrqs5efPGRq93bm1hI56fWA53R dEMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=uJkC/FaooZirGuu0VHFDubkoDlztZCrLbkateUX9i2Q=; b=BffgTK7WtnCxbcYUGlD/zuc7o2z4iXQPxYj/VRWUskgzvDAoe4I9yowXMB9IRmTPXA 18bSxF2OIHOaQ0og/zaNpcc1t9meNWymwjKiPzg9oNM817I38Z6mzxpqVLuiy2Hd2Ktu NAvafGdpIW1YPyTtv5N22zkO4a1dC27cJbeif6NeW8Y0s1OuOZuNQOhm4oOJWkn4WiEr F15aedWYIxWpa9dAlVEJNkzgRGFQ6cDccUkFZWCos6VGYOyciOeN4iYTyyuUSk7IM1/J hm/VO/BRgjK25XsieD2pQDbagWKtBrjZGEsSNnFUEqB+QyJG0NbZPn/OYzwYSzQP4EIq YKxQ== X-Gm-Message-State: AOAM531/KZM0fA/tycJfmuWgDXv1qQ9sYEVlMoMEzpA73NGxURxlV7nU SpXKBORTGipxpPEdM+jRdsiJ/f/3RHKWxnGy X-Google-Smtp-Source: ABdhPJxdN7kGSh3ihQoOYEwEX+tgxqXj9jj9ZX8SLTEZr+1hcQ6nXeUpGr1LaV/a5MwWSfNZIHe4Pg== X-Received: by 2002:aca:dad4:: with SMTP id r203mr3330198oig.14.1615305196310; Tue, 09 Mar 2021 07:53:16 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PATCH v4 7/8] target/arm: Update WHILE for PREDDESC Date: Tue, 9 Mar 2021 07:53:04 -0800 Message-Id: <20210309155305.11301-8-richard.henderson@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210309155305.11301-1-richard.henderson@linaro.org> References: <20210309155305.11301-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::22c; envelope-from=richard.henderson@linaro.org; helo=mail-oi1-x22c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, qemu-arm@nongnu.org, alex.bennee@linaro.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) Content-Type: text/plain; charset="utf-8" Since b64ee454a4a0, all predicate operations should be using these field macros for predicates. Signed-off-by: Richard Henderson --- target/arm/sve_helper.c | 4 ++-- target/arm/translate-sve.c | 7 ++++--- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/target/arm/sve_helper.c b/target/arm/sve_helper.c index a95bbece4f..6f4bc3a3cc 100644 --- a/target/arm/sve_helper.c +++ b/target/arm/sve_helper.c @@ -2850,8 +2850,8 @@ uint64_t HELPER(sve_cntp)(void *vn, void *vg, uint32_= t pred_desc) =20 uint32_t HELPER(sve_while)(void *vd, uint32_t count, uint32_t pred_desc) { - uintptr_t oprsz =3D extract32(pred_desc, 0, SIMD_OPRSZ_BITS) + 2; - intptr_t esz =3D extract32(pred_desc, SIMD_DATA_SHIFT, 2); + intptr_t oprsz =3D FIELD_EX32(pred_desc, PREDDESC, OPRSZ); + intptr_t esz =3D FIELD_EX32(pred_desc, PREDDESC, ESZ); uint64_t esz_mask =3D pred_esz_masks[esz]; ARMPredicateReg *d =3D vd; uint32_t flags; diff --git a/target/arm/translate-sve.c b/target/arm/translate-sve.c index 722805cf99..2420cd741b 100644 --- a/target/arm/translate-sve.c +++ b/target/arm/translate-sve.c @@ -3097,7 +3097,8 @@ static bool trans_WHILE(DisasContext *s, arg_WHILE *a) TCGv_i64 op0, op1, t0, t1, tmax; TCGv_i32 t2, t3; TCGv_ptr ptr; - unsigned desc, vsz =3D vec_full_reg_size(s); + unsigned vsz =3D vec_full_reg_size(s); + unsigned desc =3D 0; TCGCond cond; =20 if (!sve_access_check(s)) { @@ -3161,8 +3162,8 @@ static bool trans_WHILE(DisasContext *s, arg_WHILE *a) /* Scale elements to bits. */ tcg_gen_shli_i32(t2, t2, a->esz); =20 - desc =3D (vsz / 8) - 2; - desc =3D deposit32(desc, SIMD_DATA_SHIFT, 2, a->esz); + desc =3D FIELD_DP32(desc, PREDDESC, OPRSZ, vsz / 8); + desc =3D FIELD_DP32(desc, PREDDESC, ESZ, a->esz); t3 =3D tcg_const_i32(desc); =20 ptr =3D tcg_temp_new_ptr(); --=20 2.25.1