From nobody Wed Nov 19 08:44:16 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.208.41 as permitted sender) client-ip=209.85.208.41; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-ed1-f41.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.208.41 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1615301842; cv=none; d=zohomail.com; s=zohoarc; b=EEpsaVbctz30UoWu1s4v7hK2azd20uRnWT7DNDbULVWn39FB1kfKTqF5qveSnf2HWKIvIDB3sZJ52F8a3qzOltubCPkXb+yxR/xp1HFVysB75Dp4R2KcEVq1QlKvDorDOJbIlnEa3Hh97OA1CWTkQ9tisMQJYWGw4ql4nFmexO8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1615301842; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=XTd3dK5Mj70iaA9wAzBL+3DpQxfmajFVbOdHqCwvUtU=; b=QCKDt4SYMWyj0XRNaspcO81JTvhdEmdl6canQKzRNiwzUtpt/eIua/6yUul7KjUB85k0rQjLMBBO9OGiRD6VZR7YnHRBf1fkRDT8UEZkFzLSZCzctNBAq7v2xjGT3FGrXjkRx48Xku6hxsW6LsSlJk8SQPnu3nCcNcaPqdxKRig= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.208.41 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-ed1-f41.google.com (mail-ed1-f41.google.com [209.85.208.41]) by mx.zohomail.com with SMTPS id 161530184267970.44027984246088; Tue, 9 Mar 2021 06:57:22 -0800 (PST) Received: by mail-ed1-f41.google.com with SMTP id v13so20692612edw.9 for ; Tue, 09 Mar 2021 06:57:22 -0800 (PST) Return-Path: Return-Path: Received: from x1w.redhat.com (68.red-83-57-175.dynamicip.rima-tde.net. [83.57.175.68]) by smtp.gmail.com with ESMTPSA id a3sm8363431ejv.40.2021.03.09.06.57.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Mar 2021 06:57:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=XTd3dK5Mj70iaA9wAzBL+3DpQxfmajFVbOdHqCwvUtU=; b=GFJMRhpclO2wif7QM47XRXh8CYCymLx2CQcNhJLU90ZTBU8v1559gLPIYDlHb0NpV8 R8Lwgjw2BWYrISdz7SL97zcgatj987grZc63JURxe6rXOHqnn4tX9kxOM/AJH3CWamYZ 1QKTiBqfD0uC+VsbSeK/epuF41ZIe/gXLxFc0/97SrKdz32nsRm0rYhvAZWGsxXFJmEz 4P4eG1wSr0MzDbHDiAPhWo2FqQ5ZXCCJ03kJ5s2FNdU5UpQ/mXMSb6Ou7VdkDMfFv0Rq CQ0bD1uF7bIwXMrmIqAd7Qc3CyhC8D889+VdCV7zPywg06ppJAZtJevC8v63QUROsSXK bMJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=XTd3dK5Mj70iaA9wAzBL+3DpQxfmajFVbOdHqCwvUtU=; b=R2QuGxDalZ/Q3/usr5PaJCs/KNZ5pl+IE/+JfBndNj5Hnf0RCXfQoAMGGZ4o6sloHZ HvSNvGW18hfOgSNKHqFdi1jC84qlDW/MpfZX1hechRqpjcsWT0bpa7QS1Y4PCcIngJJF vsx9GykFn8zSMytlb37xfdd17BKnyrUUPOHZ4uBcS72qgKHTeJ2LEba9gIJp8gakAauf bt2mReRF69XE8+B4NfBIB8FOn4IAbyIjTwhmE/p/unOS6CT6dbfNnuZKZ8Tmred9sFJn FKhbpCAaDDVc0IO+yhwddK5bIDP9M4tRW2V6TYsSVMMan0bKhILQHqmal5t45coPxtf4 +v2g== X-Gm-Message-State: AOAM532L+tpH7GSIf7H20aarPU3JAUAyujo6QaRuKq1tG7dts/qx1ngM QBfOdZZjVNPPLBR2pL893Fk= X-Google-Smtp-Source: ABdhPJxkHL1+yKsLZn4Q/aFSgAzqZZl80Gp6XzfdwRl9CZcFX2074VDGSLlINELORPJEAzfpcrm8/A== X-Received: by 2002:a05:6402:30a2:: with SMTP id df2mr4524495edb.29.1615301840906; Tue, 09 Mar 2021 06:57:20 -0800 (PST) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Richard Henderson , Aleksandar Rikalo , Jiaxun Yang , Aurelien Jarno , Fredrik Noring , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [RFC PATCH v2 05/22] target/mips/tx79: Move PCPYH opcode to decodetree Date: Tue, 9 Mar 2021 15:56:36 +0100 Message-Id: <20210309145653.743937-6-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210309145653.743937-1-f4bug@amsat.org> References: <20210309145653.743937-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) Move the existing PCPYH opcode (Parallel Copy Halfword) to decodetree. Remove unnecessary code / comments. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson Message-Id: <20210214175912.732946-12-f4bug@amsat.org> Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- target/mips/tx79.decode | 5 +++++ target/mips/translate.c | 39 ------------------------------------ target/mips/tx79_translate.c | 22 ++++++++++++++++++++ 3 files changed, 27 insertions(+), 39 deletions(-) diff --git a/target/mips/tx79.decode b/target/mips/tx79.decode index 30737da54e4..7af35458b0a 100644 --- a/target/mips/tx79.decode +++ b/target/mips/tx79.decode @@ -17,6 +17,7 @@ # Named instruction formats. These are generally used to # reduce the amount of duplication between instruction patterns. =20 +@rt_rd ...... ..... rt:5 rd:5 ..... ...... &rtype rs=3D0 sa= =3D0 @rs ...... rs:5 ..... .......... ...... &rtype rt=3D0 rd= =3D0 sa=3D0 @rd ...... .......... rd:5 ..... ...... &rtype rs=3D0 rt= =3D0 sa=3D0 =20 @@ -26,3 +27,7 @@ MFHI1 011100 0000000000 ..... 00000 010000 @= rd MTHI1 011100 ..... 0000000000 00000 010001 @rs MFLO1 011100 0000000000 ..... 00000 010010 @rd MTLO1 011100 ..... 0000000000 00000 010011 @rs + +# MMI3 + +PCPYH 011100 00000 ..... ..... 11011 101001 @rt_rd diff --git a/target/mips/translate.c b/target/mips/translate.c index 9de81b08665..25adaa75eb5 100644 --- a/target/mips/translate.c +++ b/target/mips/translate.c @@ -24062,42 +24062,6 @@ static void decode_opc_special(CPUMIPSState *env, = DisasContext *ctx) * PEXTUW */ =20 -/* - * PCPYH rd, rt - * - * Parallel Copy Halfword - * - * 1 0 9 8 7 6 5 4 3 2 1 0 9 8 7 6 5 4 3 2 1 0 9 8 7 6 5 4 3 2 1 0 - * +-----------+---------+---------+---------+---------+-----------+ - * | MMI |0 0 0 0 0| rt | rd | PCPYH | MMI3 | - * +-----------+---------+---------+---------+---------+-----------+ - */ -static void gen_mmi_pcpyh(DisasContext *ctx) -{ - uint32_t pd, rt, rd; - uint32_t opcode; - - opcode =3D ctx->opcode; - - pd =3D extract32(opcode, 21, 5); - rt =3D extract32(opcode, 16, 5); - rd =3D extract32(opcode, 11, 5); - - if (unlikely(pd !=3D 0)) { - gen_reserved_instruction(ctx); - } else if (rd =3D=3D 0) { - /* nop */ - } else if (rt =3D=3D 0) { - tcg_gen_movi_i64(cpu_gpr[rd], 0); - tcg_gen_movi_i64(cpu_gpr_hi[rd], 0); - } else { - tcg_gen_deposit_i64(cpu_gpr[rd], cpu_gpr[rt], cpu_gpr[rt], 16, 16); - tcg_gen_deposit_i64(cpu_gpr[rd], cpu_gpr[rd], cpu_gpr[rd], 32, 32); - tcg_gen_deposit_i64(cpu_gpr_hi[rd], cpu_gpr_hi[rt], cpu_gpr_hi[rt]= , 16, 16); - tcg_gen_deposit_i64(cpu_gpr_hi[rd], cpu_gpr_hi[rd], cpu_gpr_hi[rd]= , 32, 32); - } -} - /* * PCPYLD rd, rs, rt * @@ -25016,9 +24980,6 @@ static void decode_mmi3(CPUMIPSState *env, DisasCon= text *ctx) case MMI_OPC_3_PEXCW: /* TODO: MMI_OPC_3_PEXCW */ gen_reserved_instruction(ctx); /* TODO: MMI_OPC_CLASS_MMI3 */ break; - case MMI_OPC_3_PCPYH: - gen_mmi_pcpyh(ctx); - break; case MMI_OPC_3_PCPYUD: gen_mmi_pcpyud(ctx); break; diff --git a/target/mips/tx79_translate.c b/target/mips/tx79_translate.c index 905245cece7..d58b4fcd7b3 100644 --- a/target/mips/tx79_translate.c +++ b/target/mips/tx79_translate.c @@ -49,3 +49,25 @@ static bool trans_MTLO1(DisasContext *ctx, arg_rtype *a) =20 return true; } + +/* Parallel Copy Halfword */ +static bool trans_PCPYH(DisasContext *s, arg_rtype *a) +{ + if (a->rd =3D=3D 0) { + /* nop */ + return true; + } + + if (a->rt =3D=3D 0) { + tcg_gen_movi_i64(cpu_gpr[a->rd], 0); + tcg_gen_movi_i64(cpu_gpr_hi[a->rd], 0); + return true; + } + + tcg_gen_deposit_i64(cpu_gpr[a->rd], cpu_gpr[a->rt], cpu_gpr[a->rt], 16= , 16); + tcg_gen_deposit_i64(cpu_gpr[a->rd], cpu_gpr[a->rd], cpu_gpr[a->rd], 32= , 32); + tcg_gen_deposit_i64(cpu_gpr_hi[a->rd], cpu_gpr_hi[a->rt], cpu_gpr_hi[a= ->rt], 16, 16); + tcg_gen_deposit_i64(cpu_gpr_hi[a->rd], cpu_gpr_hi[a->rd], cpu_gpr_hi[a= ->rd], 32, 32); + + return true; +} --=20 2.26.2