From nobody Wed Nov 19 10:13:12 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.218.46 as permitted sender) client-ip=209.85.218.46; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-ej1-f46.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.218.46 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1615301837; cv=none; d=zohomail.com; s=zohoarc; b=bZDb3xIpwqKbrdaud5UIhU3r492gL/fXKawQWDKE0jGpSceZG6h+JuxUpLG2I2hKHNIfnGWqsn20Q6Tso/O2N0d8Boq0Ow6GrkodqywrSNNTjInvu63rzNF806X2MrPjNrIC8k/zZ4CY690dJgMis5sGD+Us5P25K32s6rb5zhQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1615301837; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=MSauL6XiWqe7pdli7sYj4+exNHtcFAP8QrNM1PNuIkg=; b=mHPpDNGZf4JdsbnjD2NkUrrPgzPGbniEApyGvn/YbWI2urSQBnU5f4IyuKcC3Xxludk86Rxhh8KD44Axvzt+SlnxqjW7BLvHser5EIds8bkm5DoIP/FQlsgpg6CAdj40HtTjDvVfwzteFPHvG6f/uQk12jUjdC6O8f4naAp6s18= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.218.46 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-ej1-f46.google.com (mail-ej1-f46.google.com [209.85.218.46]) by mx.zohomail.com with SMTPS id 1615301837633781.9337729473506; Tue, 9 Mar 2021 06:57:17 -0800 (PST) Received: by mail-ej1-f46.google.com with SMTP id ci14so28394409ejc.7 for ; Tue, 09 Mar 2021 06:57:16 -0800 (PST) Return-Path: Return-Path: Received: from x1w.redhat.com (68.red-83-57-175.dynamicip.rima-tde.net. [83.57.175.68]) by smtp.gmail.com with ESMTPSA id bt14sm9410462edb.92.2021.03.09.06.57.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Mar 2021 06:57:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=MSauL6XiWqe7pdli7sYj4+exNHtcFAP8QrNM1PNuIkg=; b=GpM9heVTQTGztz17jWx41Vtlhym5ZfHrYB0PYnftarbK3kcn1wMXkGFDx/a4u5GGAB VFcTWn92TL8+xh28Za5CXZdzOEAWF213QCN1Gs8v5vRH7/W7VADFF2jpartAy+FrvDz3 ohFOIOKz+MwA0VgAxMy8mlor39Ta4nk1pc+cNlMLvlAifLhVpPbxCYZEyTMPQ9/piDSm MkfmK/mbdYTIw0FiQ6pkr9/a/sWKdfsMBi4vjB72jMKH1hWkHUxhsAeTiamBMPz/tcZt aTfpvEPSPiwGyJpaiIOc+MWFXDqb8jzqDzSpo3CKTpUWcKuVE7RXLcdgmiv8qI3bko0l mLYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=MSauL6XiWqe7pdli7sYj4+exNHtcFAP8QrNM1PNuIkg=; b=IQp20I0drlMejYPW9pikbgY+BWbO2VrUQeokt00y+rBLCV+bJ/dxwRrRJRj/yHxGwi O9QH0kRNjaAk1uog4o6xl95SmxI4hIE5JzdIn44Pz1B6UixjGKICLeFth2id9xdUJzja lztkP+g/x2Zutzc7j7W+9jcdoCEN9cSvPOGWqJGeY+3lg6W+1A3/pImOKsbT9UkBzQK/ eRi2BiWbqq7wfXIMAWpO4aWMuNTsSdu76uLxGFwBhI147hsH69SapAGdIPgZR097GrVf wRmH0ReLOKcNG7tI1p63JNEcWjVu+7C2mEWWEQzwBp8QQCzYTjfuf3kPuNgxmwCdqjhv OlZg== X-Gm-Message-State: AOAM5338+vo6nzFmM3ENE2LTOQHcQJmYJW9vIt+0bn/RVNh/nVjNlesx jRWP5ux66BWTQCSCIJ1Kuog= X-Google-Smtp-Source: ABdhPJwg4QWEP05kqjQoXKYj1sy7kGmiJuTvmvz291ryVJ58QQKGiyNivHboB1T9T/OmkSs8Sztw5g== X-Received: by 2002:a17:906:7150:: with SMTP id z16mr20294605ejj.103.1615301835750; Tue, 09 Mar 2021 06:57:15 -0800 (PST) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Richard Henderson , Aleksandar Rikalo , Jiaxun Yang , Aurelien Jarno , Fredrik Noring , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [RFC PATCH v2 04/22] target/mips/translate: Simplify PCPYH using deposit_i64() Date: Tue, 9 Mar 2021 15:56:35 +0100 Message-Id: <20210309145653.743937-5-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210309145653.743937-1-f4bug@amsat.org> References: <20210309145653.743937-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) Simplify the PCPYH (Parallel Copy Halfword) instruction by using multiple calls to deposit_i64() which can be optimized by some TCG backends. Suggested-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson Message-Id: <20210214175912.732946-11-f4bug@amsat.org> Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- target/mips/translate.c | 34 ++++------------------------------ 1 file changed, 4 insertions(+), 30 deletions(-) diff --git a/target/mips/translate.c b/target/mips/translate.c index 0f77c0ebc57..9de81b08665 100644 --- a/target/mips/translate.c +++ b/target/mips/translate.c @@ -24091,36 +24091,10 @@ static void gen_mmi_pcpyh(DisasContext *ctx) tcg_gen_movi_i64(cpu_gpr[rd], 0); tcg_gen_movi_i64(cpu_gpr_hi[rd], 0); } else { - TCGv_i64 t0 =3D tcg_temp_new(); - TCGv_i64 t1 =3D tcg_temp_new(); - uint64_t mask =3D (1ULL << 16) - 1; - - tcg_gen_andi_i64(t0, cpu_gpr[rt], mask); - tcg_gen_movi_i64(t1, 0); - tcg_gen_or_i64(t1, t0, t1); - tcg_gen_shli_i64(t0, t0, 16); - tcg_gen_or_i64(t1, t0, t1); - tcg_gen_shli_i64(t0, t0, 16); - tcg_gen_or_i64(t1, t0, t1); - tcg_gen_shli_i64(t0, t0, 16); - tcg_gen_or_i64(t1, t0, t1); - - tcg_gen_mov_i64(cpu_gpr[rd], t1); - - tcg_gen_andi_i64(t0, cpu_gpr_hi[rt], mask); - tcg_gen_movi_i64(t1, 0); - tcg_gen_or_i64(t1, t0, t1); - tcg_gen_shli_i64(t0, t0, 16); - tcg_gen_or_i64(t1, t0, t1); - tcg_gen_shli_i64(t0, t0, 16); - tcg_gen_or_i64(t1, t0, t1); - tcg_gen_shli_i64(t0, t0, 16); - tcg_gen_or_i64(t1, t0, t1); - - tcg_gen_mov_i64(cpu_gpr_hi[rd], t1); - - tcg_temp_free(t0); - tcg_temp_free(t1); + tcg_gen_deposit_i64(cpu_gpr[rd], cpu_gpr[rt], cpu_gpr[rt], 16, 16); + tcg_gen_deposit_i64(cpu_gpr[rd], cpu_gpr[rd], cpu_gpr[rd], 32, 32); + tcg_gen_deposit_i64(cpu_gpr_hi[rd], cpu_gpr_hi[rt], cpu_gpr_hi[rt]= , 16, 16); + tcg_gen_deposit_i64(cpu_gpr_hi[rd], cpu_gpr_hi[rd], cpu_gpr_hi[rd]= , 32, 32); } } =20 --=20 2.26.2