From nobody Wed Nov 19 10:11:11 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.208.46 as permitted sender) client-ip=209.85.208.46; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-ed1-f46.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.208.46 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1615301827; cv=none; d=zohomail.com; s=zohoarc; b=m4eXnRNsb+UGtKmbPI5W8ZtxCrKIW0XaFYShtSJUJvLeQfwOBJ35s1nfLC/LSl/+y4eCSUYu9UPTws0ND63EtZmtY30ysHbcIQVlX/LnzJukvdY3KABPuR+HHhd21/bG3J7lNw3EoJVXTilRfW4bmiFLo1ILYvUU+MN8cdQcugo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1615301827; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=r5fiD8J1cTEppASnTHaHX7DmQkr6qX0i8N0ojoebTOk=; b=HPSZ5QjMCgTuZJozcTaoX7VELoXNWffFnnEgaYagJCQ31aRswmXBKS/eI+F/heHPZWK89EDXFHJvKbEE9BxNJf0RrU0VQD9ZFuOHh/QXHUKv2FUIbS6dUmypNLJLB+gr87XWkWBZZx8fAjQlFfmwVtwNkYSXQSoaEc5YX2Vbg9w= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.208.46 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-ed1-f46.google.com (mail-ed1-f46.google.com [209.85.208.46]) by mx.zohomail.com with SMTPS id 1615301827409974.5756451335786; Tue, 9 Mar 2021 06:57:07 -0800 (PST) Received: by mail-ed1-f46.google.com with SMTP id d13so20772206edp.4 for ; Tue, 09 Mar 2021 06:57:06 -0800 (PST) Return-Path: Return-Path: Received: from x1w.redhat.com (68.red-83-57-175.dynamicip.rima-tde.net. [83.57.175.68]) by smtp.gmail.com with ESMTPSA id yk8sm8443477ejb.123.2021.03.09.06.57.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Mar 2021 06:57:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=r5fiD8J1cTEppASnTHaHX7DmQkr6qX0i8N0ojoebTOk=; b=vHs31r4bJKiYjNl2oZnEQBEsM+VOleMQbha5a8FD99l4s7PeibEZaOQ5IXOG9eAWHo F+YbADOnIjM/pRC7ci5BxHX1YUo9XLO7S9LQ6a6O5g7dFUDqktjMYn8eRcYdRWiMS8dj p/Jw6TXPqEmSwYSYvLL4gbrE6eTreTM5R8H1KlOLJiwQ6zTuqAND3rjsw1Xg0BB2F2TU BjXrv31/3ndIKF/VEkhwGPcSrkThKfX/2Q2vraZ3i/PXSgoIGUU2P0/4ewB/ViHaoBd+ s+7cJqh2Kbh9cgiovTy2duQ+B4cOA5NpS98NSpnTjjOqxhddNF8xtwOT5k5Nis4O5n38 Uekw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=r5fiD8J1cTEppASnTHaHX7DmQkr6qX0i8N0ojoebTOk=; b=ggxydQtVSF5obgBVY99Jl9+wkUubsTA5AwO5m2RaFRPYVN3oTe4/egfw9wyaFfJAir hNzPvD21+PIECG4NZT4Qucaqsn81aZcfGqqfLfL3/birFZwZa8mfm2NCbhBucPJZk/nU V/wFitLmTXgdYzN1rWBZxNtm/GvpDzD2f1heh7/AW1Y5caW4iT/XVv+RGnNUaMXZAbUW jH0lQobO784ynN3yM3lttoeAcq4SFkDc8HYBZUV2T/u7ALmWoRZh28iLfe2N9kOeIcJ/ 6VFlHW6KB4ZaX+DIoIPge+qaTN98Xk7nFDnO5R1W0VcopLFOTfLc4Yp9A6ef5k9EINRK cE+g== X-Gm-Message-State: AOAM531BLOVt4NGBzAG0r1eGKwjWFIxvxG8OkMX8URreVhVHPcHqGiPR +tXNMXlAgh3gdR5ofatbUWPvbtLIhfg= X-Google-Smtp-Source: ABdhPJwz7kBD2d+s7MWKjTnqXFOShL8oOOjsH4fZqcqnJl52greVTLOjbby4uAS7vPDFil/jl57Tsg== X-Received: by 2002:a05:6402:2695:: with SMTP id w21mr4534663edd.99.1615301825641; Tue, 09 Mar 2021 06:57:05 -0800 (PST) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Richard Henderson , Aleksandar Rikalo , Jiaxun Yang , Aurelien Jarno , Fredrik Noring , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [RFC PATCH v2 02/22] target/mips/tx79: Move MTHI1 / MTLO1 opcodes to decodetree Date: Tue, 9 Mar 2021 15:56:33 +0100 Message-Id: <20210309145653.743937-3-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210309145653.743937-1-f4bug@amsat.org> References: <20210309145653.743937-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson Message-Id: <20210214175912.732946-10-f4bug@amsat.org> Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- target/mips/tx79.decode | 3 +++ target/mips/translate.c | 25 ------------------------- target/mips/tx79_translate.c | 14 ++++++++++++++ 3 files changed, 17 insertions(+), 25 deletions(-) diff --git a/target/mips/tx79.decode b/target/mips/tx79.decode index 2e287ebbf36..30737da54e4 100644 --- a/target/mips/tx79.decode +++ b/target/mips/tx79.decode @@ -17,9 +17,12 @@ # Named instruction formats. These are generally used to # reduce the amount of duplication between instruction patterns. =20 +@rs ...... rs:5 ..... .......... ...... &rtype rt=3D0 rd= =3D0 sa=3D0 @rd ...... .......... rd:5 ..... ...... &rtype rs=3D0 rt= =3D0 sa=3D0 =20 ########################################################################### =20 MFHI1 011100 0000000000 ..... 00000 010000 @rd +MTHI1 011100 ..... 0000000000 00000 010001 @rs MFLO1 011100 0000000000 ..... 00000 010010 @rd +MTLO1 011100 ..... 0000000000 00000 010011 @rs diff --git a/target/mips/translate.c b/target/mips/translate.c index aa35d0f680e..0131affce70 100644 --- a/target/mips/translate.c +++ b/target/mips/translate.c @@ -1360,8 +1360,6 @@ enum { MMI_OPC_PLZCW =3D 0x04 | MMI_OPC_CLASS_MMI, MMI_OPC_CLASS_MMI0 =3D 0x08 | MMI_OPC_CLASS_MMI, MMI_OPC_CLASS_MMI2 =3D 0x09 | MMI_OPC_CLASS_MMI, - MMI_OPC_MTHI1 =3D 0x11 | MMI_OPC_CLASS_MMI, /* Same minor as OPC_= MTHI */ - MMI_OPC_MTLO1 =3D 0x13 | MMI_OPC_CLASS_MMI, /* Same minor as OPC_= MTLO */ MMI_OPC_MULT1 =3D 0x18 | MMI_OPC_CLASS_MMI, /* Same minor as OPC_= MULT */ MMI_OPC_MULTU1 =3D 0x19 | MMI_OPC_CLASS_MMI, /* Same min. as OPC_M= ULTU */ MMI_OPC_DIV1 =3D 0x1A | MMI_OPC_CLASS_MMI, /* Same minor as OPC_= DIV */ @@ -3462,25 +3460,6 @@ static void gen_shift(DisasContext *ctx, uint32_t op= c, tcg_temp_free(t1); } =20 -#if defined(TARGET_MIPS64) -/* Copy GPR to and from TX79 HI1/LO1 register. */ -static void gen_HILO1_tx79(DisasContext *ctx, uint32_t opc, int reg) -{ - switch (opc) { - case MMI_OPC_MTHI1: - gen_load_gpr(cpu_HI[1], reg); - break; - case MMI_OPC_MTLO1: - gen_load_gpr(cpu_LO[1], reg); - break; - default: - MIPS_INVAL("mfthilo1 TX79"); - gen_reserved_instruction(ctx); - break; - } -} -#endif - /* Arithmetic on HI/LO registers */ static void gen_HILO(DisasContext *ctx, uint32_t opc, int acc, int reg) { @@ -25108,10 +25087,6 @@ static void decode_mmi(CPUMIPSState *env, DisasCon= text *ctx) case MMI_OPC_DIVU1: gen_div1_tx79(ctx, opc, rs, rt); break; - case MMI_OPC_MTLO1: - case MMI_OPC_MTHI1: - gen_HILO1_tx79(ctx, opc, rs); - break; case MMI_OPC_PLZCW: /* TODO: MMI_OPC_PLZCW */ case MMI_OPC_PMFHL: /* TODO: MMI_OPC_PMFHL */ case MMI_OPC_PMTHL: /* TODO: MMI_OPC_PMTHL */ diff --git a/target/mips/tx79_translate.c b/target/mips/tx79_translate.c index 22bd6033e55..905245cece7 100644 --- a/target/mips/tx79_translate.c +++ b/target/mips/tx79_translate.c @@ -35,3 +35,17 @@ static bool trans_MFLO1(DisasContext *ctx, arg_rtype *a) =20 return true; } + +static bool trans_MTHI1(DisasContext *ctx, arg_rtype *a) +{ + gen_load_gpr(cpu_HI[1], a->rs); + + return true; +} + +static bool trans_MTLO1(DisasContext *ctx, arg_rtype *a) +{ + gen_load_gpr(cpu_LO[1], a->rs); + + return true; +} --=20 2.26.2