From nobody Mon Feb 9 22:39:02 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.208.50 as permitted sender) client-ip=209.85.208.50; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-ed1-f50.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.208.50 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1615299999; cv=none; d=zohomail.com; s=zohoarc; b=C80j4TH6+afQ5ZoL6bCgZ1ePBiS7r1TdZooGPWYh6UjRoy4SE+1TgsIFDnrEEm0X5vQp1IXAEac43D2lYpQDwZ0JjAKzFeGsTaPiz+2iEkYrOmeeGaOspx+iVvxh2Fv51De3/EyHH80lASYs4xBAuGtIDl+vA4KO9yiwQ5awNLU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1615299999; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=EVB7ePXcQjZw4uETcObG8sFKSRsuTJl6nrIlWHavPsM=; b=f4zJHNyYDwluY0XiNnkMTz9T6pkwnkiNan743FQXXslCoJgZQA+cVavWiKhbCHf249dIjBadhFrseEChvW1rPTP76vkehv6oupsDMXqKvsEyJ2fg4gB5EpacJNlezqWW2bumkoHpPhswoIii25x3KFjvg3vawzjJHalwcud1JCY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.208.50 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-ed1-f50.google.com (mail-ed1-f50.google.com [209.85.208.50]) by mx.zohomail.com with SMTPS id 1615299999313778.7756381964916; Tue, 9 Mar 2021 06:26:39 -0800 (PST) Received: by mail-ed1-f50.google.com with SMTP id m9so20468220edd.5 for ; Tue, 09 Mar 2021 06:26:38 -0800 (PST) Return-Path: Return-Path: Received: from x1w.redhat.com (68.red-83-57-175.dynamicip.rima-tde.net. [83.57.175.68]) by smtp.gmail.com with ESMTPSA id u16sm9361089edq.4.2021.03.09.06.26.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Mar 2021 06:26:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=EVB7ePXcQjZw4uETcObG8sFKSRsuTJl6nrIlWHavPsM=; b=Oa1mRk2S+YDQ4qA1OBgVLC+5cxUzHGUx9hBqoe2c9FEDs7LtqS72Nd/D0AOsE2CM1J MQXXrSSIilXP2TxoDFS+XUxBXqlKi3Oqz8OJrVvovhgcxnz0FJO4XXPtHR55WWR9fAU0 GHPRrlMXbowfdMcwC0+3iUDc97IFSYOotRHfhcUoI/9LHrMeiWpJ4AAnJD+BxKkHHitj u5O1tPc2fW4g8B0dAfXIcYi4w/AdwqiiiscfZp97r42dkrR1/3U75ruatMVHLcidpnV2 yM5xMYvdueAv/40EEW1mYzstDBBXrmPpEYaH8Ht3GCyCOf0LSHtzryKuhr87Xwy8nYq2 d3UQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=EVB7ePXcQjZw4uETcObG8sFKSRsuTJl6nrIlWHavPsM=; b=j+H/ubmNJYlGfBG5jZh5iXQhTSxp0f3odn4MzTm6tcbhRoz199ODd4XP3LRfwyELlm KlcX8lEQd4LZta3bEgLtlRRKJnE/Zyrg5AaX7FJWM+Qa51U2kaWN0LX/9/57Ds3s1FLk NZRVZo4NP7zx+HZJy7KayGuCqT5xiCEc/BB47u0EjcxpgM7V4QCNkDMIdcJk1UnrBcKy 94en0TLCifuMBTXeydsYe8WoOP3/ZbrjggT3x6PtXxYfXMvbYdkBdYUf9eywKLLqEKgJ liamPrq75BhBIdhfa9xyHKhmCeUt02szcroju3iDvmwGiEmCEfNGuRxLl0q4TxT0CZ5v UgHw== X-Gm-Message-State: AOAM531vYzfQ88/y/cMMcrNnEBYNEiDlvudhSaBuMgC6apIxyHG4L6OQ Acx/wF7LSwYPsYkyN7Mh8T4= X-Google-Smtp-Source: ABdhPJx1XLXIp2cWD2NoiJAPf3mjBP+R3DmREU2o4gkHTTuR0Rq0Z51VBBM06z0f0OfAZJdzhWFLJA== X-Received: by 2002:aa7:dc04:: with SMTP id b4mr4360579edu.221.1615299997608; Tue, 09 Mar 2021 06:26:37 -0800 (PST) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Aleksandar Rikalo , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Aurelien Jarno , Jiaxun Yang , BALATON Zoltan Subject: [PATCH RESEND 1/6] hw/mips/gt64xxx: Initialize ISD I/O memory region in DeviceRealize() Date: Tue, 9 Mar 2021 15:26:25 +0100 Message-Id: <20210309142630.728014-2-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210309142630.728014-1-f4bug@amsat.org> References: <20210309142630.728014-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) The ISD I/O region belongs to the TYPE_GT64120_PCI_HOST_BRIDGE, so initialize it before it is realized, not after. Rename the region as 'gt64120-isd' so it is clearer to realize it belongs to the GT64120 in the memory tree view. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: BALATON Zoltan --- hw/mips/gt64xxx_pci.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/hw/mips/gt64xxx_pci.c b/hw/mips/gt64xxx_pci.c index 588e6f99301..6eb73e77057 100644 --- a/hw/mips/gt64xxx_pci.c +++ b/hw/mips/gt64xxx_pci.c @@ -1196,6 +1196,14 @@ static void gt64120_reset(DeviceState *dev) gt64120_pci_mapping(s); } =20 +static void gt64120_realize(DeviceState *dev, Error **errp) +{ + GT64120State *s =3D GT64120_PCI_HOST_BRIDGE(dev); + + memory_region_init_io(&s->ISD_mem, OBJECT(dev), &isd_mem_ops, s, + "gt64120-isd", 0x1000); +} + PCIBus *gt64120_register(qemu_irq *pic) { GT64120State *d; @@ -1214,8 +1222,6 @@ PCIBus *gt64120_register(qemu_irq *pic) get_system_io(), PCI_DEVFN(18, 0), 4, TYPE_PCI_BUS); sysbus_realize_and_unref(SYS_BUS_DEVICE(dev), &error_fatal); - memory_region_init_io(&d->ISD_mem, OBJECT(dev), &isd_mem_ops, d, - "isd-mem", 0x1000); =20 pci_create_simple(phb->bus, PCI_DEVFN(0, 0), "gt64120_pci"); return phb->bus; @@ -1270,6 +1276,7 @@ static void gt64120_class_init(ObjectClass *klass, vo= id *data) DeviceClass *dc =3D DEVICE_CLASS(klass); =20 set_bit(DEVICE_CATEGORY_BRIDGE, dc->categories); + dc->realize =3D gt64120_realize; dc->reset =3D gt64120_reset; dc->vmsd =3D &vmstate_gt64120; } --=20 2.26.2