From nobody Wed Nov 19 07:07:36 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1615297676; cv=none; d=zohomail.com; s=zohoarc; b=HRYi745Q4lr6RLytp/BjsPJoeyql3nvxr6MBLdc/3xZTkSI2KpEd2A03InzjMiVOek9zFj1wOWKKBH4SfEz1pYa/uQzAIvNhyzDn03nmGFi94wiZAbx7J+aSkv9ck9X+mB+1TSNa+FDUbaTuGlNTrpacEDsyIuJ/aq37wruwuRM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1615297676; h=Content-Transfer-Encoding:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=GcK/2jjSRhgYCHWQF1KkIFwILgjiubXjMmZkZUi/zM4=; b=Z1UE8wGDqwoSbEo8Gg17+VI3c8CLIqBgQ4of7+915OQg81dlXQel9+uCuR2ubD+ezd2qUnjQSOzDG3vVkbOLfZDJeEVBj71Kb9xIqsOIlGh9k7Xz/iW9yzf5l9ShluneEIKAhfMc/i0AlPxFMtduwuwlhQR07XHwqYeQearI07k= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1615297676875602.8467989310678; Tue, 9 Mar 2021 05:47:56 -0800 (PST) Received: from localhost ([::1]:44668 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lJciI-0001ky-Fi for importer@patchew.org; Tue, 09 Mar 2021 08:47:54 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:56214) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lJchW-0001LM-1K for qemu-devel@nongnu.org; Tue, 09 Mar 2021 08:47:06 -0500 Received: from mail-ed1-x534.google.com ([2a00:1450:4864:20::534]:45955) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lJchU-0004G0-79 for qemu-devel@nongnu.org; Tue, 09 Mar 2021 08:47:05 -0500 Received: by mail-ed1-x534.google.com with SMTP id dm26so20132271edb.12 for ; Tue, 09 Mar 2021 05:47:03 -0800 (PST) Received: from avogadro.redhat.com ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id y16sm8660948ejk.43.2021.03.09.05.47.01 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Mar 2021 05:47:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=GcK/2jjSRhgYCHWQF1KkIFwILgjiubXjMmZkZUi/zM4=; b=N3Vq1pH3WxfgEYT4O5v0gJbkceq0I453NBRI6ddcSLZk9uCNXmyLXOOVXvUrKGoRDG EGHB+5GKvlHEfFRI6ktHvu89fngzeuFfIWPDAZlx3sHfLiyczT83zm5Q1vAibQTI57P4 yhMQOPCueIUn1HYlQH4r6pdfc9gyl1fLsp7p+PGU7fhmHfQwLm7qbCO2zMQu7JRW1B2P aivIk4Gj+cbQ6F0r852Ss3a5swOMleBC/YdDISotVtostHY35K4YAyHADfs2UOVd3+fH ZGqeuWMTAftuBJsFB4EC+8X2MQ0XIF6gQHgMccgvylx5IgCkmEkaJXJEzCmZcoU6SKZy vH2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:subject:date:message-id :mime-version:content-transfer-encoding; bh=GcK/2jjSRhgYCHWQF1KkIFwILgjiubXjMmZkZUi/zM4=; b=YaSCrEZt+VkcKzpi7GesiNbZ7TPgA5XXkToL3tyHTL0fFMmr8P0vTxTqQp1fdQHYB/ TUqlyLdgEMDdKPAAB2jaD1XuvzFKlQW4ZzKfNOaadUyLn4LOuVsuCLNPDPb9BxqvQ4yG NkQtPxT/J11paJhwXhZgW88EAsyBqdt6VhAtPNYHmMgp5iacxRCCR0qb0qMF60KupyAn kdhziNKz4SpasoCPUhkAyLzC5QZ6bZkgpcSKcgZoYLCRX5Here4SFlD/aLgc/iy58/u4 usAaSLlAxljZC/G4Zc0exztZeEhvmi4qs9wSZt89Mf4FzEr8jfiTIAogQA+d3Fi5ilj3 VfGw== X-Gm-Message-State: AOAM532bkbOmHbMJ+kWuQtNg9isjtMS+OvlTwZYMOxB5trz7pOP+8x54 irOHhAsVDXXkwOM1wnY8tLJlF+i4yZo= X-Google-Smtp-Source: ABdhPJwUImF7qx0AH9fe8OtkD358NPnnjfFJiq/kOzP5gsl9RMfDWy3GN+pUBQR1ElJyUlo3ni7L5A== X-Received: by 2002:aa7:cf02:: with SMTP id a2mr4158809edy.59.1615297621644; Tue, 09 Mar 2021 05:47:01 -0800 (PST) From: Paolo Bonzini To: qemu-devel@nongnu.org Subject: [PATCH] Revert "accel: kvm: Add aligment assert for kvm_log_clear_one_slot" Date: Tue, 9 Mar 2021 14:47:00 +0100 Message-Id: <20210309134700.186694-1-pbonzini@redhat.com> X-Mailer: git-send-email 2.29.2 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::534; envelope-from=paolo.bonzini@gmail.com; helo=mail-ed1-x534.google.com X-Spam_score_int: -14 X-Spam_score: -1.5 X-Spam_bar: - X-Spam_report: (-1.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" This reverts commit 3920552846e881bafa9f9aad0bb1a6eef874d7fb. Thomas Huth reported a failure with CentOS 6 guests: ../../devel/qemu/accel/kvm/kvm-all.c:690: kvm_log_clear_one_slot: Assertion= `QEMU_IS_ALIGNED(start | size, psize)' failed. Signed-off-by: Paolo Bonzini --- accel/kvm/kvm-all.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c index f88a52393f..ffce83f1a7 100644 --- a/accel/kvm/kvm-all.c +++ b/accel/kvm/kvm-all.c @@ -673,10 +673,6 @@ out: #define KVM_CLEAR_LOG_ALIGN (qemu_real_host_page_size << KVM_CLEAR_LOG_SH= IFT) #define KVM_CLEAR_LOG_MASK (-KVM_CLEAR_LOG_ALIGN) =20 -/* - * As the granule of kvm dirty log is qemu_real_host_page_size, - * @start and @size are expected and restricted to align to it. - */ static int kvm_log_clear_one_slot(KVMSlot *mem, int as_id, uint64_t start, uint64_t size) { @@ -686,9 +682,6 @@ static int kvm_log_clear_one_slot(KVMSlot *mem, int as_= id, uint64_t start, unsigned long *bmap_clear =3D NULL, psize =3D qemu_real_host_page_size; int ret; =20 - /* Make sure start and size are qemu_real_host_page_size aligned */ - assert(QEMU_IS_ALIGNED(start | size, psize)); - /* * We need to extend either the start or the size or both to * satisfy the KVM interface requirement. Firstly, do the start --=20 2.29.2