From nobody Mon Feb 9 11:30:18 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1615292160; cv=none; d=zohomail.com; s=zohoarc; b=L5VHv79dcajv67HpQpcrQTyAf2fJr/QfgA+6WDpBXTTeEbBGiYzAwGYnI66qP2jdTZ/0g5efXUZ4SpqV2HOYlSSkxUC/1gokR9MXWeywj8LpQtWVpZ34cs6cAsHAb968VgJOjDR2f2ehLFtvaWUkpBeH9sx4if8r/AFBigs9tFw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1615292160; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=UrKdYwGrVaGOulNLHfnJ/mvHVJitFlGANq1iGrvBrjE=; b=HXys7L1npyueDPDO5kDVa27jU4roSdUSDO05UHjWa/xNkIHG6Klzi71j/3fnrdTD/MbbreMckFIbLxHKTXn1WeBxDtwQkgA6wIXjnP11/ZBVKM6TRSscVU0YsVWqn1uf8dIq1XKga+c43/z/JlYc8hTaQd83Y/kEKPJn/wae8b8= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1615292159971631.0776185819598; Tue, 9 Mar 2021 04:15:59 -0800 (PST) Received: from localhost ([::1]:41184 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lJbHK-0001u8-DJ for importer@patchew.org; Tue, 09 Mar 2021 07:15:58 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:42960) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lJao1-0008SX-WF; Tue, 09 Mar 2021 06:45:42 -0500 Received: from wnew1-smtp.messagingengine.com ([64.147.123.26]:56397) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lJao0-0000OO-4g; Tue, 09 Mar 2021 06:45:41 -0500 Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailnew.west.internal (Postfix) with ESMTP id D4E762705; Tue, 9 Mar 2021 06:45:37 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Tue, 09 Mar 2021 06:45:38 -0500 Received: from apples.local (80-167-98-190-cable.dk.customer.tdc.net [80.167.98.190]) by mail.messagingengine.com (Postfix) with ESMTPA id C69AF24005A; Tue, 9 Mar 2021 06:45:34 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=irrelevant.dk; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; s=fm2; bh=UrKdYwGrVaGOu lNLHfnJ/mvHVJitFlGANq1iGrvBrjE=; b=OF5l4nh3Sw5Hw5JL5VP1bV61KMfrl fMVkCpyB9Vecsjk8tbocVkEjubnP+a8PriqLzHDO2VNdA/XnfvRrJS9MIfMBeog7 9NpJe9r1ZWF3PEPY9kmZp105wvT5g6U5P40B9c5nQTig//ij1fFKjAy6dV1aPWWS jF1YHRnA23T2fRH1IViw6BYe737X6gyj4v2FKBmTglJw2wttjdvOI/JNbNlDEdPg kYjLPTdMV6WcvSnasd7MbrwFLsRz2pXimOBLKnX2VkActvQmSn0LBn6k79khfllS h2A5h+b8zP6ZqoiD9YJ9oPrEmzYGOG2Nn0qeYM18hxK8XZ62hEieqGczQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:date:from :in-reply-to:message-id:mime-version:references:subject:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; bh=UrKdYwGrVaGOulNLHfnJ/mvHVJitFlGANq1iGrvBrjE=; b=c5alaxzo iczre2y+vxpZZZULezogkJpg8LWvRSy+w+PuEYDKu1UyB4qLg1vh/si44aNrYHdq sHmaN851ilsrxCBe1wv8MwociwrOk54R8t4X8N4JBYamlrUE9sq2lp+IKb32gthI 1uTJESReqDJgowye9uaGstwsjTgDGmWHerNjH5is43Z1p2SeE19KsDWcX000zn6U g2XYW3GrHYE7KZOGkTG83nu+8VtgkXJhvuT/UNe2B+iMfSl0+oSplFaG74qeW7is UI0tfdzU11fwIQiusehlVnbUgGBLoQQhOFnSru9AdmTbGjPaBEdd+iUj0KNr9W1X ucCDXgnGuNxK9Q== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudduiedgfedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkffojghfggfgsedtkeertdertddtnecuhfhrohhmpefmlhgruhhs ucflvghnshgvnhcuoehithhssehirhhrvghlvghvrghnthdrughkqeenucggtffrrghtth gvrhhnpeeuleetgeeiuefhgfekfefgveejiefgteekiedtgfdtieefhfdthfefueffvefg keenucfkphepkedtrdduieejrdelkedrudeltdenucevlhhushhtvghrufhiiigvpedtne curfgrrhgrmhepmhgrihhlfhhrohhmpehithhssehirhhrvghlvghvrghnthdrughk X-ME-Proxy: From: Klaus Jensen To: qemu-devel@nongnu.org, Peter Maydell Subject: [PULL v2 13/38] hw/block/nvme: add missing mor/mar constraint checks Date: Tue, 9 Mar 2021 12:44:47 +0100 Message-Id: <20210309114512.536489-14-its@irrelevant.dk> X-Mailer: git-send-email 2.30.1 In-Reply-To: <20210309114512.536489-1-its@irrelevant.dk> References: <20210309114512.536489-1-its@irrelevant.dk> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=64.147.123.26; envelope-from=its@irrelevant.dk; helo=wnew1-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fam Zheng , Kevin Wolf , qemu-block@nongnu.org, Dmitry Fomichev , Klaus Jensen , Gollu Appalanaidu , Max Reitz , Keith Busch , Stefan Hajnoczi , Klaus Jensen Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" From: Klaus Jensen Firstly, if zoned.max_active is non-zero, zoned.max_open must be less than or equal to zoned.max_active. Secondly, if only zones.max_active is set, we have to explicitly set zones.max_open or we end up with an invalid MAR/MOR configuration. This is an artifact of the parameters not being zeroes-based like in the spec. Cc: Dmitry Fomichev Reported-by: Gollu Appalanaidu Signed-off-by: Klaus Jensen Reviewed-by: Dmitry Fomichev --- hw/block/nvme-ns.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/hw/block/nvme-ns.c b/hw/block/nvme-ns.c index fd73d0321109..0e8760020483 100644 --- a/hw/block/nvme-ns.c +++ b/hw/block/nvme-ns.c @@ -163,6 +163,18 @@ static int nvme_ns_zoned_check_calc_geometry(NvmeNames= pace *ns, Error **errp) return -1; } =20 + if (ns->params.max_active_zones) { + if (ns->params.max_open_zones > ns->params.max_active_zones) { + error_setg(errp, "max_open_zones (%u) exceeds max_active_zones= (%u)", + ns->params.max_open_zones, ns->params.max_active_zo= nes); + return -1; + } + + if (!ns->params.max_open_zones) { + ns->params.max_open_zones =3D ns->params.max_active_zones; + } + } + if (ns->params.zd_extension_size) { if (ns->params.zd_extension_size & 0x3f) { error_setg(errp, --=20 2.30.1