From nobody Mon Feb 9 08:10:13 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1615291741; cv=none; d=zohomail.com; s=zohoarc; b=HBRyS1iGD5E2cPm2UKpmngswsy5ZDp131Lla/5hkw5vvJ7glKy0N1rCqAZV2cqkfR3b9yAk4DKzXvmgZsBV8wogSrj2b+umTfg0JIVkcbvJbS+xhsL5OpoqhXhYnHNakdWQJe1fszr+f+HQBa8qzC/yM77QumbL1QS7xOhLqgaM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1615291741; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=RBzvJrr8fa3LFkTLuZP2K9V1LWoxzVtfWByZdu/YYZM=; b=kLxsO0RJyfeXHZUA8LepTyjNe1+KctGPxobl/3SVfR0vmjsNLRAK7UAzcHHFdmf1val0HNdpC79BGzNocaSMjPaISh6Go4u7nJQpDudTXPsjGV0WGnU45wImcud6iKSw0zSORpt1wpQ/KX1E25mYkpB6LryuQlOOOxSt3H/kqhM= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 161529174122561.07509926202772; Tue, 9 Mar 2021 04:09:01 -0800 (PST) Received: from localhost ([::1]:60554 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lJbAa-0006Yf-2v for importer@patchew.org; Tue, 09 Mar 2021 07:09:00 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:42922) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lJanz-0008OZ-E0; Tue, 09 Mar 2021 06:45:39 -0500 Received: from wnew1-smtp.messagingengine.com ([64.147.123.26]:52073) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lJanx-0000Jd-G8; Tue, 09 Mar 2021 06:45:39 -0500 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailnew.west.internal (Postfix) with ESMTP id 35FE12711; Tue, 9 Mar 2021 06:45:35 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Tue, 09 Mar 2021 06:45:35 -0500 Received: from apples.local (80-167-98-190-cable.dk.customer.tdc.net [80.167.98.190]) by mail.messagingengine.com (Postfix) with ESMTPA id 3FD24240054; Tue, 9 Mar 2021 06:45:33 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=irrelevant.dk; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; s=fm2; bh=RBzvJrr8fa3LF kTLuZP2K9V1LWoxzVtfWByZdu/YYZM=; b=LsghLgyGhawImL/IaxaITmxL+zdOz Pmfu210SO7dVHOiMsavCLCZEKuswm1RDi6+AiLa5PPNtjS/lDoc4wCZaG2agWf/+ /1BiNb1BsVeOMizdyX9eA1XHH4hc/Cd9dGmTakvBjSmxKs5Sb/PMtIiPZ4Pv/+4c 70a8hg2LnXAsB/zFxpwAUi68fXWOZMbt81+mIZWGPW13USoWpzBEwTYktm3xpqTe Wp1lZ7nvO4JWShdk7I9RMsQ7/BsJUX1rkPUTe6pUpUaUgnga3yYtVvaoJcnTCB1Q mtVGOXIfLoOhlW+mfK72Y6ztMLAndEAjTaMIs559WtmVmM+oaGqP9lt4g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:date:from :in-reply-to:message-id:mime-version:references:subject:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; bh=RBzvJrr8fa3LFkTLuZP2K9V1LWoxzVtfWByZdu/YYZM=; b=NtDsBJho Zrr3RZAloyVEah0F6/VSNFHB9GLNmJXElud2XrHMoHdtagLnUhN9BqW1Q5jzaVbS qEcH2zuns3JeB5NMt2lgJYF84nFnjGIiZVTO1SO2vNaMSymA46eL6R6mb3I2cbhm aJcQkv/pXTV1++WWf3o7eTEP1hVtyAkPIGqHZAwb8n9+BROYl4VWJ9h5ku/tx4Wj n8pWC98Gd+h9j0zyG5TvjwWGWseavQdrTTifuxp4fhAtbgPQ4plCArEEsrqz66en rfd4iekcQrk0ZTVdcb+PQGKd4bZCP0acvmOpKfW/8H5oRY61EW1K04fGVc1kzcm4 bJVuDotHMeQHeg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudduiedgfeduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkffojghfggfgsedtkeertdertddtnecuhfhrohhmpefmlhgruhhs ucflvghnshgvnhcuoehithhssehirhhrvghlvghvrghnthdrughkqeenucggtffrrghtth gvrhhnpeeuleetgeeiuefhgfekfefgveejiefgteekiedtgfdtieefhfdthfefueffvefg keenucfkphepkedtrdduieejrdelkedrudeltdenucevlhhushhtvghrufhiiigvpeelne curfgrrhgrmhepmhgrihhlfhhrohhmpehithhssehirhhrvghlvghvrghnthdrughk X-ME-Proxy: From: Klaus Jensen To: qemu-devel@nongnu.org, Peter Maydell Subject: [PULL v2 12/38] hw/block/nvme: fix Close Zone Date: Tue, 9 Mar 2021 12:44:46 +0100 Message-Id: <20210309114512.536489-13-its@irrelevant.dk> X-Mailer: git-send-email 2.30.1 In-Reply-To: <20210309114512.536489-1-its@irrelevant.dk> References: <20210309114512.536489-1-its@irrelevant.dk> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=64.147.123.26; envelope-from=its@irrelevant.dk; helo=wnew1-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fam Zheng , Kevin Wolf , qemu-block@nongnu.org, Dmitry Fomichev , Klaus Jensen , Max Reitz , Keith Busch , Stefan Hajnoczi , Klaus Jensen Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" From: Dmitry Fomichev Implicitly and Explicitly Open zones can be closed by Close Zone management function. This got broken by a recent commit ("hw/block/nvme: refactor zone resource management") and now such commands fail with Invalid Zone State Transition status. Modify nvm_zrm_close() function to make Close Zone work correctly. Signed-off-by: Dmitry Fomichev Signed-off-by: Klaus Jensen --- hw/block/nvme.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/hw/block/nvme.c b/hw/block/nvme.c index ab4723ff319a..56ef07b74d27 100644 --- a/hw/block/nvme.c +++ b/hw/block/nvme.c @@ -1319,14 +1319,13 @@ static uint16_t nvme_zrm_finish(NvmeNamespace *ns, = NvmeZone *zone) static uint16_t nvme_zrm_close(NvmeNamespace *ns, NvmeZone *zone) { switch (nvme_get_zone_state(zone)) { - case NVME_ZONE_STATE_CLOSED: - return NVME_SUCCESS; - case NVME_ZONE_STATE_EXPLICITLY_OPEN: case NVME_ZONE_STATE_IMPLICITLY_OPEN: nvme_aor_dec_open(ns); nvme_assign_zone_state(ns, zone, NVME_ZONE_STATE_CLOSED); /* fall through */ + case NVME_ZONE_STATE_CLOSED: + return NVME_SUCCESS; =20 default: return NVME_ZONE_INVAL_TRANSITION; --=20 2.30.1