From nobody Wed Nov 19 07:04:21 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1615220079; cv=none; d=zohomail.com; s=zohoarc; b=D33OTngv8zOd2sVK1bb+ERe4ff87H4gBK07EkE3hgIhRCf9GghgKIjiUz4tCtG3Nb/mCbjTbGPqA8+SQHUORyr0VxblNjuMLfRafh9Qw46e+uWRZBUBMRhe4h9QDFYIlU3WbjdbfdrbOQWYhM7wO0OeKOEWsEhvzUC1TShX29gc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1615220079; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=4BaDcwju7vvjsG0y3ccjjg0NVrHt5+WVLrhxPznI14w=; b=A7jqfsPt8wkkokn28SU1wfV/XbMH8phCPk/8dbPmdxFRAmlR2058kokXT3bjMMbj89aJFy8JYmLhRfbReYt9p/G9CMoRibKLDPhcj3g/EtmE/gc5pF321QgDbzScfGUTZJRMy36MH4BNXFoeBFowx1rVhM6l63wot2UHFYiGWAI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1615220079723500.6549550639794; Mon, 8 Mar 2021 08:14:39 -0800 (PST) Received: from localhost ([::1]:49582 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lJIWj-0001LS-0n for importer@patchew.org; Mon, 08 Mar 2021 11:14:37 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:34854) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lJIUs-0000HO-02 for qemu-devel@nongnu.org; Mon, 08 Mar 2021 11:12:45 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:32211) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1lJIUo-000603-UZ for qemu-devel@nongnu.org; Mon, 08 Mar 2021 11:12:41 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-268-kryTr8rTMJyZCtoTAw8NBQ-1; Mon, 08 Mar 2021 11:12:35 -0500 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 694168018B3; Mon, 8 Mar 2021 16:12:34 +0000 (UTC) Received: from steredhat.redhat.com (ovpn-112-117.ams2.redhat.com [10.36.112.117]) by smtp.corp.redhat.com (Postfix) with ESMTP id 503261007625; Mon, 8 Mar 2021 16:12:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1615219957; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=4BaDcwju7vvjsG0y3ccjjg0NVrHt5+WVLrhxPznI14w=; b=Mb37Rj1eqrY/mbxK8v1JvGSqtNqHEVVkWiee+bWpajarJueIP9kEWyd9FqcKOhbz1RSpBE gzCGjPsqZuc7Ddy7UPE6Rkr/AcRfa5ngZIweJLdyu02DRywvq1zxPoz1Yjq6KlLNjVk8S7 YiZJCCUM8ff6YwOP+YPq7M7TM4ib5As= X-MC-Unique: kryTr8rTMJyZCtoTAw8NBQ-1 From: Stefano Garzarella To: qemu-devel@nongnu.org Subject: [PATCH] block: remove format defaults from QemuOpts in bdrv_create_file() Date: Mon, 8 Mar 2021 17:12:32 +0100 Message-Id: <20210308161232.248833-1-sgarzare@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=sgarzare@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=63.128.21.124; envelope-from=sgarzare@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -29 X-Spam_score: -3.0 X-Spam_bar: --- X-Spam_report: (-3.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.251, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , qemu-block@nongnu.org, Max Reitz Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" QemuOpts is usually created merging the QemuOptsList of format and protocol. So, when the format calls bdr_create_file(), the 'opts' parameter contains a QemuOptsList with a combination of format and protocol default values. The format properly removes its options before calling bdr_create_file(), but the default values remain in 'opts->list'. So if the protocol has options with the same name (e.g. rbd has 'cluster_size' as qcow2), it will see the default values of the format, since for overlapping options, the format wins. To avoid this issue, lets convert QemuOpts to QDict, in this way we take only the set options, and then convert it back to QemuOpts, using the 'create_opts' of the protocol. So the new QemuOpts, will contain only the protocol defaults. Suggested-by: Kevin Wolf Signed-off-by: Stefano Garzarella --- block.c | 36 +++++++++++++++++++++++++++++++++++- 1 file changed, 35 insertions(+), 1 deletion(-) diff --git a/block.c b/block.c index a1f3cecd75..be7083c7d8 100644 --- a/block.c +++ b/block.c @@ -670,14 +670,48 @@ out: =20 int bdrv_create_file(const char *filename, QemuOpts *opts, Error **errp) { + QemuOpts *protocol_opts; BlockDriver *drv; + QDict *qdict; + int ret; =20 drv =3D bdrv_find_protocol(filename, true, errp); if (drv =3D=3D NULL) { return -ENOENT; } =20 - return bdrv_create(drv, filename, opts, errp); + if (!drv->create_opts) { + error_setg(errp, "Driver '%s' does not support image creation", + drv->format_name); + return -ENOTSUP; + } + + /* + * 'opts' contains a QemuOptsList with a combination of format and pro= tocol + * default values. + * + * The format properly removes its options, but the default values rem= ain + * in 'opts->list'. So if the protocol has options with the same name + * (e.g. rbd has 'cluster_size' as qcow2), it will see the default val= ues + * of the format, since for overlapping options, the format wins. + * + * To avoid this issue, lets convert QemuOpts to QDict, in this way we= take + * only the set options, and then convert it back to QemuOpts, using t= he + * create_opts of the protocol. So the new QemuOpts, will contain only= the + * protocol defaults. + */ + qdict =3D qemu_opts_to_qdict(opts, NULL); + protocol_opts =3D qemu_opts_from_qdict(drv->create_opts, qdict, errp); + if (protocol_opts =3D=3D NULL) { + ret =3D -EINVAL; + goto out; + } + + ret =3D bdrv_create(drv, filename, protocol_opts, errp); +out: + qemu_opts_del(protocol_opts); + qobject_unref(qdict); + return ret; } =20 int coroutine_fn bdrv_co_delete_file(BlockDriverState *bs, Error **errp) --=20 2.29.2