From nobody Mon Feb 9 09:29:43 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1615208984; cv=none; d=zohomail.com; s=zohoarc; b=nuGwdbKm6nk1Ed9f0de5vlia5ckkuCo1nmIWkQ4j/5iJONREj5eomZoWK6yxHxy1w6+8GTjRaDDMPwVTRx3uEaHXuQK2qDOXrg3mWBFOxb4Z1xAuOKLw9h9Kb77MMeH8IQcmWQAt1Ql+TmGw1793HgmXIGH2w1CbVAM6BnYhWg8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1615208984; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=49i/GpGXgZkKE/lrgDn4OIQuxN3Fi8uTjQx7h58jORs=; b=GOstcZBHnYlm3KEk5xkslKMQ8ahTo7Lc0S3s4is/CsCUFdMrU3Z+mXuCxt4WvMJAKztsPIMIvth7u2jnccFqkC2vCynSlsRDO12GeReNJO67VPiJaH8Z1iOpnQmaEAwC3bBuZRslAR5eM7/xjHfZ4jP0oJo65GCGfJsJkT4iNhU= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1615208984447512.3870484058438; Mon, 8 Mar 2021 05:09:44 -0800 (PST) Received: from localhost ([::1]:45892 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lJFdn-0005Sl-BR for importer@patchew.org; Mon, 08 Mar 2021 08:09:43 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:36494) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lJEwF-0003sp-LU; Mon, 08 Mar 2021 07:24:43 -0500 Received: from wnew4-smtp.messagingengine.com ([64.147.123.18]:52331) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lJEwE-0007Eb-2O; Mon, 08 Mar 2021 07:24:43 -0500 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailnew.west.internal (Postfix) with ESMTP id D68DEFA8; Mon, 8 Mar 2021 07:24:06 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Mon, 08 Mar 2021 07:24:07 -0500 Received: from apples.local (80-167-98-190-cable.dk.customer.tdc.net [80.167.98.190]) by mail.messagingengine.com (Postfix) with ESMTPA id 076851080068; Mon, 8 Mar 2021 07:24:04 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=irrelevant.dk; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; s=fm2; bh=49i/GpGXgZkKE /lrgDn4OIQuxN3Fi8uTjQx7h58jORs=; b=QeV+tYShtGvyWiGt7R9ZVamxzJH0M 4/RqYHBU4JKTQRRPXW+kygnJ3Xfgs2GUfBDdMM7Q9/0jT21IuRzLzZkBm2XOqSHh 7x6IZw6YKF2Df6kLkKbJ1bbYTKedObYOiBZ37OjqhdJZqiZTFKWdse/y0a4tKeHD pAJ9fucT8XFX1Nc9QorNtpBPJ5+z50gG6pl9zPvEB+AugEm0dzIi15u0ZCpPSiJD qKiF4LDxHJU8OBoThmXdPRYn464zBOXO9Ya66ITpoHfyMC4DtUyBqry/3NfkkD98 lHNBDfKh3ozckcuseneBnwvaZqYFH7RzBGq79uRHmuqK5PYiCKIPkkjGg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:date:from :in-reply-to:message-id:mime-version:references:subject:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; bh=49i/GpGXgZkKE/lrgDn4OIQuxN3Fi8uTjQx7h58jORs=; b=EvS84m+H wF3VTew0Ye2m8SrrLoVmYK9Uw0cBKMU1XlqEMMPXEcwCl1gDobjO8Zzw8iPCLsAI VCIGw5TnR9Q67lKTRf6fiAnfWc/jMZlHFJ02Ckel6nvDKsLjvoIyTZJ4akdm6FSO YH3XxWYi06Uje87cXL/xmopUGxUT5sPXRfn22EMnPyF5XWWPifnAhbET2f29Psye czThlqDS//V7cQW52MCPSgcPkFSXY7g2DmzHAh0qPznkopkVwI7GNgJRtJEO5m1o EaH2XA0wjAWExk37oN7wZNke4dpV7aHZvr0+TX8Uco/SapwWsQStIiyXdUOnj7R5 Ch3uN/HYK6ckjw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudduvddgfedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkffojghfggfgsedtkeertdertddtnecuhfhrohhmpefmlhgruhhs ucflvghnshgvnhcuoehithhssehirhhrvghlvghvrghnthdrughkqeenucggtffrrghtth gvrhhnpeeuleetgeeiuefhgfekfefgveejiefgteekiedtgfdtieefhfdthfefueffvefg keenucfkphepkedtrdduieejrdelkedrudeltdenucevlhhushhtvghrufhiiigvpedvje enucfrrghrrghmpehmrghilhhfrhhomhepihhtshesihhrrhgvlhgvvhgrnhhtrdgukh X-ME-Proxy: From: Klaus Jensen To: Peter Maydell , qemu-devel@nongnu.org Subject: [PULL 32/38] hw/block/nvme: fix namespaces array to 1-based Date: Mon, 8 Mar 2021 13:23:07 +0100 Message-Id: <20210308122313.286938-33-its@irrelevant.dk> X-Mailer: git-send-email 2.30.1 In-Reply-To: <20210308122313.286938-1-its@irrelevant.dk> References: <20210308122313.286938-1-its@irrelevant.dk> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=64.147.123.18; envelope-from=its@irrelevant.dk; helo=wnew4-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fam Zheng , Kevin Wolf , qemu-block@nongnu.org, Klaus Jensen , Max Reitz , Keith Busch , Minwoo Im , Stefan Hajnoczi , Klaus Jensen Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" From: Minwoo Im subsys->namespaces array used to be sized to NVME_SUBSYS_MAX_NAMESPACES. But subsys->namespaces are being accessed with 1-based namespace id which means the very first array entry will always be empty(NULL). Signed-off-by: Minwoo Im Reviewed-by: Keith Busch Reviewed-by: Klaus Jensen Tested-by: Klaus Jensen Signed-off-by: Klaus Jensen --- hw/block/nvme-subsys.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/block/nvme-subsys.h b/hw/block/nvme-subsys.h index 890d118117dc..574774390c4c 100644 --- a/hw/block/nvme-subsys.h +++ b/hw/block/nvme-subsys.h @@ -24,7 +24,7 @@ typedef struct NvmeSubsystem { =20 NvmeCtrl *ctrls[NVME_SUBSYS_MAX_CTRLS]; /* Allocated namespaces for this subsystem */ - NvmeNamespace *namespaces[NVME_SUBSYS_MAX_NAMESPACES]; + NvmeNamespace *namespaces[NVME_SUBSYS_MAX_NAMESPACES + 1]; } NvmeSubsystem; =20 int nvme_subsys_register_ctrl(NvmeCtrl *n, Error **errp); --=20 2.30.1