From nobody Mon Feb 9 21:04:22 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1615119323; cv=none; d=zohomail.com; s=zohoarc; b=SXKd7rI7SAaP+xAqEcr/Gn0I6Il4p0arv8toC/EiubptMTwpUpGIdEfiaXZtt0P+5yH+7LQJuYX4HAggR6xUr3tdxvDpAT2r+KorvV8utEM+OWfp4cRU3Vhn2i4Atl52rPV3252DGF5xNyqMcdIhU6X3AuhDATb0W8Pq2ckOODw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1615119323; h=Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=hE/MsAP67cn2K+uHLHXnOIVhs8yA2OLV6sZBahk20Bo=; b=XmxOooQc5D9mRjNs3R2jiQ8yQtzIanETfUI7fJOTFppAwUB8o0MTb1C4mF8xF2GBofsWmMwXj30QletqSYDihDXSmzDIUnZL9GrgJeKpqQMJ3dPYcENeftOpaPgblOqSAZU378rDRUD0x6dA/T5t4LRdIJ+pLvaM94kKhEpyQ9k= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1615119323765670.0356565540989; Sun, 7 Mar 2021 04:15:23 -0800 (PST) Received: from localhost ([::1]:49434 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lIsJe-000674-M6 for importer@patchew.org; Sun, 07 Mar 2021 07:15:22 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:41444) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lIsEa-0000sd-8y for qemu-devel@nongnu.org; Sun, 07 Mar 2021 07:10:08 -0500 Received: from mail.ilande.co.uk ([2001:41c9:1:41f::167]:43616 helo=mail.default.ilande.uk0.bigv.io) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lIsEY-0007fo-PB for qemu-devel@nongnu.org; Sun, 07 Mar 2021 07:10:08 -0500 Received: from host86-148-34-47.range86-148.btcentralplus.com ([86.148.34.47] helo=kentang.home) by mail.default.ilande.uk0.bigv.io with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lIsES-0002V5-MD; Sun, 07 Mar 2021 12:10:05 +0000 From: Mark Cave-Ayland To: qemu-devel@nongnu.org, peter.maydell@linaro.org Date: Sun, 7 Mar 2021 12:08:19 +0000 Message-Id: <20210307120850.10418-12-mark.cave-ayland@ilande.co.uk> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210307120850.10418-1-mark.cave-ayland@ilande.co.uk> References: <20210307120850.10418-1-mark.cave-ayland@ilande.co.uk> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 86.148.34.47 X-SA-Exim-Mail-From: mark.cave-ayland@ilande.co.uk Subject: [PULL 11/42] esp: apply transfer length adjustment when STC is zero at TC load time X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on mail.default.ilande.uk0.bigv.io) Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2001:41c9:1:41f::167; envelope-from=mark.cave-ayland@ilande.co.uk; helo=mail.default.ilande.uk0.bigv.io X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" Perform the length adjustment whereby a value of 0 in the STC represents a transfer length of 0x10000 at the point where the TC is loaded at the start of a DMA command rather than just when a TI (Transfer Information) command is executed. This better matches the description as given in the datasheet. Signed-off-by: Mark Cave-Ayland Reviewed-by: Laurent Vivier Message-Id: <20210304221103.6369-12-mark.cave-ayland@ilande.co.uk> --- hw/scsi/esp.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/hw/scsi/esp.c b/hw/scsi/esp.c index 125bdea32a..349067eb6a 100644 --- a/hw/scsi/esp.c +++ b/hw/scsi/esp.c @@ -561,9 +561,6 @@ static void handle_ti(ESPState *s) } =20 dmalen =3D esp_get_tc(s); - if (dmalen =3D=3D 0) { - dmalen =3D 0x10000; - } s->dma_counter =3D dmalen; =20 if (s->do_cmd) { @@ -698,7 +695,11 @@ void esp_reg_write(ESPState *s, uint32_t saddr, uint64= _t val) if (val & CMD_DMA) { s->dma =3D 1; /* Reload DMA counter. */ - esp_set_tc(s, esp_get_stc(s)); + if (esp_get_stc(s) =3D=3D 0) { + esp_set_tc(s, 0x10000); + } else { + esp_set_tc(s, esp_get_stc(s)); + } } else { s->dma =3D 0; } --=20 2.20.1