From nobody Tue Feb 10 09:57:50 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1615028610; cv=none; d=zohomail.com; s=zohoarc; b=Rd7//iGhoZSL4HeF/hyVRh1CLjRztBPkJyu2SD8AfYqzM3QaTb6DVq+xesdlz33Zne9vqvztE9yPC/65Jgv7rZCmu+BevKVtYxb+In+9XEcWiPSI5D+LbMay3LQ3y08UO2RjYAKBIwz26qSEqVI/5zcyMv7gjvi1PWcwaWxEVCk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1615028610; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=y+3key+Awrub2yF4Xg5MLCJZCTP/he2QEe7XSC9SAec=; b=llRvAbYNIEQp7bqgzq6YD3eocacmAOXzuhrFCOOmmj/HM6rHcJUVNoL9T6aZg5b6l6RODsellamZ9E4mqRWiYRSpgFD53OQzLHINwa1aS9f/+Wi+ZM9Bo17Vict/Au16jsZni3ue7iZqkIJQN+6+uJx6uBNgJ6YvBYEv8kL4TgU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 16150286101891016.5221043568654; Sat, 6 Mar 2021 03:03:30 -0800 (PST) Received: from localhost ([::1]:37386 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lIUiX-0001oY-7G for importer@patchew.org; Sat, 06 Mar 2021 06:03:29 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:44560) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lIUa2-00062M-A4 for qemu-devel@nongnu.org; Sat, 06 Mar 2021 05:54:43 -0500 Received: from mail-wr1-x433.google.com ([2a00:1450:4864:20::433]:35571) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lIUa0-0008Ff-Gz for qemu-devel@nongnu.org; Sat, 06 Mar 2021 05:54:42 -0500 Received: by mail-wr1-x433.google.com with SMTP id l12so5216470wry.2 for ; Sat, 06 Mar 2021 02:54:40 -0800 (PST) Received: from avogadro.redhat.com ([93.56.170.5]) by smtp.gmail.com with ESMTPSA id i26sm9326472wmb.18.2021.03.06.02.54.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 06 Mar 2021 02:54:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=y+3key+Awrub2yF4Xg5MLCJZCTP/he2QEe7XSC9SAec=; b=gDKF9Qy9GQ+NAIPcL85l9M9v9msS13fe8aFpY/9CeeVsFlwH7bwxCAb8Dvi3PiGDB3 NDCQ8R43JW9eW6QIx8bBIyH+sAxNt5NIi/yaoB7PGyqeyMCQEMb2smSaUfixFKWAIz5s i9CFYHknie547Jp9RXwhPqmtJStU2LSGk+i9+4hxu84bbW4jm/g0jSz7p1IHgquPG3Wr 31zIB3RfqatH+az+3l9gTxNtEQDZ+oMs4Rh1KSpKII9hIE5MKNZfMZV1kh7VeCIMRMxR MffG/LLBtTpREbyxzz0Ug6doq6XSwRr7pdufr4tq+1N6Ac3hvMzUer4jMs9f4ft9meZ6 J6HQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=y+3key+Awrub2yF4Xg5MLCJZCTP/he2QEe7XSC9SAec=; b=T6f98MyVj3v7yj3eOK209QQuJpoA9o1QMPsa/my7uf6TmtPww3H+7UobbFv+OLZi/b qjEsQRtSfumD5mUE7KlAZn/LjNxNtm40Fyxot2AHpZ/n2tXb9xzir7owH6niq9+wsxxv fWoF74v0cHvZL9BDfX2Tmnb+rE3+VvHHbeYVDelsSBqxHNb3UivypYRCUBZLV0xAd/vd WnX4wvNaM0PM4UTNequFTYag9YLg9AZq5vZrEFMzaYLUtU0icr3rtxzg5kJzGvGOL81/ Elk2nybuev6OSuLqOQua3NMPMqzc9tjbUVKs3aBTzJY/h5A+WXpy1Cta6T+MJSNMMyzq GFWA== X-Gm-Message-State: AOAM5314qpcFd8Ka3uxSY/HMjeZ07jkMZUOHJkxYWjb+6bmqE90SEkLv q6HAGtJA+LciSCcqOHIkJTO1PaC4W6M= X-Google-Smtp-Source: ABdhPJxuH6ziU0vXUwOrJNFXcaoib1aRxtlPvjuA0j1LlQFJ0TmgNEXN/P7UcYg00cvdjhwA57kv5g== X-Received: by 2002:a5d:4b06:: with SMTP id v6mr3146739wrq.41.1615028079321; Sat, 06 Mar 2021 02:54:39 -0800 (PST) From: Paolo Bonzini To: qemu-devel@nongnu.org Subject: [PULL 22/23] trace: skip qemu_set_log_filename if no "-D" option was passed Date: Sat, 6 Mar 2021 11:54:18 +0100 Message-Id: <20210306105419.110503-23-pbonzini@redhat.com> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20210306105419.110503-1-pbonzini@redhat.com> References: <20210306105419.110503-1-pbonzini@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::433; envelope-from=paolo.bonzini@gmail.com; helo=mail-wr1-x433.google.com X-Spam_score_int: -14 X-Spam_score: -1.5 X-Spam_bar: - X-Spam_report: (-1.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.25, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: stefanha@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" When the "simple" backend is not active but the "log" backend is, both "-trace file=3D" and "-D" will result in a call to qemu_set_log_filename. Unfortunately, QEMU was also calling qemu_set_log_filename if "-D" was not passed, so the "-trace file=3D" option had no effect and the tracepoints went back to stderr. Fortunately we can just skip qemu_set_log_filename in that case, because the log backend will initialize itself just fine as soon as qemu_set_log is called, also in qemu_process_early_options. Cc: stefanha@redhat.com Signed-off-by: Paolo Bonzini Message-Id: <20210209145759.141231-3-pbonzini@redhat.com> --- softmmu/vl.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/softmmu/vl.c b/softmmu/vl.c index 2f4958db2a..ff488ea3e7 100644 --- a/softmmu/vl.c +++ b/softmmu/vl.c @@ -2364,7 +2364,9 @@ static void qemu_process_early_options(void) #endif =20 /* Open the logfile at this point and set the log mask if necessary. = */ - qemu_set_log_filename(log_file, &error_fatal); + if (log_file) { + qemu_set_log_filename(log_file, &error_fatal); + } if (log_mask) { int mask; mask =3D qemu_str_to_log_mask(log_mask); --=20 2.29.2