From nobody Tue Feb 10 14:32:00 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.51 as permitted sender) client-ip=209.85.221.51; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f51.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.51 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1614988463; cv=none; d=zohomail.com; s=zohoarc; b=JLJkv8IIbwTRg0ZOnoUkW4hSAFyJjUjLGohYnjpqGS7fAiVMFR4kCv8nkDKW3Lt6c9Abs8rd9/BydF+2WR+yWQlUw8RhHp5A0jmVyq8z+pWqVeDA0km+LhgvD2OzfVdP3wNV4agEY6UrffM/kpLdok1U+bAckNY96agcqNNu72o= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1614988463; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=2yJZvfO9sIo/QVUNGf9LQHlm++XZyAwu6lIoAPys+a8=; b=VvS50eVPewnSDLEyV/11sf9EQWP6aT+oIZfTDXZfcC8Q6eH6OCDsC42ujWB/KNjlScslPBcN77MXhkidAFU4JlXNFYCvUWZgnN8dgsGQgjWbiASe+IoFu1IzA8aoyMckhu1O/QzL3HaQ0RDexmGkaKvbK+2rdEbmRpKgqfoI7zA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.51 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) by mx.zohomail.com with SMTPS id 1614988463201747.3789200140538; Fri, 5 Mar 2021 15:54:23 -0800 (PST) Received: by mail-wr1-f51.google.com with SMTP id 7so3953709wrz.0 for ; Fri, 05 Mar 2021 15:54:22 -0800 (PST) Return-Path: Return-Path: Received: from localhost.localdomain (68.red-83-57-175.dynamicip.rima-tde.net. [83.57.175.68]) by smtp.gmail.com with ESMTPSA id f7sm4213490wmq.11.2021.03.05.15.54.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Mar 2021 15:54:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=2yJZvfO9sIo/QVUNGf9LQHlm++XZyAwu6lIoAPys+a8=; b=c7JTH2M0QrgF1ryBnhZU1bGyWEgtPFb2Wtjc3j4QrehofcbNpv//vK2VZHo0mSH77x 4CfNuI/scI0fSwOszQ6Ix38FlFBswcBnOtz3ORd1y37duCRlHwgLx2uAjjJUIbt+idDP IYtGJxxj8XZeHpDzmKjKARfBoa0NKDaNPZfrUr5djr2Oob0bJ6PcefhIk9cUilVT4dKh ErWKtYDgkv33HuXaiwtUem9wyDUelkKND+U7gvLtTG1oviMD2Xx9YJXqLPWathv+S/az XCt5mh/KTfbiEDcAFU+onCpNp6wFH+S4OIfIpYvHA6eFHWOSf7de/NZgYqndCTsxGoHK vC2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=2yJZvfO9sIo/QVUNGf9LQHlm++XZyAwu6lIoAPys+a8=; b=JFA7mb1v5KpzJqQlASlyUtTQLV8VW6/BBzWduErTTbXu9fE2DUWQucIH800nHkQIaA LygLV+r5NKSUFEUXHG3tlp1/lhT+qYA0cD0JrIDQx36zgIaFLz0P2KCvJNIZCHqR0ajH UAZpAjpK76+gJhzbMTCWhmzsYiX3eyz6oE2c/Y1sXQ2oNJecvpWOsjPswTtFhkZl0CnP VshVEwS52O90oRI3QJP2ZChmOJHiR6WbcjrH0qyPNPElthCnYmbon0fLG8FPnXARf6Oc D/2kE5tpOGO9NgYblpPG18x15nERExlwRrM4ZhTDvOn0ULanaAlLVWrBYpSbrDLtmK7Q SStw== X-Gm-Message-State: AOAM532H82xco5rZZZZhPPsQe6sIWW8v8gYBuVtWT45UQGt3aC/q/aDd j1m8YSUO82mqDjYXRQ2Fhp0= X-Google-Smtp-Source: ABdhPJwf3mfNiMWi1Foi5fJPVGyL6v24fJPprwDvfmTyKXZV481NaShjzeyYL5GQpRizIna2UlHGbw== X-Received: by 2002:adf:e482:: with SMTP id i2mr11695759wrm.392.1614988461560; Fri, 05 Mar 2021 15:54:21 -0800 (PST) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Paolo Bonzini , Peter Xu , Alexander Bulekov , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH 1/3] memory: Better name 'offset' argument in mtree_print_mr() Date: Sat, 6 Mar 2021 00:54:12 +0100 Message-Id: <20210305235414.2358144-2-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210305235414.2358144-1-f4bug@amsat.org> References: <20210305235414.2358144-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) The 'base' argument of mtree_print_mr() actually represents an offset, not a base address. Rename it as such. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- softmmu/memory.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/softmmu/memory.c b/softmmu/memory.c index 874a8fccdee..e4d93b2fd6f 100644 --- a/softmmu/memory.c +++ b/softmmu/memory.c @@ -2925,7 +2925,7 @@ static void mtree_print_mr_owner(const MemoryRegion *= mr) } =20 static void mtree_print_mr(const MemoryRegion *mr, unsigned int level, - hwaddr base, + hwaddr offset, MemoryRegionListHead *alias_print_queue, bool owner, bool display_disabled) { @@ -2939,7 +2939,7 @@ static void mtree_print_mr(const MemoryRegion *mr, un= signed int level, return; } =20 - cur_start =3D base + mr->addr; + cur_start =3D offset + mr->addr; cur_end =3D cur_start + MR_SIZE(mr->size); =20 /* @@ -2947,7 +2947,7 @@ static void mtree_print_mr(const MemoryRegion *mr, un= signed int level, * happen normally. When it happens, we dump something to warn the * user who is observing this. */ - if (cur_start < base || cur_end < cur_start) { + if (cur_start < offset || cur_end < cur_start) { qemu_printf("[DETECTED OVERFLOW!] "); } =20 --=20 2.26.2