From nobody Tue May 6 12:46:43 2025
Delivered-To: importer@patchew.org
Authentication-Results: mx.zohomail.com;
dkim=pass;
spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as
permitted sender)
smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org;
dmarc=pass(p=none dis=none) header.from=linaro.org
ARC-Seal: i=1; a=rsa-sha256; t=1614967565; cv=none;
d=zohomail.com; s=zohoarc;
b=AuFSqwOB82Vc/0Mj9kkJTGkuqv9Vg5l0P+TQ3wRvGccC2vt0MncgI3hXZpfHbYTtlNB/rl3/FnUlGydhnHKzDEJKjQW2gxdkKDRRE+KiI7hyAanZ6d4kBmSiszPKxj70AN1+z7QcBeB8LInjy3gkpsrSEKxLBWOLnElQ4CbhuWk=
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com;
s=zohoarc;
t=1614967565;
h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To;
bh=COi/9CAUq6+7DdssMpbU7FxBJPwnXWMtPeffciNh4Dk=;
b=B6k/B1mVMlS9tZyssXtcJYqjX5JqzRicTI3n5N/k9KhnQD0i9doq5pHVEjdU+QhXR+2VBO8AfGz/fgRjL9dsfNivr34Ulj4C6ysKX0rAQHe8MGxGFn27QLjhM+Y7ghIy/LtPPc7Dhx34sgXcHpH4wdWCTM825xIgOrQ+Y6UrU0Q=
ARC-Authentication-Results: i=1; mx.zohomail.com;
dkim=pass;
spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as
permitted sender)
smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org;
dmarc=pass header.from=<peter.maydell@linaro.org> (p=none dis=none)
header.from=<peter.maydell@linaro.org>
Return-Path: <qemu-devel-bounces+importer=patchew.org@nongnu.org>
Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by
mx.zohomail.com
with SMTPS id 1614967565145339.27748860674296;
Fri, 5 Mar 2021 10:06:05 -0800 (PST)
Received: from localhost ([::1]:43612 helo=lists1p.gnu.org)
by lists.gnu.org with esmtp (Exim 4.90_1)
(envelope-from <qemu-devel-bounces+importer=patchew.org@nongnu.org>)
id 1lIEpw-0001Tn-7H
for importer@patchew.org; Fri, 05 Mar 2021 13:06:04 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10]:38056)
by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <peter.maydell@linaro.org>)
id 1lIE34-0006fb-1Q
for qemu-devel@nongnu.org; Fri, 05 Mar 2021 12:15:34 -0500
Received: from mail-wm1-x330.google.com ([2a00:1450:4864:20::330]:52356)
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
(Exim 4.90_1) (envelope-from <peter.maydell@linaro.org>)
id 1lIE2y-0007UW-Q5
for qemu-devel@nongnu.org; Fri, 05 Mar 2021 12:15:33 -0500
Received: by mail-wm1-x330.google.com with SMTP id n22so2103954wmc.2
for <qemu-devel@nongnu.org>; Fri, 05 Mar 2021 09:15:27 -0800 (PST)
Received: from orth.archaic.org.uk (orth.archaic.org.uk. [81.2.115.148])
by smtp.gmail.com with ESMTPSA id m132sm5942357wmf.45.2021.03.05.09.15.25
for <qemu-devel@nongnu.org>
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Fri, 05 Mar 2021 09:15:25 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;
h=from:to:subject:date:message-id:in-reply-to:references:mime-version
:content-transfer-encoding;
bh=COi/9CAUq6+7DdssMpbU7FxBJPwnXWMtPeffciNh4Dk=;
b=QRa1t9eflhb6pVjjyk91nTMiCv2oEGtznJk+qcAX/oYBeiMp67tSo+nde86VLgtAf/
YjznsoJKNVBr2nPuB0KOxiOWN6XN8cqCZ5gx7+Bt6ofLUiQIKKRK9TF50sVxv47fnNqf
shxQMW2TGLFCMC7L9ENyl9r8Mn1Dvu6P8YnZjKb3DAbZCKypMR6Qrj+ni33piu9tRL/Z
4YnxM5jonHCaUfDhqRWnpiIi6/ZD+yCU8mCF0brOKLxkAnIDvLzsdmcN/a2IhCQiK4gQ
fwcvY6GOohVQEsbePEEfuldTQ2knBiLYPxuiUFcvvyZn+wTW0fH2gLnIEP/CF8omHGQD
1EPQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20161025;
h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to
:references:mime-version:content-transfer-encoding;
bh=COi/9CAUq6+7DdssMpbU7FxBJPwnXWMtPeffciNh4Dk=;
b=SuD5FwPeo1Kb+xnqQDH7eRNIS9SUPi7RHEievgRpzhrkUD3unZxHg4iR2+M057w01M
RV9M1ZhqHpTh1ni0LPpY5SyAvIs7pyf9i2dW6d52yv2xfQJlKHi+TVe/6sf89zkIpeNu
1vDxPS9+mGuQBzPVWMQHc75jjKLhtQC8O/hbmY2sl12z7DfQE8MSZjeM8XHjFyxwWmjx
wLKco7I1INvKx1Gv+/5Rb4RLWF73SViZ9fXAmPlCOl3AturvfsP2vRbKYB0UVVJUGMmW
ZjgFwPttuyljGuOJ9DyiYxxmyg0PAni6RZk0bN+75acnToFFlehwaGOjBbda0Py+bpfb
eAkw==
X-Gm-Message-State: AOAM530tpIfCPNa/zRmjPAe1kr5UEoTbUBz29pvy7wUUT+OuJHyjPCnS
bGz7wbc2iI9oV1pgdNCokNUVzWrJyfb1PQ==
X-Google-Smtp-Source:
ABdhPJylqrA5WUF7HVL+RNPB/6ungU4M0cE4pm3/NKdLTv06SGPm/rlhzHNzBUsfyhhBqBItzkCRkw==
X-Received: by 2002:a1c:17:: with SMTP id 23mr9984021wma.6.1614964526170;
Fri, 05 Mar 2021 09:15:26 -0800 (PST)
From: Peter Maydell <peter.maydell@linaro.org>
To: qemu-devel@nongnu.org
Subject: [PULL 11/49] hw/i2c/npcm7xx_smbus: Simplify npcm7xx_smbus_init()
Date: Fri, 5 Mar 2021 17:14:37 +0000
Message-Id: <20210305171515.1038-12-peter.maydell@linaro.org>
X-Mailer: git-send-email 2.20.1
In-Reply-To: <20210305171515.1038-1-peter.maydell@linaro.org>
References: <20210305171515.1038-1-peter.maydell@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17
as permitted sender) client-ip=209.51.188.17;
envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org;
helo=lists.gnu.org;
Received-SPF: pass client-ip=2a00:1450:4864:20::330;
envelope-from=peter.maydell@linaro.org; helo=mail-wm1-x330.google.com
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,
SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-BeenThere: qemu-devel@nongnu.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <https://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org
Sender: "Qemu-devel" <qemu-devel-bounces+importer=patchew.org@nongnu.org>
X-ZohoMail-DKIM: pass (identity @linaro.org)
From: Philippe Mathieu-Daud=C3=A9 <f4bug@amsat.org>
The STATUS register will be reset to IDLE in
cnpcm7xx_smbus_enter_reset(), no need to preset
it in instance_init().
Signed-off-by: Philippe Mathieu-Daud=C3=A9 <f4bug@amsat.org>
Reviewed-by: Hao Wu <wuhaotsh@google.com>
Message-id: 20210228224813.312532-1-f4bug@amsat.org
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
hw/i2c/npcm7xx_smbus.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/hw/i2c/npcm7xx_smbus.c b/hw/i2c/npcm7xx_smbus.c
index 6b2f9e1aaad..e7e0ba66fe7 100644
--- a/hw/i2c/npcm7xx_smbus.c
+++ b/hw/i2c/npcm7xx_smbus.c
@@ -1040,7 +1040,6 @@ static void npcm7xx_smbus_init(Object *obj)
sysbus_init_mmio(sbd, &s->iomem);
=20
s->bus =3D i2c_init_bus(DEVICE(s), "i2c-bus");
- s->status =3D NPCM7XX_SMBUS_STATUS_IDLE;
}
=20
static const VMStateDescription vmstate_npcm7xx_smbus =3D {
--=20
2.20.1