From nobody Tue Feb 10 05:16:59 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.128.41 as permitted sender) client-ip=209.85.128.41; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-f41.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.41 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1614961299; cv=none; d=zohomail.com; s=zohoarc; b=f47cfu647hFSsG1c/7nfDEhvz/7js5npxj3w7Aq0VwfxGDckIjwLxxRuKGNfN7Fs3qLI7PepIMTZusQ7UNYH0OSOq3Td6mqox/kR5aK2u8RNBuZUNQ9KaFP0ti/CSaLaMaegV7ujcCIpeVaOfgQsq8b8JY7n57SnRBB64zoEgxU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1614961299; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=RFA8710d7y21V9/sjoSrymWAAotgH49b0pKscVplcYw=; b=mrWdUwMtjP8mf7A1VA2EdXegK5bI5hVrdrvN48XnKyqs75QrkyNqOz4O9VVDuLdfO9PLs/TjSj1Qw5qk3lvC4FYGC5bv//xOHR6GZCilZWN2m0V+dmQbLUcPVXjDyNQOKnRJ4SdyymDQUstBxds0XAs+0vVXVjmpmcZyiKn0a7k= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.41 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) by mx.zohomail.com with SMTPS id 1614961299190251.1124471733251; Fri, 5 Mar 2021 08:21:39 -0800 (PST) Received: by mail-wm1-f41.google.com with SMTP id m7so1972918wmq.0 for ; Fri, 05 Mar 2021 08:21:38 -0800 (PST) Return-Path: Return-Path: Received: from localhost.localdomain (68.red-83-57-175.dynamicip.rima-tde.net. [83.57.175.68]) by smtp.gmail.com with ESMTPSA id c3sm5033116wrr.29.2021.03.05.08.21.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Mar 2021 08:21:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=RFA8710d7y21V9/sjoSrymWAAotgH49b0pKscVplcYw=; b=o7MlH9Oodd972e/C8geXVcLvys+HAUlS7CXcRnu6GzIzKmbVyiLFPRroXo1dlQABUK NUcBCKHr9TfpISblbhSaNCY/fR6N2mI1OfTw8iAPhz4OUcvtsGIKAcFFhC+pS8REyHmY fDgb8U0NbpPRtNFOaICXwS32ASUGAdixoS3JHXkhzeeYVxj85clBE8BY+gyFUJ0cxfJX sb7+beLwvA8BoOQLWYcGcKyozAHbWVxbjat7AKE4Mwthtj2VMydFphcKXZNBcNjTdiYD olpoQ+4eTEMbGhy/OgDrbrEQNGzljd10uS5CnLrdLziD7vH/IQ06pjH8ZTuiudByWe9G m7Cw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=RFA8710d7y21V9/sjoSrymWAAotgH49b0pKscVplcYw=; b=bGcSjIlzc3WCzVxhaLPSVepyr6c6OK3Do4tummKhXu9iUs9OcIN5PyByeQqXigDIHI vrv5m/W30W5nL4N9NSZZpHiEejd8tPFJDFEaGW/G/ZNkrPo9u+WGRKxz4+YZcoJCLf4P q+TUqOwiZ64jmQN1ABnZeRcxKguWPFMHzbd2oqtMdB0C4M7UCj6dpDaKxJd0rYvfYUmX G71n4NPXskPQkbbjiIcS2nTaw96yOSimiG2jDXi3eWXvJHyYEr4S0SzvvYlnZ5QNY/nv HHhxoY7KUP8CX+A4EYlv06q2cBZrJdrCF10w3Dk95HUFJrRflv/TbjwUV4mrIQMuJi/i m59A== X-Gm-Message-State: AOAM530YvoZ0XDG3vhwyNCaASag0k7lecPK6fv2De71JGqhyHK8bw6iq 9zr7LbJaT/Qa4OB07Pw/qQs= X-Google-Smtp-Source: ABdhPJxlYv1yidtuaDF1acJQiIzyeN/7Y8hpel7K5gREIdKoxE6sGOwqOG69nLLHIGMecruNogeZMg== X-Received: by 2002:a1c:bb89:: with SMTP id l131mr9936815wmf.47.1614961297422; Fri, 05 Mar 2021 08:21:37 -0800 (PST) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Jiaxun Yang , Aurelien Jarno , Aleksandar Rikalo Subject: [PATCH 6/6] hw/mips/gt64xxx: Let the GT64120 manage the lower 512MiB hole Date: Fri, 5 Mar 2021 17:21:07 +0100 Message-Id: <20210305162107.2233203-7-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210305162107.2233203-1-f4bug@amsat.org> References: <20210305162107.2233203-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) Per the comment in the Malta board, the [0x0000.0000-0x2000.0000] range is decoded by the GT64120, so move the "empty_slot" there. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/mips/gt64xxx_pci.c | 8 ++++++++ hw/mips/malta.c | 7 ------- 2 files changed, 8 insertions(+), 7 deletions(-) diff --git a/hw/mips/gt64xxx_pci.c b/hw/mips/gt64xxx_pci.c index 43349d6837d..a3926e5cb8a 100644 --- a/hw/mips/gt64xxx_pci.c +++ b/hw/mips/gt64xxx_pci.c @@ -29,6 +29,7 @@ #include "hw/mips/mips.h" #include "hw/pci/pci.h" #include "hw/pci/pci_host.h" +#include "hw/misc/empty_slot.h" #include "hw/southbridge/piix.h" #include "migration/vmstate.h" #include "hw/intc/i8259.h" @@ -1206,6 +1207,13 @@ static void gt64120_realize(DeviceState *dev, Error = **errp) =20 memory_region_init_io(&s->ISD_mem, OBJECT(dev), &isd_mem_ops, s, "gt64120-isd", 0x1000); + + /* + * The whole address space decoded by the GT-64120A doesn't generate + * exception when accessing invalid memory. Create an empty slot to + * emulate this feature. + */ + empty_slot_init("GT64120", 0, 0x20000000); } =20 PCIBus *gt64120_register(qemu_irq *pic) diff --git a/hw/mips/malta.c b/hw/mips/malta.c index 9afc0b427bf..b2469f8ee78 100644 --- a/hw/mips/malta.c +++ b/hw/mips/malta.c @@ -56,7 +56,6 @@ #include "sysemu/runstate.h" #include "qapi/error.h" #include "qemu/error-report.h" -#include "hw/misc/empty_slot.h" #include "sysemu/kvm.h" #include "hw/semihosting/semihost.h" #include "hw/mips/cps.h" @@ -1396,12 +1395,6 @@ void mips_malta_init(MachineState *machine) =20 /* Northbridge */ pci_bus =3D gt64120_register(s->i8259); - /* - * The whole address space decoded by the GT-64120A doesn't generate - * exception when accessing invalid memory. Create an empty slot to - * emulate this feature. - */ - empty_slot_init("GT64120", 0, 0x20000000); =20 /* Southbridge */ dev =3D piix4_create(pci_bus, &isa_bus, &smbus); --=20 2.26.2