From nobody Tue Feb 10 05:16:59 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.42 as permitted sender) client-ip=209.85.221.42; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f42.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.42 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1614961280; cv=none; d=zohomail.com; s=zohoarc; b=TqJeenR4GvN/kLPo4MNL8pxVS/lX9Jn/cEAZFVHdsQQOQ0bKeEM1ZC7jPGkryOSUX2vh7VoXaZfB7VwZJwfRt+q8g8VcOcYpxsSl468CcJzPk+HVZNkQpLskyAcF++cXREY1re4hk1PsMXWP/jGw2KCxsNiQbT3rQpacqSVaIB4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1614961280; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=fHShbnL609j0MJwdNHwq2VVMU06lFz5d39e3YBTfjlM=; b=oHlkUiMTKqyGFC2GP02dUzd7FxOeDpa/6Wguj+py0TWPVTO6GTPB5fojZnDxOPjEKgY7fpiryOg+XnGM2RqJWDOok4QLGkgbVdt+fk+KnUlJUWFNM+nf65v4+Jz/ouTlVYbRf4t2z4m0P7kE6r/Cvs5s6uzOwWLD4yjNuaOOzx8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.42 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) by mx.zohomail.com with SMTPS id 1614961280693568.3467817122367; Fri, 5 Mar 2021 08:21:20 -0800 (PST) Received: by mail-wr1-f42.google.com with SMTP id d15so2719213wrv.5 for ; Fri, 05 Mar 2021 08:21:20 -0800 (PST) Return-Path: Return-Path: Received: from localhost.localdomain (68.red-83-57-175.dynamicip.rima-tde.net. [83.57.175.68]) by smtp.gmail.com with ESMTPSA id h62sm5259597wmf.37.2021.03.05.08.21.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Mar 2021 08:21:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=fHShbnL609j0MJwdNHwq2VVMU06lFz5d39e3YBTfjlM=; b=t2QvGL/fUV8WMz/TEXngi7meDFvL+PTNNNLHCxnpiVfd8QksSwyKa1Nqf0amOdu/jb m1nOo3js3mwz3o6J+Wbg0cS9s9nqY086tQdc/ycdn2U0ZEmaAZ6GXNGMIux2a+jdYj5Y JR+KCgkOvsKQ9sERI59eWAImE7Y1XmE0unbaotDF7VgCejQDnvDc6mlXOsH3CCSd86IO 8tL1n+2wgLJNx+ueFR4L7a2nyKuSgJ/Uu8Jg/lo1xmXXX5P5SV7DGUSjJRoYtI4vsnD4 LNwv8AiSngBDQmsJ+bCAc9Pflv2CeysSml7B9hA0uu7ekBmmoNVWI8QcSprYbpUnkwFt 7UmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=fHShbnL609j0MJwdNHwq2VVMU06lFz5d39e3YBTfjlM=; b=IqGPP3pmk9XbBQNcmRvTbB863e8NFSjaJnSxFxzKprO40kEfxN3Ia8iM0+WwGkidcz Mz7zlqbsL8A76JIvPsGOWpRiSg9Ya8EkPIy2FZWAYVDBY/U7Ye8kJpC4lCCMGZRXMd9O /cO7RKyaMIW1xgBn9FwEMZ3a4yLpdA45SQEdQODOvTSFF3eVAPORc7DMBZ3R2c2NG34X n/45E9A8GROdYW7vuqLKqmtop6fuIatgoZFCVzXR9x0FVxYnhFX69ZecSUkPG3/NcaEp PMKRS8Jqc6OWbA7DYhFK+bpv8CXMZwZwevi6vhnsgEgsfzmBc1YHU2KwCyJb5oftZeC8 +/Mw== X-Gm-Message-State: AOAM533Hjnb0MpepmYCACe1TsiRqsoqeoJCVT45Y5N+kKtnDo4afaqnQ 9BuryyD7+pirC/rLAWWwEgmer8nSO4Y= X-Google-Smtp-Source: ABdhPJxYaYHsMWLVOa/RlkupvG2ev+qVey1GEs4vvZL/yBRPzxyLs4c70zIgsNzkwCgUiNj85MMvDg== X-Received: by 2002:adf:a406:: with SMTP id d6mr10274176wra.141.1614961278887; Fri, 05 Mar 2021 08:21:18 -0800 (PST) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Jiaxun Yang , Aurelien Jarno , Aleksandar Rikalo Subject: [PATCH 2/6] hw/mips/gt64xxx: Simplify ISD MemoryRegion read/write handlers Date: Fri, 5 Mar 2021 17:21:03 +0100 Message-Id: <20210305162107.2233203-3-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210305162107.2233203-1-f4bug@amsat.org> References: <20210305162107.2233203-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) The ISD MemoryRegion is implemented for 32-bit accesses. Simplify it by setting the MemoryRegionOps::impl min/max access size fields. Since the region is registered with a size of 0x1000 bytes, we can remove the hwaddr mask. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/mips/gt64xxx_pci.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/hw/mips/gt64xxx_pci.c b/hw/mips/gt64xxx_pci.c index 6eb73e77057..99b1690af19 100644 --- a/hw/mips/gt64xxx_pci.c +++ b/hw/mips/gt64xxx_pci.c @@ -385,13 +385,12 @@ static void gt64120_writel(void *opaque, hwaddr addr, { GT64120State *s =3D opaque; PCIHostState *phb =3D PCI_HOST_BRIDGE(s); - uint32_t saddr; + uint32_t saddr =3D addr >> 2; =20 if (!(s->regs[GT_CPU] & 0x00001000)) { val =3D bswap32(val); } =20 - saddr =3D (addr & 0xfff) >> 2; switch (saddr) { =20 /* CPU Configuration */ @@ -695,9 +694,8 @@ static uint64_t gt64120_readl(void *opaque, GT64120State *s =3D opaque; PCIHostState *phb =3D PCI_HOST_BRIDGE(s); uint32_t val; - uint32_t saddr; + uint32_t saddr =3D addr >> 2; =20 - saddr =3D (addr & 0xfff) >> 2; switch (saddr) { =20 /* CPU Configuration */ @@ -976,6 +974,10 @@ static const MemoryRegionOps isd_mem_ops =3D { .read =3D gt64120_readl, .write =3D gt64120_writel, .endianness =3D DEVICE_NATIVE_ENDIAN, + .impl =3D { + .min_access_size =3D 4, + .max_access_size =3D 4, + }, }; =20 static int gt64120_pci_map_irq(PCIDevice *pci_dev, int irq_num) --=20 2.26.2