From nobody Tue Feb 10 04:13:45 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1614959812; cv=none; d=zohomail.com; s=zohoarc; b=iz4mB1dfROurtisVuGr1XCuuf1A6hbOTeiOhN7hl51X+coH00ZjXJ612UZvXNEf6Kt5Bb/Y02ps65ASO4oJyaeCW65PsnGy9YR0H1gSzmnkwH56EjvLl/iIKhnUuBle8GDcOk5K+lPo3m3f5a19hxjQXA0Yks+0+KQengFlONLY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1614959812; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=BrXiNEnhECUFgYacW/pyoN4G9h6gNQGkgmLZyZT9kRo=; b=UdagMhj4l2VpTRlD76/U955Xey22s5Xd7LiOPKvv7PJHbeE6Qxtt5XIdvpE9OFmBTl6SVD8HQGFCpHztvWQz2FuWPLpn7OqIQcJfpp/tkY90pQyjhFyTLw69owN8pm56cB82Fp7WIN4eCnikj6W4rxada9yj20mEzwFREFabXWw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1614959812043287.09831042463986; Fri, 5 Mar 2021 07:56:52 -0800 (PST) Received: from localhost ([::1]:60646 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lICos-00056J-Vz for importer@patchew.org; Fri, 05 Mar 2021 10:56:51 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:40636) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lICnc-0003jV-0i for qemu-devel@nongnu.org; Fri, 05 Mar 2021 10:55:32 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:37073) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1lICna-0003Ir-ED for qemu-devel@nongnu.org; Fri, 05 Mar 2021 10:55:31 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-500-2SOGEo_BNyig5Vv2S0bPhQ-1; Fri, 05 Mar 2021 10:55:27 -0500 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D3FFA83DD20; Fri, 5 Mar 2021 15:55:25 +0000 (UTC) Received: from gondolin.redhat.com (ovpn-112-55.ams2.redhat.com [10.36.112.55]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4D04D6A046; Fri, 5 Mar 2021 15:55:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1614959729; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BrXiNEnhECUFgYacW/pyoN4G9h6gNQGkgmLZyZT9kRo=; b=C0gn+wGaVF9PSR5b4m8E3syyKnDb2jVK7mlqifmwsQLvgpboxqDw8eaIvrTGgW+3YuY+7A Wr0jf+wHwg1Hiq/OrjeBg4fLMU5emKOog1sJLYgT5SnEUZsmv41UB3uawL4ebmij8PkSKC tGoGvsbJLRNKmKUWIXLatEQNfsJGeNs= X-MC-Unique: 2SOGEo_BNyig5Vv2S0bPhQ-1 From: Cornelia Huck To: Peter Maydell Subject: [PULL 1/8] s390x/cpu_model: disallow unpack for --only-migratable Date: Fri, 5 Mar 2021 16:55:10 +0100 Message-Id: <20210305155517.1604547-2-cohuck@redhat.com> In-Reply-To: <20210305155517.1604547-1-cohuck@redhat.com> References: <20210305155517.1604547-1-cohuck@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=cohuck@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=63.128.21.124; envelope-from=cohuck@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Hildenbrand , Cornelia Huck , qemu-devel@nongnu.org, Halil Pasic , Christian Borntraeger , qemu-s390x@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" From: Christian Borntraeger Secure execution (aka protected virtualization) guests cannot be migrated at the moment. If the unpack facility is provided in the cpu model, a guest may choose to transition to secure mode, making the guest unmigratable at that point in time. If the machine was explicitly started with --only-migratable, we would get a failure only when the guest actually tries to transition; instead, explicitly disallow the unpack facility if --only-migratable was specified to avoid late surprises. Signed-off-by: Christian Borntraeger Reviewed-by: David Hildenbrand Reviewed-by: Halil Pasic Message-Id: <20210125135332.181324-1-borntraeger@de.ibm.com> Signed-off-by: Cornelia Huck --- target/s390x/cpu_models.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/target/s390x/cpu_models.c b/target/s390x/cpu_models.c index 35179f9dc7ba..dd474c5e9ad1 100644 --- a/target/s390x/cpu_models.c +++ b/target/s390x/cpu_models.c @@ -26,6 +26,7 @@ #include "qapi/qmp/qdict.h" #ifndef CONFIG_USER_ONLY #include "sysemu/arch_init.h" +#include "sysemu/sysemu.h" #include "hw/pci/pci.h" #endif #include "qapi/qapi-commands-machine-target.h" @@ -878,6 +879,15 @@ static void check_compatibility(const S390CPUModel *ma= x_model, return; } =20 +#ifndef CONFIG_USER_ONLY + if (only_migratable && test_bit(S390_FEAT_UNPACK, model->features)) { + error_setg(errp, "The unpack facility is not compatible with " + "the --only-migratable option. You must remove either " + "the 'unpack' facility or the --only-migratable option"= ); + return; + } +#endif + /* detect the missing features to properly report them */ bitmap_andnot(missing, model->features, max_model->features, S390_FEAT= _MAX); if (bitmap_empty(missing, S390_FEAT_MAX)) { --=20 2.26.2