From nobody Mon Feb 9 20:35:05 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1614925727; cv=none; d=zohomail.com; s=zohoarc; b=ZnE5augGYgZYpLDvA2Lc0ZiXuUWiGJiVGfTS7MH+RqWWx1pbSkD+ZeGXByCkAeFHt2FFFu1XjBthzuTY/n5EHBPUzXWzHyUav7HaQYga3ZqMR+Dy4AfYT4NLqxeEds4fFk+TZk+xqIVE4vt3BDWLYD0NwQju4A4yyGFudIsuAxc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1614925727; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=eqKFHMOiIEPKgh1y4HEY7UZP+w7zap/1S+8CSSA7EJY=; b=RxjxVFidDX1oZvpz3CGFLFRCSfQu3emaouE2a+0/7eXrSr3ftvIZ3tjJK8sTqxh6VP7qo6R6CkB7OWSa2uMfmwrcT547170q81ZRrRbif6oBnDHwR9Xw62Dk4dUph0JdTMQtTirJHYTP3qPLvsdV6qufqcS9ENnAau3k+0VXzOo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1614925727559511.64545056241786; Thu, 4 Mar 2021 22:28:47 -0800 (PST) Received: from localhost ([::1]:44848 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lI3x8-0006GL-Cl for importer@patchew.org; Fri, 05 Mar 2021 01:28:46 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:55402) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lI3vf-0004Qx-Tf for qemu-devel@nongnu.org; Fri, 05 Mar 2021 01:27:15 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:33864) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1lI3ve-0005hG-Fl for qemu-devel@nongnu.org; Fri, 05 Mar 2021 01:27:15 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-15-cOf-NnFfPqSfitqAGvdqLw-1; Fri, 05 Mar 2021 01:27:10 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 92C9380006E; Fri, 5 Mar 2021 06:27:09 +0000 (UTC) Received: from localhost.localdomain (ovpn-12-165.pek2.redhat.com [10.72.12.165]) by smtp.corp.redhat.com (Postfix) with ESMTP id A7C8E60C5F; Fri, 5 Mar 2021 06:27:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1614925633; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eqKFHMOiIEPKgh1y4HEY7UZP+w7zap/1S+8CSSA7EJY=; b=VqAxU3XYyxOk2bCFP0Dm8GSAO6G0fQnJYkKWoBKF0t3U6LE0S0e7mbTl4Sif4Lc7A0bgkk ehMaRtA4xJnBzjGge/lVIUzVDIn07QZmjXTa3l4wEhAmDB8hf2zJT161aepqk6qUyE2itF W5eWR4X0JIgVxB8tSPOmMIit1aRH5XI= X-MC-Unique: cOf-NnFfPqSfitqAGvdqLw-1 From: Jason Wang To: qemu-devel@nongnu.org, qemu-security@nongnu.org Subject: [PATCH V4 05/10] sungem: switch to use qemu_receive_packet() for loopback Date: Fri, 5 Mar 2021 14:26:33 +0800 Message-Id: <20210305062638.6749-6-jasowang@redhat.com> In-Reply-To: <20210305062638.6749-1-jasowang@redhat.com> References: <20210305062638.6749-1-jasowang@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jasowang@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=216.205.24.124; envelope-from=jasowang@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alxndr@bu.edu, Jason Wang , philmd@redhat.com, Mark Cave-Ayland , ppandit@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) This patch switches to use qemu_receive_packet() which can detect reentrancy and return early. This is intended to address CVE-2021-3416. Cc: Prasad J Pandit Reviewed-by: Mark Cave-Ayland Reviewed-by: Philippe Mathieu-Daud=C3=A9 Signed-off-by: Jason Wang --- hw/net/sungem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/net/sungem.c b/hw/net/sungem.c index 33c3722df6..3684a4d733 100644 --- a/hw/net/sungem.c +++ b/hw/net/sungem.c @@ -306,7 +306,7 @@ static void sungem_send_packet(SunGEMState *s, const ui= nt8_t *buf, NetClientState *nc =3D qemu_get_queue(s->nic); =20 if (s->macregs[MAC_XIFCFG >> 2] & MAC_XIFCFG_LBCK) { - nc->info->receive(nc, buf, size); + qemu_receive_packet(nc, buf, size); } else { qemu_send_packet(nc, buf, size); } --=20 2.24.3 (Apple Git-128)