From nobody Mon Feb 9 17:37:09 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1614925841; cv=none; d=zohomail.com; s=zohoarc; b=dCRIaLRTdvX/L4RjD38JXAgk4fOP8KhM2Iuj6u4ZucM/02rQCG0ZLKx2GWqtMDdVgvOFuzt6AlfAPZMOygvlBc8LR5kQRB+zoXyS5w0ov6bUq2g6YDdUwnng8jKAitlgIeo41vKSbPgJSLmrigkuFHu/raHPP/G/keRnjoEJ1Pw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1614925841; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=ZYPbIY1umAs7zZOgzqd864l+bAJddKbbaB11tX/5yoQ=; b=C1cjxy+LScLIOqJu4gEWrbggTOqormUo9PB7v1pSBAZxLdeKndJ+FvEOmqwpECB/iT8Ub3rjr4mrwHUg5jcRh1y3mHEHR0fx0WQ9pG56Bwjyq9XkE9tJqidEU3o9hSGgbjKQLyLLTc0561yiKTQ3LesIDl+uwMKcYlpb/8md9rM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1614925841430860.3383998683776; Thu, 4 Mar 2021 22:30:41 -0800 (PST) Received: from localhost ([::1]:50786 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lI3yy-0000CV-Ex for importer@patchew.org; Fri, 05 Mar 2021 01:30:40 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:55330) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lI3vV-00047a-3i for qemu-devel@nongnu.org; Fri, 05 Mar 2021 01:27:05 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:42405) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1lI3vT-0005b3-Eh for qemu-devel@nongnu.org; Fri, 05 Mar 2021 01:27:04 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-487-SkTOibuzN5-lg5JB2p6jjw-1; Fri, 05 Mar 2021 01:27:00 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D1375804332; Fri, 5 Mar 2021 06:26:58 +0000 (UTC) Received: from localhost.localdomain (ovpn-12-165.pek2.redhat.com [10.72.12.165]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1EED560C5F; Fri, 5 Mar 2021 06:26:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1614925622; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZYPbIY1umAs7zZOgzqd864l+bAJddKbbaB11tX/5yoQ=; b=bxkZToqot1NSA8wCKt4LYy1UXlvGGxejuiONNfkeQJMOHHy6rxYtefMNsz7HDy7Hv03xL2 UnnBAhBCCs4JBuyzNjsj0y1/ABaBJ74UnVKyRm051bCZob2S7Ifm4uIcX7pDf3HLym7nuB qvyXaO7YBplheZzoj/Gieq1elRq7VjA= X-MC-Unique: SkTOibuzN5-lg5JB2p6jjw-1 From: Jason Wang To: qemu-devel@nongnu.org, qemu-security@nongnu.org Subject: [PATCH V4 03/10] dp8393x: switch to use qemu_receive_packet() for loopback packet Date: Fri, 5 Mar 2021 14:26:31 +0800 Message-Id: <20210305062638.6749-4-jasowang@redhat.com> In-Reply-To: <20210305062638.6749-1-jasowang@redhat.com> References: <20210305062638.6749-1-jasowang@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jasowang@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=216.205.24.124; envelope-from=jasowang@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alxndr@bu.edu, Jason Wang , philmd@redhat.com, ppandit@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) This patch switches to use qemu_receive_packet() which can detect reentrancy and return early. This is intended to address CVE-2021-3416. Cc: Prasad J Pandit Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- hw/net/dp8393x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/net/dp8393x.c b/hw/net/dp8393x.c index 205c0decc5..533a8304d0 100644 --- a/hw/net/dp8393x.c +++ b/hw/net/dp8393x.c @@ -506,7 +506,7 @@ static void dp8393x_do_transmit_packets(dp8393xState *s) s->regs[SONIC_TCR] |=3D SONIC_TCR_CRSL; if (nc->info->can_receive(nc)) { s->loopback_packet =3D 1; - nc->info->receive(nc, s->tx_buffer, tx_len); + qemu_receive_packet(nc, s->tx_buffer, tx_len); } } else { /* Transmit packet */ --=20 2.24.3 (Apple Git-128)