From nobody Fri Oct 25 19:29:31 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1614896590; cv=none; d=zohomail.com; s=zohoarc; b=C2LCqKELWDAdTflU17O88Hvw1ozwWmxe5ha43y8RbAZHZe+Q4fL0u3NB/fD/xNwtiiyYPG47HTPHw2uxCytqnaeA4YkSXB/8QtCOj5uOUbkquG5FbfYiFJK9oYmr0I22M/ElAp9ulylq8w1g1zau0eIv9QPUbsszMYSdgfjWUlA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1614896590; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=PonmsOW9FGJ4jBcGzxjkr31XQxJgUTr+92/aQTI7IWY=; b=MiA+38Re6FSkIJ8ecmuUrkF6J6bHXXSQGW7AM1ejgphlTSXh2fNvb3b6kO+y3v+Ee3tlEVkwRPM5M3//8OaEd/urjQ2LlWl8VDoOVpfmuQZnUcnfkG53VN+mq9Zaljn0AXONnTMhHhn0nSAU21LXHRS6gghi3DGiJ4OWsXY8CBs= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1614896590113355.57122850750284; Thu, 4 Mar 2021 14:23:10 -0800 (PST) Received: from localhost ([::1]:37474 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lHwNA-0005Jz-UI for importer@patchew.org; Thu, 04 Mar 2021 17:23:08 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:53460) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lHwCr-0005z6-1q for qemu-devel@nongnu.org; Thu, 04 Mar 2021 17:12:29 -0500 Received: from mail.ilande.co.uk ([2001:41c9:1:41f::167]:40034 helo=mail.default.ilande.uk0.bigv.io) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lHwCp-0005yO-4J for qemu-devel@nongnu.org; Thu, 04 Mar 2021 17:12:28 -0500 Received: from host86-148-34-47.range86-148.btcentralplus.com ([86.148.34.47] helo=kentang.home) by mail.default.ilande.uk0.bigv.io with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lHwCj-0008MJ-Bi; Thu, 04 Mar 2021 22:12:25 +0000 From: Mark Cave-Ayland To: qemu-devel@nongnu.org, pbonzini@redhat.com, fam@euphon.net, laurent@vivier.eu Date: Thu, 4 Mar 2021 22:10:35 +0000 Message-Id: <20210304221103.6369-15-mark.cave-ayland@ilande.co.uk> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210304221103.6369-1-mark.cave-ayland@ilande.co.uk> References: <20210304221103.6369-1-mark.cave-ayland@ilande.co.uk> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 86.148.34.47 X-SA-Exim-Mail-From: mark.cave-ayland@ilande.co.uk Subject: [PATCH v3 14/42] esp: remove minlen restriction in handle_ti X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on mail.default.ilande.uk0.bigv.io) Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2001:41c9:1:41f::167; envelope-from=mark.cave-ayland@ilande.co.uk; helo=mail.default.ilande.uk0.bigv.io X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" The limiting of DMA transfers to the maximum size of the available data is = already handled by esp_do_dma() and do_dma_pdma_cb(). Signed-off-by: Mark Cave-Ayland Reviewed-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Laurent Vivier --- hw/scsi/esp.c | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/hw/scsi/esp.c b/hw/scsi/esp.c index 92fea6a8c4..07d57cb791 100644 --- a/hw/scsi/esp.c +++ b/hw/scsi/esp.c @@ -552,7 +552,7 @@ void esp_transfer_data(SCSIRequest *req, uint32_t len) =20 static void handle_ti(ESPState *s) { - uint32_t dmalen, minlen; + uint32_t dmalen; =20 if (s->dma && !s->dma_enabled) { s->dma_cb =3D handle_ti; @@ -560,16 +560,8 @@ static void handle_ti(ESPState *s) } =20 dmalen =3D esp_get_tc(s); - - if (s->do_cmd) { - minlen =3D (dmalen < ESP_CMDBUF_SZ) ? dmalen : ESP_CMDBUF_SZ; - } else if (s->ti_size < 0) { - minlen =3D (dmalen < -s->ti_size) ? dmalen : -s->ti_size; - } else { - minlen =3D (dmalen < s->ti_size) ? dmalen : s->ti_size; - } - trace_esp_handle_ti(minlen); if (s->dma) { + trace_esp_handle_ti(dmalen); s->rregs[ESP_RSTAT] &=3D ~STAT_TC; esp_do_dma(s); } else if (s->do_cmd) { --=20 2.20.1