From nobody Tue Feb 10 11:15:51 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.53 as permitted sender) client-ip=209.85.221.53; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f53.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.53 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1614808162; cv=none; d=zohomail.com; s=zohoarc; b=Bnr/HQIOWNtEyHI5e3gtX+1zu9hTVPqYcbq6iNdfD1QUHQQGvmgq15GuvV9Op4NOg2oTfLm8qtxAVNClXpa5CXDUI1mvtORoflZuDeEjsqEjrQzVWdaBQhNNmx2kRMhJHoN9CYQsE9eO+cdU/Hv9+8mPQxNa4cLI5pX/6hKk2/g= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1614808162; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=EiAs45/8RrC9+ORKHg3D6zi8PaaattSX1vXVK8lwp1c=; b=BbnN8c1DpI+4OXKqhJOwj08C3nW2moHlutY9Hp6N1OFAK06OL4vVOm2TkEz0M1olkYbDweaaIoWAIyn3WFvFLXXAm7IwxFFsft3KnRgZzW9DTsqb2JnUt5gc7XWo35pM/rC95B01TNjNbbGOm/xx1BQaeXKefwcaDWaF1Xrr2bE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.53 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com [209.85.221.53]) by mx.zohomail.com with SMTPS id 1614808162763332.882906457397; Wed, 3 Mar 2021 13:49:22 -0800 (PST) Received: by mail-wr1-f53.google.com with SMTP id u16so7367157wrt.1 for ; Wed, 03 Mar 2021 13:49:22 -0800 (PST) Return-Path: Return-Path: Received: from x1w.redhat.com (68.red-83-57-175.dynamicip.rima-tde.net. [83.57.175.68]) by smtp.gmail.com with ESMTPSA id r7sm33806893wre.25.2021.03.03.13.49.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Mar 2021 13:49:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=EiAs45/8RrC9+ORKHg3D6zi8PaaattSX1vXVK8lwp1c=; b=ufEWTYp3p7tj6hEz3k8BTBwooYiH8JE2gOPjzdAVZBAQxBy49PqvCSMtwHVUvmH9tO OF58jteoXSWCt2xb2zqnQgvagPNAI+6QYEg4hgQ43fTnaIOMTMeddrbjhL6ikmFZUfVj s3Ed31LBPh6fVAo1A4RqjaOvcjWhcW3DfVsXsa93SI+qM4H2BwjHwQuykHklyqvjqbSy BWcN/B40cP0uVpQjX7xyktAmzuYFO4hGvSI5E8uFSdzKUL+gRdpsV3P43lpD+QrAzHed pU1E+US1ZSbayHmCTI1+Ig7SAXB5TymhMtHeYnZMKVq2OLycCtcWtbItm9Qx+oYUso+N GVSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=EiAs45/8RrC9+ORKHg3D6zi8PaaattSX1vXVK8lwp1c=; b=Oclmn5L5ib9jr8SsEB+Y0jlmizrNclo/V6jOFgI6emgmUAcbOfq2BZdiPUkmdXxSYu xADVS0SyY7/LMjLa16NVqisvbZP0uilHRGWXcv1AXlYi6uHD1BaM01QGTpehG1XpKVnK /2Eelj1t4m7q2ZIurD+vac+htlcE2iJC+o9IldsCIRoBM866cWipANHDpoCuhzdhwR0d 8y0MY169w4Gmt61NroJoDHb7bVGTfKqpI5CvUfWvcZq0TFzVpjYwEgywUsZ3RhNLzaIP 8uKg6A/B1+KUFc7eBHbBOVF0SH1/YROmrOwz4J9RhZEbAdbVDlMHMmcvzQ4h32c6/7Kh sMGg== X-Gm-Message-State: AOAM5328Iz6U6hN/hot8Cn4qvZW9dI7EUvskBBKZeqkI/xaMVtRCaRAI CchcFExcex1Y7NLl+hFUsFI= X-Google-Smtp-Source: ABdhPJzuZWFGh3IGPE603zM6dkg+gEydT+i8E3xcrTonUKvbAsPed0eKEbxmkeJkLgl19/unaDBZEg== X-Received: by 2002:a05:6000:191:: with SMTP id p17mr813048wrx.154.1614808161082; Wed, 03 Mar 2021 13:49:21 -0800 (PST) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Claudio Fontana , qemu-arm@nongnu.org, Peter Maydell , Paolo Bonzini , Richard Henderson , qemu-s390x@nongnu.org, Thomas Huth , qemu-ppc@nongnu.org, Laurent Vivier , Cornelia Huck , =?UTF-8?q?Alex=20Benn=C3=A9e?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Max Filippov Subject: [PATCH v4 24/28] target/xtensa: Restrict watchpoint code to system emulation Date: Wed, 3 Mar 2021 22:47:04 +0100 Message-Id: <20210303214708.1727801-25-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210303214708.1727801-1-f4bug@amsat.org> References: <20210303214708.1727801-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) We can not use watchpoints in user-mode emulation because we need the softmmu slow path to detect accesses to watchpointed memory. Add #ifdef'ry around it. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- target/xtensa/helper.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/target/xtensa/helper.c b/target/xtensa/helper.c index eeffee297d1..85e466b37d2 100644 --- a/target/xtensa/helper.c +++ b/target/xtensa/helper.c @@ -201,6 +201,7 @@ void xtensa_register_core(XtensaConfigList *node) g_free((gpointer)type.name); } =20 +#ifndef CONFIG_USER_ONLY static uint32_t check_hw_breakpoints(CPUXtensaState *env) { unsigned i; @@ -213,9 +214,11 @@ static uint32_t check_hw_breakpoints(CPUXtensaState *e= nv) } return 0; } +#endif =20 void xtensa_breakpoint_handler(CPUState *cs) { +#ifndef CONFIG_USER_ONLY XtensaCPU *cpu =3D XTENSA_CPU(cs); CPUXtensaState *env =3D &cpu->env; =20 @@ -231,6 +234,7 @@ void xtensa_breakpoint_handler(CPUState *cs) cpu_loop_exit_noexc(cs); } } +#endif } =20 void xtensa_cpu_list(void) --=20 2.26.2