From nobody Tue Feb 10 07:43:06 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.51 as permitted sender) client-ip=209.85.221.51; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f51.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.51 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com; dmarc=fail(p=none dis=none) header.from=amsat.org ARC-Seal: i=1; a=rsa-sha256; t=1614808131; cv=none; d=zohomail.com; s=zohoarc; b=S5/jc1Kl863hY9orvwy+6IKLA/bpcmAoWvZCU+RSkvclh7x4t+UMtXfj6XuDctPmGQ8CoeHOAKuxyHf5GgZ6pesv2RgTdwFX4+1vc8CJouYBnf2/6VL8S6+VQhPwLFIeXpZdUXL0lUCgwxKSRS7UCYgYu1Y55VS8g0pR7o0iRrU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1614808131; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=kUl/TkScTas4U6LyrmMWcrV1B+r956Btg0Xp2UUszDg=; b=dy+bJepB4YbNCPdAJ2CjcBkaBKG5kNkIfaAuy2NosrMCuDCpb2yznSpcQCkRvP6Cfm6VkyGtpYEEo3vq42vBPqb7jXc3aZCtSg2D3Cupr2+JFbVqCECsPc5mRVpxm7DMFkNXqbYtYstAAvYcJVeXPyExFaTtOdFTw72a/jMD2BM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.51 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) by mx.zohomail.com with SMTPS id 1614808131796377.2936378072492; Wed, 3 Mar 2021 13:48:51 -0800 (PST) Received: by mail-wr1-f51.google.com with SMTP id f12so21566661wrx.8 for ; Wed, 03 Mar 2021 13:48:51 -0800 (PST) Return-Path: Return-Path: Received: from x1w.redhat.com (68.red-83-57-175.dynamicip.rima-tde.net. [83.57.175.68]) by smtp.gmail.com with ESMTPSA id g63sm7463370wma.40.2021.03.03.13.48.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Mar 2021 13:48:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=kUl/TkScTas4U6LyrmMWcrV1B+r956Btg0Xp2UUszDg=; b=qInQaYFsgsE69kLZN8Q0oTBi4JLGigTuAdCDOGlOkRUemirQGKUfhX9Pj8PC4uUvOY t88ghIacqaz2h0fwh9VbeOOOA44AWZ8O1H6BxbhYX/Qocj/GqBvR0tugFD/qlPvaCtYs s3bJFoCvS4S+9FvE9WV+PBiKVXDaEfbOFTbiDKnr8d2KZEJ8ZFoN7rKEXDRWVlm1COeO I4K7tzXcd9paZ0L5tbFEnJ1QUlimRuBh2lQgGI//cMLR469o/3detg+i+YJPevuQA7rp 4tj5UIKf38In16T2tGimCGGv5kdFEbIYLnGRnSaedNXc9dEifVo3xXRJ5ilbMN4+XSU7 whOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=kUl/TkScTas4U6LyrmMWcrV1B+r956Btg0Xp2UUszDg=; b=mJWn0RRcmnUeZ2M8wEIsDCMZpGLE0tC0H9KVeVImDWiX4Wokv1Jk6LShiHpGl70wCI BXlN1xQEwEsrIh3+zPoWbb3bnZ8RkrxPOWElmYHI/tIsGUhLM2gNtXtAYqR/2CJvKQRA 5nqPapmJZEHGhNqQLpoDDG7kM8Byz8aM5bP2Lkv/bjGkR+DXfZcXs8tCzVSUHiVzmKpu DUqGIDhXCrRPBGam4X+2QOH5Z/HwqO+VSdzQ6Lbjsp2KdUhG208+SEiJkkIiZ1D2cKEA v2sfcuJMD29NF88LoQQ/gvgf+WHOfTwFUWOWRqRsxFIvkyc0XKqYr+BSeoG2FmxTfong gmpA== X-Gm-Message-State: AOAM530UmmeqvwRE/i4iGIbCFX4pMOFRdZAJhyagJ81HLVnE+XCqM5je JR46obyQlaY9RhAN8RkVTcM= X-Google-Smtp-Source: ABdhPJyY4HgQ86PsHHmKaXEniS0UUWIyAYBaegUuvR3TasK7FrH16cvXpoFJEK/WJ9eL6FDQt/11LQ== X-Received: by 2002:a5d:698e:: with SMTP id g14mr666134wru.127.1614808130141; Wed, 03 Mar 2021 13:48:50 -0800 (PST) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Claudio Fontana , qemu-arm@nongnu.org, Peter Maydell , Paolo Bonzini , Richard Henderson , qemu-s390x@nongnu.org, Thomas Huth , qemu-ppc@nongnu.org, Laurent Vivier , Cornelia Huck , =?UTF-8?q?Alex=20Benn=C3=A9e?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH v4 18/28] gdbstub: Remove watchpoint dead code in gdbserver_fork() Date: Wed, 3 Mar 2021 22:46:58 +0100 Message-Id: <20210303214708.1727801-19-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210303214708.1727801-1-f4bug@amsat.org> References: <20210303214708.1727801-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) gdbserver_fork() is only used in user emulation where we can not use watchpoints because we need the softmmu slow path to detect accesses to watchpointed memory. This code doesn't do anything as declared as stubs in "hw/core/cpu.h". Drop it. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- gdbstub.c | 1 - 1 file changed, 1 deletion(-) diff --git a/gdbstub.c b/gdbstub.c index 3ee40479b69..f3614ebcc7a 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -3349,7 +3349,6 @@ void gdbserver_fork(CPUState *cpu) close(gdbserver_state.fd); gdbserver_state.fd =3D -1; cpu_breakpoint_remove_all(cpu, BP_GDB); - cpu_watchpoint_remove_all(cpu, BP_GDB); } #else static int gdb_chr_can_receive(void *opaque) --=20 2.26.2