From nobody Tue Feb 10 06:57:56 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.218.54 as permitted sender) client-ip=209.85.218.54; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-ej1-f54.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.218.54 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1614697236; cv=none; d=zohomail.com; s=zohoarc; b=M0/B4mqq+VOd28B2XvwOtrnEpAByQUmdMn6gwZ846I3X49QrWv79Yz2X9MaPinveny7v5Ofpb1ny/cQBNrhA4Y9gJnxEhDPo95k1+07NUKuWKmB1PK/6jIoMUd9OJz82SL2/Db1zSsSfoy+3r9GwzwJYOljyxniuld3NTy34Fxs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1614697236; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=j69ZoSRYfJYVN8Pr/CO14wOKQXEUVXgfUZYW8ZzPgjs=; b=M5j2Bv6mMIh30fFvFXa+SEdPi7iu1yQYUH7p4tz+HiQzWC+WLD2eGYFoI6FjbrV1GSzm1Yh9SXmAggUj8mE/XqU7mVFh7ZSX9TJar7ZMawyDBUkdlee5aypri69BdadKVp7OQ/qEgfGe5acp5NyOlumBh+8TCv53iAJtbJhtPxo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.218.54 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-ej1-f54.google.com (mail-ej1-f54.google.com [209.85.218.54]) by mx.zohomail.com with SMTPS id 1614697236179672.3950289080462; Tue, 2 Mar 2021 07:00:36 -0800 (PST) Received: by mail-ej1-f54.google.com with SMTP id gt32so24260263ejc.6 for ; Tue, 02 Mar 2021 07:00:32 -0800 (PST) Return-Path: Return-Path: Received: from x1w.redhat.com (68.red-83-57-175.dynamicip.rima-tde.net. [83.57.175.68]) by smtp.gmail.com with ESMTPSA id j14sm17921369eds.78.2021.03.02.07.00.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Mar 2021 07:00:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=j69ZoSRYfJYVN8Pr/CO14wOKQXEUVXgfUZYW8ZzPgjs=; b=rx9c/Fp9AUXsNAby0S9o6a2kG8PE2rgPupHi+3ITK7y6g/MlNm85u6c1dfOTRUg5T4 mr9Dv+AZ4B2Cv/jzmK/uVX9r0mFqHypc4TMWTJUiDO5m2g2xZ2XoEMVdnD3acdVbfm1s v+VSLYD5w9iAURWQDp3bSY6EjRNuyfsk6kG6I+AjOtorVqFif2NJj2gg2J9YdQkWQ0zs qtLh+P+qAL/vYTmxBODFSfqUKzZw6gTz/DNBA02OjTbwgu6GIFUCFtS43egEh4/hIuq+ f/V/vpVK2aN7CsfnoqFDHIsNf7fmouwJyoKzh7DBw/JsQbn5gsjiN1fLR6qCQiLxsCrA TyeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=j69ZoSRYfJYVN8Pr/CO14wOKQXEUVXgfUZYW8ZzPgjs=; b=sOBImX0Rly0/qtI78kH8yGUspVInajGzorZdNlyOKZ0xjhdv3JHh1Mj3WDbAnm7wMq HcnOwX1EQrxaMDph9chqmpMnEGye49ialInHatgGM0krL1N8F4OlxVuk1eYWMh6VM6kl QipBkBQ7rH59pglo/BgqVFtLKa9Jp7J7Rc9H1YTDMW5kWbQbTPGyf7slYhDcw1DCkcKT CI1rC6/VNTNFqUlnrltwuivVSZ1lPy9T/sH80VbVyOXNbJrow4xxH1ldJwiDIpRHZvR7 vVb1a+CbUT8pWAxks8aWNZb0Sbl2b/plub1puOH72qdPGiQ+BknSowKQ0XkAM+56A/qJ jkNg== X-Gm-Message-State: AOAM530+9IJJw42XZaB+VIkYckHxNOBs5vGtY4V7jf/NJeKdWSmmDT/R 0AYHLch8NKN7F4pza4DPOfY= X-Google-Smtp-Source: ABdhPJxCZHaZgGw3rdREFUDJZbblbpV4aRAL5G0RgH7jbrGgCSzoR86eMC0dVNm51ZsxLWNdq9MDMg== X-Received: by 2002:a17:906:1352:: with SMTP id x18mr10628239ejb.545.1614697225830; Tue, 02 Mar 2021 07:00:25 -0800 (PST) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Thomas Huth , qemu-arm@nongnu.org, Max Filippov , David Gibson , "Edgar E. Iglesias" , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Guan Xuetao , Alistair Francis , Michael Rolnik , Palmer Dabbelt , Richard Henderson , Laurent Vivier , Paolo Bonzini , Greg Kurz , Stafford Horne , qemu-ppc@nongnu.org, Anthony Green , Aurelien Jarno , Jiaxun Yang , Cornelia Huck , Claudio Fontana , Sagar Karandikar , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Michael Walle , Marek Vasut , Marcel Apfelbaum , Artyom Tarasenko , Peter Maydell , Aleksandar Rikalo , Chris Wulff , David Hildenbrand , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-s390x@nongnu.org, Sarah Harris , Eduardo Habkost , Bastian Koppelmann , qemu-riscv@nongnu.org, Mark Cave-Ayland , "Michael S. Tsirkin" , Yoshinori Sato , Taylor Simpson Subject: [PATCH v3 17/27] linux-user: Remove dead code Date: Tue, 2 Mar 2021 15:58:08 +0100 Message-Id: <20210302145818.1161461-18-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210302145818.1161461-1-f4bug@amsat.org> References: <20210302145818.1161461-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) We can not use watchpoints in user-mode emulation because we need the softmmu slow path to detect accesses to watchpointed memory. This code is expanded as empty stub in "hw/core/cpu.h" anyway, so we can drop it. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Laurent Vivier --- linux-user/main.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/linux-user/main.c b/linux-user/main.c index 81f48ff54ed..d7af3ffbc22 100644 --- a/linux-user/main.c +++ b/linux-user/main.c @@ -200,7 +200,6 @@ CPUArchState *cpu_copy(CPUArchState *env) CPUState *new_cpu =3D cpu_create(cpu_type); CPUArchState *new_env =3D new_cpu->env_ptr; CPUBreakpoint *bp; - CPUWatchpoint *wp; =20 /* Reset non arch specific state */ cpu_reset(new_cpu); @@ -211,13 +210,9 @@ CPUArchState *cpu_copy(CPUArchState *env) Note: Once we support ptrace with hw-debug register access, make su= re BP_CPU break/watchpoints are handled correctly on clone. */ QTAILQ_INIT(&new_cpu->breakpoints); - QTAILQ_INIT(&new_cpu->watchpoints); QTAILQ_FOREACH(bp, &cpu->breakpoints, entry) { cpu_breakpoint_insert(new_cpu, bp->pc, bp->flags, NULL); } - QTAILQ_FOREACH(wp, &cpu->watchpoints, entry) { - cpu_watchpoint_insert(new_cpu, wp->vaddr, wp->len, wp->flags, NULL= ); - } =20 return new_env; } --=20 2.26.2