From nobody Mon May 20 19:51:34 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1614677786; cv=none; d=zohomail.com; s=zohoarc; b=FI5kELVYY19ny5WAjg/gGOTtAzF/woJwA+VSOWPWaMWp4gGqNFRGICCOEbP8ZSvnXmhVomnRe2cB935EIhvx8GpP97yQx34SZ2fihB7KAZcFbNp4VLcI5GK69SSoJp+AqI36e9i3CoiKWMUymcsz61FMmL41jYIxdedgE7Jb1zY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1614677786; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=NSn1IsWlcSv4k+PHJ/QjqVzjsqcD6JhkBUe9xeOfuS0=; b=lo2AaJ/gOGvnjzz4JWV/v4RcQCGv5n1ppIU467vUwhkamRBrsMMtpB6Xem6/rEWqTE/uVYOHCiqNdDZfEL+PcCwfQos8LO4qAyY7tWugLfxLb7E7aGcmWB9SKdYRhUpqXfhZNJMoooQroVXwNXmdRON1XkSz7dlzK4/IudBLUaw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1614677786512150.50480462467885; Tue, 2 Mar 2021 01:36:26 -0800 (PST) Received: from localhost ([::1]:36926 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lH1S5-00075H-IU for importer@patchew.org; Tue, 02 Mar 2021 04:36:25 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:39408) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lH1Lh-0003Yt-MF for qemu-devel@nongnu.org; Tue, 02 Mar 2021 04:29:50 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:31842) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1lH1La-0006X7-4z for qemu-devel@nongnu.org; Tue, 02 Mar 2021 04:29:43 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-21-86rMww6LPgKBh6BEKJ9-Pw-1; Tue, 02 Mar 2021 04:29:38 -0500 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A9F80801976; Tue, 2 Mar 2021 09:29:37 +0000 (UTC) Received: from localhost (ovpn-114-138.ams2.redhat.com [10.36.114.138]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6E91F1F455; Tue, 2 Mar 2021 09:29:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1614677380; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=NSn1IsWlcSv4k+PHJ/QjqVzjsqcD6JhkBUe9xeOfuS0=; b=O8v19trZiNoY7t4IS5APEiN1i/2l5JRF40VwouAT1epJgjmuxGXckxgTcELSp0Hxsp5abc aRumj3JzlyTF4fGLzsrY0VcyQjmFZCEKZxAndB+0Gy/YN+mqfLKC1My0FY4oBOnrFmpou6 SpCZcF7KQkf/uwAtoolHmI+13rmoVkE= X-MC-Unique: 86rMww6LPgKBh6BEKJ9-Pw-1 From: Stefan Hajnoczi To: qemu-devel@nongnu.org Subject: [PATCH v2] qemu-storage-daemon: add --pidfile option Date: Tue, 2 Mar 2021 09:29:26 +0000 Message-Id: <20210302092926.163080-1-stefanha@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=stefanha@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=216.205.24.124; envelope-from=stefanha@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -10 X-Spam_score: -1.1 X-Spam_bar: - X-Spam_report: (-1.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, MIME_BASE64_TEXT=1.741, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Daniel Berrange , qemu-block@nongnu.org, afrosi@redhat.com, "Richard W . M . Jones" , Stefan Hajnoczi Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" Daemons often have a --pidfile option where the pid is written to a file so that scripts can stop the daemon by sending a signal. The pid file also acts as a lock to prevent multiple instances of the daemon from launching for a given pid file. QEMU, qemu-nbd, qemu-ga, virtiofsd, and qemu-pr-helper all support the --pidfile option. Add it to qemu-storage-daemon too. Reported-by: Richard W.M. Jones Signed-off-by: Stefan Hajnoczi Reviewed-by: Daniel P. Berrang=C3=A9 Reviewed-by: Richard W.M. Jones --- v2: * Add documentation about startup order [Rich, Daniel] docs/tools/qemu-storage-daemon.rst | 14 ++++++++++++ storage-daemon/qemu-storage-daemon.c | 34 ++++++++++++++++++++++++++++ 2 files changed, 48 insertions(+) diff --git a/docs/tools/qemu-storage-daemon.rst b/docs/tools/qemu-storage-d= aemon.rst index f63627eaf6..3d9704d835 100644 --- a/docs/tools/qemu-storage-daemon.rst +++ b/docs/tools/qemu-storage-daemon.rst @@ -118,6 +118,20 @@ Standard options: List object properties with ``,help``. See the :manpage:`qemu(1)` manual page for a description of the object properties. =20 +.. option:: --pidfile PATH + + is the path to a file where the daemon writes its pid. This allows scrip= ts to + stop the daemon by sending a signal:: + + $ kill -SIGTERM $(