From nobody Tue Feb 10 02:44:00 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1614664969; cv=none; d=zohomail.com; s=zohoarc; b=PZu/x2hXDerd5P99nomphy+fmfFkGvOVrT5MosbjQkCofNQ2Ej+LlotnUrNAV6P1tv3waE7xxifM+iCZQ0Szo+DEmsk6r1cVVcOPPrXrqD18jBfcC8m6PQ6Hq5Ilk2ffPQeZSnnUJgP9bPlry7RI/GIZ4+/XJhNIvx3Gqk23OH0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1614664969; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=publ5REQehQtX9O1B36SCXaRF8mM0EtxrmugTAnNW/0=; b=UfWrDgmwm6B4IOR6qIn/yjEp4qEFwGELQZEJiA0VlYim+WO4fhkqKlb/hXfGYaIiuphahHEHlkz38nQFgwEAPdAxQzcnlV7aZYnDd6fqPYsiC5a9JvzKi8rLYLzHGuDQwUSy/jZsq4gHIkM/rVY2T2sdU3OtJ6W3/XqhGSW01bA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1614664969679934.3106453311192; Mon, 1 Mar 2021 22:02:49 -0800 (PST) Received: from localhost ([::1]:38632 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lGy7M-0003GD-Kn for importer@patchew.org; Tue, 02 Mar 2021 01:02:48 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:39554) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lGy0c-0003L3-BD for qemu-devel@nongnu.org; Tue, 02 Mar 2021 00:55:50 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:26213) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1lGy0W-00020T-Vy for qemu-devel@nongnu.org; Tue, 02 Mar 2021 00:55:48 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-58-ReGjmWeZNUa7pjPBgF9W8A-1; Tue, 02 Mar 2021 00:55:40 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 7A7BE10066EF; Tue, 2 Mar 2021 05:55:39 +0000 (UTC) Received: from localhost.localdomain (ovpn-12-133.pek2.redhat.com [10.72.12.133]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4A6FB5C224; Tue, 2 Mar 2021 05:55:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1614664544; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=publ5REQehQtX9O1B36SCXaRF8mM0EtxrmugTAnNW/0=; b=e0Ezhyc/1A1wsYGm9193H0U2gymwqVIpgRFDxewA4pSX9VJ4H3YTjxxU3/uCUgqCM7qNEb 3AGlrkHcP6/nH9qsHQvL8xDEJS+GxuBvudw3/De4qkNZaZ4fr0bqbfWvXezLvYDLJcReNU ZUTnaP08XqlCBtgbuSMqoA2oph/DymM= X-MC-Unique: ReGjmWeZNUa7pjPBgF9W8A-1 From: Jason Wang To: qemu-devel@nongnu.org Subject: [PATCH V3 08/10] pcnet: switch to use qemu_receive_packet() for loopback Date: Tue, 2 Mar 2021 13:54:58 +0800 Message-Id: <20210302055500.51954-10-jasowang@redhat.com> In-Reply-To: <20210302055500.51954-1-jasowang@redhat.com> References: <20210302055500.51954-1-jasowang@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jasowang@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=jasowang@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alxndr@bu.edu, philmd@redhat.com, qemu-security@nongnu.org, ppandit@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) From: Alexander Bulekov This patch switches to use qemu_receive_packet() which can detect reentrancy and return early. Buglink: https://bugs.launchpad.net/qemu/+bug/1917085 Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- hw/net/pcnet.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/net/pcnet.c b/hw/net/pcnet.c index f3f18d8598..dcd3fc4948 100644 --- a/hw/net/pcnet.c +++ b/hw/net/pcnet.c @@ -1250,7 +1250,7 @@ txagain: if (BCR_SWSTYLE(s) =3D=3D 1) add_crc =3D !GET_FIELD(tmd.status, TMDS, NOFCS); s->looptest =3D add_crc ? PCNET_LOOPTEST_CRC : PCNET_LOOPTEST_= NOCRC; - pcnet_receive(qemu_get_queue(s->nic), s->buffer, s->xmit_pos); + qemu_receive_packet(qemu_get_queue(s->nic), s->buffer, s->xmit= _pos); s->looptest =3D 0; } else { if (s->nic) { --=20 2.24.3 (Apple Git-128)