From nobody Mon May 20 16:07:50 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1614615031; cv=none; d=zohomail.com; s=zohoarc; b=Yak2pr0TWcN/najBClbnW/4qL+fUYOHexygANvi/mXBnxYbMiU1nakiHshY7OjFV51Ex/VUIUqz17OC3bZMK7EyOMb9dDRTKS5waJGiKzqhpg/sXTXnhjtNh532s5JWN5Hsftcgf926ScTERNgdXgitPOCT2B/KIYTos1PVSsao= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1614615031; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=evKriQ3CQQOBSKYegnsDlyxLK0epVWNdop3+YaIAYVc=; b=XnIOXTFhPcckoMhwkaCnARE1BqlzddgMGNhiihCR1ME4mJtZ+ERRWbgC5mEO8BC1dLXqtgPRQkM1NcNCJDFheiH/FkmjphBNkzFeUi0iUh5BDArQPOhY7yxEybl72gx1+TqIjqhGtLXfVl4RxHhs+MRyctpNYdSiaukKwZai7h8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1614615031770890.9563008201451; Mon, 1 Mar 2021 08:10:31 -0800 (PST) Received: from localhost ([::1]:35480 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lGl7u-00080M-Ku for importer@patchew.org; Mon, 01 Mar 2021 11:10:30 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:43112) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lGl6a-00078a-LU for qemu-devel@nongnu.org; Mon, 01 Mar 2021 11:09:08 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:30661) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1lGl6X-0002NR-Pj for qemu-devel@nongnu.org; Mon, 01 Mar 2021 11:09:08 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-302-c8hve3BBPZClf8qL9ih1cg-1; Mon, 01 Mar 2021 11:09:03 -0500 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 73C351936B6C; Mon, 1 Mar 2021 16:09:02 +0000 (UTC) Received: from localhost (ovpn-115-54.ams2.redhat.com [10.36.115.54]) by smtp.corp.redhat.com (Postfix) with ESMTP id D37505D6CF; Mon, 1 Mar 2021 16:08:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1614614945; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=evKriQ3CQQOBSKYegnsDlyxLK0epVWNdop3+YaIAYVc=; b=gXkpxo2znuuGcQnXxjZn9mOOLR4L55fbHqtcB242Xf5NgGJS4TsxvZ8NoeqHKGvCGe4EhC cv+sbo4+/9cLRl2W5NpQ6Sh1Hsz5QDnhnqynFogJFs+sp9PaX9sn/dtPV79qzNLvE2F3Cq g39r779ARfCCm/daQZGZIHQt7KeRHrw= X-MC-Unique: c8hve3BBPZClf8qL9ih1cg-1 From: Stefan Hajnoczi To: qemu-devel@nongnu.org Subject: [PATCH] qemu-storage-daemon: add --pidfile option Date: Mon, 1 Mar 2021 16:08:57 +0000 Message-Id: <20210301160857.130478-1-stefanha@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=stefanha@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=63.128.21.124; envelope-from=stefanha@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -10 X-Spam_score: -1.1 X-Spam_bar: - X-Spam_report: (-1.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, MIME_BASE64_TEXT=1.741, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: afrosi@redhat.com, Kevin Wolf , Stefan Hajnoczi , qemu-block@nongnu.org, "Richard W . M . Jones" Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" Daemons often have a --pidfile option where the pid is written to a file so that scripts can stop the daemon by sending a signal. The pid file also acts as a lock to prevent multiple instances of the daemon from launching for a given pid file. QEMU, qemu-nbd, qemu-ga, virtiofsd, and qemu-pr-helper all support the --pidfile option. Add it to qemu-storage-daemon too. Reported-by: Richard W.M. Jones Signed-off-by: Stefan Hajnoczi --- docs/tools/qemu-storage-daemon.rst | 10 ++++++++++ storage-daemon/qemu-storage-daemon.c | 29 ++++++++++++++++++++++++++++ 2 files changed, 39 insertions(+) diff --git a/docs/tools/qemu-storage-daemon.rst b/docs/tools/qemu-storage-d= aemon.rst index f63627eaf6..8f4ab16ffc 100644 --- a/docs/tools/qemu-storage-daemon.rst +++ b/docs/tools/qemu-storage-daemon.rst @@ -118,6 +118,16 @@ Standard options: List object properties with ``,help``. See the :manpage:`qemu(1)` manual page for a description of the object properties. =20 +.. option:: --pidfile PATH + + is the path to a file where the daemon writes its pid. This allows scrip= ts to + stop the daemon by sending a signal:: + + $ kill -SIGTERM $(