From nobody Mon May 20 19:51:34 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1614597890; cv=none; d=zohomail.com; s=zohoarc; b=Jo5DDIqE40OheGZSC6Bxrl9XaopESQUM2uXlMy08+ad8NEgogyIFf4xtYqgWzjw+iRTOwsNu/A/2CNKm+SgIUVGHZRjJP0R3EATXhd6y6n+3EoDRw1PfPZ6RWUY31QVxD6Dt0W1rZijW6sNumOYQ02vv/VftP1vgLpAjOm4F3GQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1614597890; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=rz+BlZ1jCNDHOdzOOV3X5750OfsXEdMI5Nlv6I3/0MY=; b=c2Et3zydIeqJ7MstNm9LbAxb8qOnS5X5Q1+UHcNwNhYpFjrJzVlDV0uAb73jI2S+Ibnyx85w9rVUx0Lhb0Cz7IeYPP3DL8h8d8l0/X57WwAY7Gz3jA/A9vCfUWkDO8C7QFQ7/YH0lX9idq6hxCGy2egLvb15vwsNpaoeQBN66ng= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 161459789074756.702580074090406; Mon, 1 Mar 2021 03:24:50 -0800 (PST) Received: from localhost ([::1]:49834 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lGgfR-0006o8-NS for importer@patchew.org; Mon, 01 Mar 2021 06:24:49 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:55066) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lGgYP-0001fk-9Z for qemu-devel@nongnu.org; Mon, 01 Mar 2021 06:17:33 -0500 Received: from mail-wm1-x32b.google.com ([2a00:1450:4864:20::32b]:33622) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lGgYN-0002W1-Gu for qemu-devel@nongnu.org; Mon, 01 Mar 2021 06:17:32 -0500 Received: by mail-wm1-x32b.google.com with SMTP id y22-20020a1c4b160000b029010b2094f5deso2797818wma.0 for ; Mon, 01 Mar 2021 03:17:28 -0800 (PST) Received: from avogadro.redhat.com ([2001:b07:6468:f312:63a7:c72e:ea0e:6045]) by smtp.gmail.com with ESMTPSA id r9sm20551660wmq.26.2021.03.01.03.17.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Mar 2021 03:17:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=rz+BlZ1jCNDHOdzOOV3X5750OfsXEdMI5Nlv6I3/0MY=; b=SabdyuO7yLecf8pEtXhCAput0wiCA+GCMqYZRlDQXk7H2nERWdSri8WsVOceVSDJVv MVjTp8HDLIoAjS7r05eQHMbGhWbZC3iCajaqTAdKp5v+JyfqblA6kxhETot5iIeA5MyM 3GK4sio5OLJ2vGSCjvcjUyYw2tHVfYEY7pFf4UX1E1hEwBQb4RllvVFpNosx+67SoyM6 v6EEjUFGPsdNLlqJ5rZThKoadFuR4wXNhiSomW9kNB88E0dGf0BrpCgd+xodLPLU0x1C mbdX1TXmutJPF7CdyoJNfQc+0p7eHPrXSBwZDWkj3oKEtXhE0Q9cScEarbo1trOKSyD0 jgyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :mime-version:content-transfer-encoding; bh=rz+BlZ1jCNDHOdzOOV3X5750OfsXEdMI5Nlv6I3/0MY=; b=I3KhnvvdvJD+28oyZWY/W0KqWVc120ZMvsriIJlmSWC4cMunyHc/xwqtUH2rIijrTj Nz9T2P2MsCt92KDReYQjUfdcbtiTsNJ42eNeYmZnv+UJEBxR0QU8uKtaWRRivk0UIFXy Zo6S+9ZTgLy4hLFeSwO7LWEcG2ALjafA0yCZT0jsmR2mHZrv83rMmdAfdepW1p27nLeR Jd8fwMADlxSZ5ztkTR93wofQfY7xeELBsLc0jUP2XRnp1z5rIz5MoTIUDcNlYPgQXXFL 6kLhdBdiYFLHdPjrSdqhaCcBgnxg4Y9BCRooDgXneofoyDyZBcMIPNeLuODqRAetjxWr 2H7Q== X-Gm-Message-State: AOAM533gmdrRXec7iieZ/M4v4eWuqgapiDmqM13GmihfR+lV1JgAp8jr AKGBGDx1a4OB4R+x87z8lHSabiVeYOw= X-Google-Smtp-Source: ABdhPJzwCbZmOvbMQ5pW8J7JRyz1D7wUgR6Az395O3wPeuEn7+/yEA765rGXJiWUqSC4oDoAaOFpNw== X-Received: by 2002:a1c:7fc6:: with SMTP id a189mr15318334wmd.169.1614597447889; Mon, 01 Mar 2021 03:17:27 -0800 (PST) From: Paolo Bonzini To: qemu-devel@nongnu.org Subject: [PATCH] KVM: x86: deprecate -M kernel-irqchip=off except for -M isapc Date: Mon, 1 Mar 2021 12:17:25 +0100 Message-Id: <20210301111725.18434-2-pbonzini@redhat.com> X-Mailer: git-send-email 2.29.2 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::32b; envelope-from=paolo.bonzini@gmail.com; helo=mail-wm1-x32b.google.com X-Spam_score_int: -14 X-Spam_score: -1.5 X-Spam_bar: - X-Spam_report: (-1.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mlevitsk@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" The userspace local APIC is basically untested and does not support many features such as TSC deadline timer, x2APIC or PV spinlocks. On the other hand, the PIT and IOAPIC are okay as they are not tied to the processor and are tested with -M kernel-irqchip=3Dsplit. Therefore, deprecate the local APIC and, with it, limit -M kernel-irqchip=3Doff to the ISA PC machine type, which does not have a local APIC at all. Signed-off-by: Paolo Bonzini Reviewed-by: Maxim Levitsky --- docs/system/deprecated.rst | 7 +++++++ hw/intc/apic.c | 5 +++++ 2 files changed, 12 insertions(+) diff --git a/docs/system/deprecated.rst b/docs/system/deprecated.rst index 561c916da2..ae180dc887 100644 --- a/docs/system/deprecated.rst +++ b/docs/system/deprecated.rst @@ -153,6 +153,13 @@ The ``-writeconfig`` option is not able to serialize t= he entire contents of the QEMU command line. It is thus considered a failed experiment and deprecated, with no current replacement. =20 +Userspace local APIC with KVM (x86, since 6.0) +''''''''''''''''''''''''''''''''''''''''' + +Using ``-M kernel-irqchip=3Doff`` with x86 machine types that include a lo= cal +APIC is deprecated. The ``split`` setting is supported, as is using +``-M kernel-irqchip=3Doff`` with the ISA PC machine type. + QEMU Machine Protocol (QMP) commands ------------------------------------ =20 diff --git a/hw/intc/apic.c b/hw/intc/apic.c index 3ada22f427..7e9601b89d 100644 --- a/hw/intc/apic.c +++ b/hw/intc/apic.c @@ -875,6 +875,11 @@ static void apic_realize(DeviceState *dev, Error **err= p) return; } =20 + if (kvm_enabled()) { + warn_report("Userspace local APIC is deprecated for KVM."); + warn_report("Do not use kernel-irqchip except for the -M isapc mac= hine type."); + } + memory_region_init_io(&s->io_memory, OBJECT(s), &apic_io_ops, s, "apic= -msi", APIC_SPACE_SIZE); =20 --=20 2.29.2