From nobody Mon Feb 9 20:34:54 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1614587033; cv=none; d=zohomail.com; s=zohoarc; b=JGGKBjhK+cQkkf22h8QckRc/IlcL/ihkxPWbE/RvXeWrO8M+4dH6r9gk7cBp+CHL88dvUT4dlgBK+sMoR7HburxwbeRsPI/RNe39QBt5kYZVfCMlxbYOPEem9XuJCg6NWMrYm3S2BmuvG8Tqnys9xNsc0a/OiyCWREW4iMrTTPo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1614587033; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=MwsGEJtsaQeG2QmcTGA4Np1sQyVaJJc/zJVWrMXeyxQ=; b=a4o3Icv/6n7aGWmGwD6HX8hJd+OTq4l7iqkfZdaw7txaENBCqL/cN1bFiG4JXVJCgVX+ef6t8zTEzTHxpXHI8ATAECbl6B+PzuyoAZCJ1xtg27FIaSdbICE4peTtJ1JRzsiXacxLZB83wdcvY34Edrpp3WLFwAQZamd0odrVtfY= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1614587033897550.8747032823177; Mon, 1 Mar 2021 00:23:53 -0800 (PST) Received: from localhost ([::1]:55578 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lGdqK-0002sL-GO for importer@patchew.org; Mon, 01 Mar 2021 03:23:52 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:42840) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lGdok-0001ZE-0Z for qemu-devel@nongnu.org; Mon, 01 Mar 2021 03:22:14 -0500 Received: from szxga06-in.huawei.com ([45.249.212.32]:3053) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lGdog-0005Xz-F6 for qemu-devel@nongnu.org; Mon, 01 Mar 2021 03:22:13 -0500 Received: from DGGEMS405-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga06-in.huawei.com (SkyGuard) with ESMTP id 4DptW10gDVzjSlX; Mon, 1 Mar 2021 16:20:45 +0800 (CST) Received: from DESKTOP-6NKE0BC.china.huawei.com (10.174.185.210) by DGGEMS405-HUB.china.huawei.com (10.3.19.205) with Microsoft SMTP Server id 14.3.498.0; Mon, 1 Mar 2021 16:21:57 +0800 From: Kunkun Jiang To: David Edmondson , Juan Quintela , "Dr . David Alan Gilbert" , "open list:All patches CC here" Subject: [PATCH v2 2/3] migration/ram: Modify ram_save_host_page() to match the comment Date: Mon, 1 Mar 2021 16:21:31 +0800 Message-ID: <20210301082132.1107-3-jiangkunkun@huawei.com> X-Mailer: git-send-email 2.26.2.windows.1 In-Reply-To: <20210301082132.1107-1-jiangkunkun@huawei.com> References: <20210301082132.1107-1-jiangkunkun@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.174.185.210] X-CFilter-Loop: Reflected Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=45.249.212.32; envelope-from=jiangkunkun@huawei.com; helo=szxga06-in.huawei.com X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Zenghui Yu , wanghaibin.wang@huawei.com, Keqian Zhu Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" According to the comment, when the host page is a huge page, the migration_rate_limit() should be executed. If not, this function can be omitted to save time. Signed-off-by: Keqian Zhu Signed-off-by: Kunkun Jiang Reviewed-by: David Edmondson --- migration/ram.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/migration/ram.c b/migration/ram.c index 24967cb970..3a9115b6dc 100644 --- a/migration/ram.c +++ b/migration/ram.c @@ -2014,7 +2014,9 @@ static int ram_save_host_page(RAMState *rs, PageSearc= hStatus *pss, pages +=3D tmppages; pss->page++; /* Allow rate limiting to happen in the middle of huge pages */ - migration_rate_limit(); + if (pagesize_bits > 1) { + migration_rate_limit(); + } } while ((pss->page & (pagesize_bits - 1)) && offset_in_ramblock(pss->block, ((ram_addr_t)pss->page) << TARGET_PAGE_BIT= S)); --=20 2.23.0