From nobody Tue Feb 10 06:25:01 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1614362054; cv=none; d=zohomail.com; s=zohoarc; b=i4joe79niuSg8rwuFj8etgZl8CZ87C5aL1nFpOGiwzOuprxDEzJSdLI3QV7Nfl6V3hPTAQMzeQgpWIbhyICrCmM5DBqo3Sf0CqDjVuoR7sMQPRXCBJ+rDBn+LLlpIFcecrTdmPfRx5NEasZnxmLxTOWuK7l4f86OYwk20AjK3Zo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1614362054; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=5B5AlfiJHc8St6uU91vEGKVnXmh0y17asi7Yk1ujxhA=; b=YHnLR7K+XogMR7H+lthvrI2tGQUz3ZDyFQb3FsFAwu7LmagE6SkEKcnyJtepYTqiAWsjmfynAelfw0LrY634lnNSGQ8lBb0eCTa3YGpDh5uJjK2ltemYrMHt0HPytgga59o+BgAG/NM3e7JLM0NbKS/V6Tq0Z3Z4Caa5nCofiBw= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1614362054591780.5366031664489; Fri, 26 Feb 2021 09:54:14 -0800 (PST) Received: from localhost ([::1]:55382 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lFhJc-00066d-JB for importer@patchew.org; Fri, 26 Feb 2021 12:54:12 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:59788) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lFhHI-0004H1-Uo for qemu-devel@nongnu.org; Fri, 26 Feb 2021 12:51:49 -0500 Received: from mx2.suse.de ([195.135.220.15]:49632) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lFhHG-00011u-Lz for qemu-devel@nongnu.org; Fri, 26 Feb 2021 12:51:48 -0500 Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 3FA86AFEA; Fri, 26 Feb 2021 17:51:45 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de From: Claudio Fontana To: Paolo Bonzini , Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Eduardo Habkost , Peter Maydell , =?UTF-8?q?Alex=20Benn=C3=A9e?= Subject: [PATCH v25 01/20] target/i386: Rename helper_fldt, helper_fstt Date: Fri, 26 Feb 2021 18:51:24 +0100 Message-Id: <20210226175143.22388-2-cfontana@suse.de> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210226175143.22388-1-cfontana@suse.de> References: <20210226175143.22388-1-cfontana@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=195.135.220.15; envelope-from=cfontana@suse.de; helo=mx2.suse.de X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Vivier , Thomas Huth , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org, Roman Bolshakov , Claudio Fontana Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" From: Richard Henderson Change the prefix from "helper" to "do". The former should be reserved for those functions that are called from TCG; the latter is in use within the file already for those functions that are called from the helper functions, adding a "retaddr" argument. Signed-off-by: Richard Henderson Reviewed-by: Claudio Fontana Tested-by: Claudio Fontana Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- target/i386/tcg/fpu_helper.c | 19 +++++++++---------- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/target/i386/tcg/fpu_helper.c b/target/i386/tcg/fpu_helper.c index 60ed93520a..3d9b192901 100644 --- a/target/i386/tcg/fpu_helper.c +++ b/target/i386/tcg/fpu_helper.c @@ -117,8 +117,7 @@ static inline void fpop(CPUX86State *env) env->fpstt =3D (env->fpstt + 1) & 7; } =20 -static inline floatx80 helper_fldt(CPUX86State *env, target_ulong ptr, - uintptr_t retaddr) +static floatx80 do_fldt(CPUX86State *env, target_ulong ptr, uintptr_t reta= ddr) { CPU_LDoubleU temp; =20 @@ -127,8 +126,8 @@ static inline floatx80 helper_fldt(CPUX86State *env, ta= rget_ulong ptr, return temp.d; } =20 -static inline void helper_fstt(CPUX86State *env, floatx80 f, target_ulong = ptr, - uintptr_t retaddr) +static void do_fstt(CPUX86State *env, floatx80 f, target_ulong ptr, + uintptr_t retaddr) { CPU_LDoubleU temp; =20 @@ -405,14 +404,14 @@ void helper_fldt_ST0(CPUX86State *env, target_ulong p= tr) int new_fpstt; =20 new_fpstt =3D (env->fpstt - 1) & 7; - env->fpregs[new_fpstt].d =3D helper_fldt(env, ptr, GETPC()); + env->fpregs[new_fpstt].d =3D do_fldt(env, ptr, GETPC()); env->fpstt =3D new_fpstt; env->fptags[new_fpstt] =3D 0; /* validate stack entry */ } =20 void helper_fstt_ST0(CPUX86State *env, target_ulong ptr) { - helper_fstt(env, ST0, ptr, GETPC()); + do_fstt(env, ST0, ptr, GETPC()); } =20 void helper_fpush(CPUX86State *env) @@ -2468,7 +2467,7 @@ void helper_fsave(CPUX86State *env, target_ulong ptr,= int data32) ptr +=3D (14 << data32); for (i =3D 0; i < 8; i++) { tmp =3D ST(i); - helper_fstt(env, tmp, ptr, GETPC()); + do_fstt(env, tmp, ptr, GETPC()); ptr +=3D 10; } =20 @@ -2495,7 +2494,7 @@ void helper_frstor(CPUX86State *env, target_ulong ptr= , int data32) ptr +=3D (14 << data32); =20 for (i =3D 0; i < 8; i++) { - tmp =3D helper_fldt(env, ptr, GETPC()); + tmp =3D do_fldt(env, ptr, GETPC()); ST(i) =3D tmp; ptr +=3D 10; } @@ -2539,7 +2538,7 @@ static void do_xsave_fpu(CPUX86State *env, target_ulo= ng ptr, uintptr_t ra) addr =3D ptr + XO(legacy.fpregs); for (i =3D 0; i < 8; i++) { floatx80 tmp =3D ST(i); - helper_fstt(env, tmp, addr, ra); + do_fstt(env, tmp, addr, ra); addr +=3D 16; } } @@ -2703,7 +2702,7 @@ static void do_xrstor_fpu(CPUX86State *env, target_ul= ong ptr, uintptr_t ra) =20 addr =3D ptr + XO(legacy.fpregs); for (i =3D 0; i < 8; i++) { - floatx80 tmp =3D helper_fldt(env, addr, ra); + floatx80 tmp =3D do_fldt(env, addr, ra); ST(i) =3D tmp; addr +=3D 16; } --=20 2.26.2