From nobody Tue Feb 10 02:54:42 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.218.47 as permitted sender) client-ip=209.85.218.47; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-ej1-f47.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.218.47 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com; dmarc=fail(p=none dis=none) header.from=amsat.org ARC-Seal: i=1; a=rsa-sha256; t=1614331911; cv=none; d=zohomail.com; s=zohoarc; b=PPVjE8f24JdnptGOGNUKHJS7sNO1yXasaIMDddjYnddgKuKAZoJkGSz7cqkCpf2eE52OCAMd6ccNoVkj57WSyhB+YMbpBi2+4jDJGzjqMe/xaL8gqmAWaKRg1tfNOpdXI17JHKpGh7SDhTJ7NI80u5KbUhvWP80q7IWypZW7aiw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1614331911; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=VyX97rnCu0DJ6j05hLetfQh2Gc//wDyTV1nAcRxoU6Q=; b=mEMZx3RQiK9iHS/PfWVxGqVjIIj1xjHE2tGWZt0Klg8CYj9mKCB6kdoQJnWl9DtQzGQdjugAeyjIlaThViwnIroB1gtFaIYDEs7j/kRYNFBHaHsHmarXzqrBgeAUAaVXVKbgbrKa9zug8CALxTDHr5c7TJDHz2lpcwx69OlgaIA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.218.47 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail-ej1-f47.google.com (mail-ej1-f47.google.com [209.85.218.47]) by mx.zohomail.com with SMTPS id 1614331911611675.7599246437255; Fri, 26 Feb 2021 01:31:51 -0800 (PST) Received: by mail-ej1-f47.google.com with SMTP id b21so2655371eja.4 for ; Fri, 26 Feb 2021 01:31:51 -0800 (PST) Return-Path: Return-Path: Received: from x1w.redhat.com (68.red-83-57-175.dynamicip.rima-tde.net. [83.57.175.68]) by smtp.gmail.com with ESMTPSA id k9sm5326380edo.30.2021.02.26.01.31.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Feb 2021 01:31:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=VyX97rnCu0DJ6j05hLetfQh2Gc//wDyTV1nAcRxoU6Q=; b=nvYi2TIVFQJdHUNZl3bx9cYKxGRQpAtMacfJMbx0K3++9MRnaEsu9HOatEc0iJTjYe 1sQNJvIyiPQLAcjmZ9WLyCCjrbUtEHt3VJtaLgxKBBqov+Ttt+n44iFvwd9rsHsYHW4g cf7bVt+WVoQFt7HkrIa3cXgEMGLA1hxx/KNlzBVKCQGKjf7aiIquFpUCRPkUgFrMq7t/ vmzX0qqoUn6QMLSNJzbg1g39ZqHXbw+2fWpz4XQLfZcIhwP0yhiYUB2Ria5ttCBxeqjk 4UZz/T1jsA2UO5XzyUiqrJIf8LjRdAguY3+enk5I7s+h9gUR1/J1e0mm4HWpyvNbMvoE WwmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=VyX97rnCu0DJ6j05hLetfQh2Gc//wDyTV1nAcRxoU6Q=; b=H6ewtqRyCZDDF+iJEhpVkwDeQNeHb4zd6xyp7ukUJW0gjtr5fawOykPW+yzUfNA7Ei KL9s+ww2iiWA2TwuUr0/MNHe4dsQi5kQkBCgiOnzM0AQBKVEKKUGyIhdRl8Aq2h+ujmE QYulHxMkcgY8+6sUdcgWxHPr2Tc3JYBUWFJJLOiRnuqJqXeFH957UN42dz4VT/VRjk+4 hZaITQM0NjO03zvxkm4MCjke11ySpNUzd+LZyWT0sO/UGLYCQOuasVEZ/AJ5eR06KKEj UQtbALVPrIqk7wMpp1h+t0ie/CmFs3n06L9mrE9Seb1eZ3BWCTQCM/myhspn2yuoFOUF 546Q== X-Gm-Message-State: AOAM532DZsuhI5B2SaQx4FmyQ1CiQhNAgbLDSezxQsfvuX+FSUJLJyb0 FUp+BMY+nVQeIal1C8gkwt8= X-Google-Smtp-Source: ABdhPJyOJSaulBdf8jnnCM8AmoBgqkxCx5hb3Oe9Es4BKldDNTVB3c+S1i92nFSs0tlvav8ZFWsWZA== X-Received: by 2002:a17:906:c82e:: with SMTP id dd14mr2306167ejb.102.1614331909952; Fri, 26 Feb 2021 01:31:49 -0800 (PST) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Aleksandar Rikalo , Aurelien Jarno , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Jiaxun Yang , Richard Henderson Subject: [PATCH v5 07/13] target/mips: Use OPC_MUL instead of OPC__MXU_MUL Date: Fri, 26 Feb 2021 10:31:04 +0100 Message-Id: <20210226093111.3865906-8-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210226093111.3865906-1-f4bug@amsat.org> References: <20210226093111.3865906-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) We already have a macro and definition to extract / check the Special2 MUL opcode. Use it instead of the unnecessary OPC__MXU_MUL macro. Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- target/mips/translate.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/target/mips/translate.c b/target/mips/translate.c index 9e875fa4a25..2d8ddbad112 100644 --- a/target/mips/translate.c +++ b/target/mips/translate.c @@ -1464,7 +1464,6 @@ enum { */ =20 enum { - OPC__MXU_MUL =3D 0x02, OPC_MXU__POOL00 =3D 0x03, OPC_MXU_D16MUL =3D 0x08, OPC_MXU_D16MAC =3D 0x0A, @@ -25784,7 +25783,7 @@ static void decode_opc_mxu(DisasContext *ctx, uint3= 2_t insn) { uint32_t opcode =3D extract32(insn, 0, 6); =20 - if (opcode =3D=3D OPC__MXU_MUL) { + if (MASK_SPECIAL2(insn) =3D=3D OPC_MUL) { uint32_t rs, rt, rd, op1; =20 rs =3D extract32(insn, 21, 5); --=20 2.26.2