From nobody Wed Nov 19 04:36:59 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1614310879; cv=none; d=zohomail.com; s=zohoarc; b=J/isPQVYXKS1HDd1rSKOg2UnlyJrq8pyYOSrrRG3C/a05deOQBSfoQejVDY33UCzCubK/moJHFz7U3JJXlU4VbIo9nmDW/aPVDWaR9+6sNlyzd1tyfgVIfiL1mkbiJ/g3fsg+r8eEYI+k6e8AEeptX6duniEWvw1uWVHBvV9gXU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1614310879; h=Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:Message-ID:References:Sender:Subject:To; bh=spudy6A2kz/IuNKk8c6Qdt4r6xC5abqAUDZa6d/gXhc=; b=NmYSnmWwR6vJFFlhAOr3jErGTqn95QVwdzYiTZRTbPPKcmsF8SNGqPuaIHY0SZIW4v3PYXEqZyq7mHzMTiyJUL/5e11j47rMGU0kIBJKTlma+0EgqvqW3yg3DCtJeE5iAbeTAnOzRgrJdddzbN7KY529hnReC1i4Yxxc+D5nvPc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1614310879518710.4423245043267; Thu, 25 Feb 2021 19:41:19 -0800 (PST) Received: from localhost ([::1]:38234 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lFU0E-000296-EE for importer@patchew.org; Thu, 25 Feb 2021 22:41:18 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:34648) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lFThe-0000PA-Fk for qemu-devel@nongnu.org; Thu, 25 Feb 2021 22:22:07 -0500 Received: from mail-pj1-x102f.google.com ([2607:f8b0:4864:20::102f]:54747) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lFThd-0001dH-1N for qemu-devel@nongnu.org; Thu, 25 Feb 2021 22:22:06 -0500 Received: by mail-pj1-x102f.google.com with SMTP id i14so3563301pjz.4 for ; Thu, 25 Feb 2021 19:22:04 -0800 (PST) Received: from frankchang-ThinkPad-T490.internal.sifive.com (114-34-229-221.HINET-IP.hinet.net. [114.34.229.221]) by smtp.gmail.com with ESMTPSA id p11sm7083709pjb.31.2021.02.25.19.22.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Feb 2021 19:22:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=spudy6A2kz/IuNKk8c6Qdt4r6xC5abqAUDZa6d/gXhc=; b=WHeegHXPpjEgRX5R0+siIPKLMT7Qax/SuhM7nShWA7LE1K9tQnqq+mJQY4NY6y77Oh 2CdTBwUI5ZrWuoPRjPurOYCKxPChwTDwOGhvLkV0v5Tv16nKlDaPgL7nLwnXgxiRW04R eLlTkddTDsRD1RtbAODwVQ912UcA503CZ1fQMG2OUZLrg9FP8+g4hX1espqNT2QBnkjw oJeE3trJ8ZSemCX8ioxNsYNN31SVWfKkdYYnsr9v5CcX2mRbJaMCE4dymppqeBUTMoBV szqc56xdZcIDdPEqhGSLLHVKw79YsstJMy39F4Zn4jgONy+uH89T2XZXvb8+WCrzDSK6 l2eQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=spudy6A2kz/IuNKk8c6Qdt4r6xC5abqAUDZa6d/gXhc=; b=cxAzgbajmRn+MMYs2mbJCGpHGVbEr4kVbeZYnXO0cxBYPoVieQohKagwPCCBYRjDYV w6WChzj/ezYYoE4PADO0Y9vH7I26hut+FEg6nhO30WDyixwf1c6UJjL7JqOOP0DBEKXO zZ53fXyLOZbxeEbppobDBtz5M6PTojuGG5Q+EFFJd+400IP4OU+yRsd3H3IjXKS202Pk wONYpEFpkjuqxwzoZNOHkfPVDTS/iTXFRK0l0siEz+rCiS48RV77uklHXDvxg2KmdUZZ 2NPXxkNOiakkQwU0HBmot6JWPqx5PdZvjlzOiyuYj++Kuzz5FnpQKxbREBEkT2AWOK0W 1DWg== X-Gm-Message-State: AOAM531YW/a/UphnbW+dK5SXjv/y2gi8d/Z7IQ+F/nlvPKpb9byyU1l5 pBmySYmuQRXSM6BWN1vf/Zjox5VBMnJ8aQ== X-Google-Smtp-Source: ABdhPJwl+M9SZPejYoMu/tLp2m4alR5mk3DIduMgDHSc4xkHLfp2g/D++eXrlr5eY8fG79vrChlA4A== X-Received: by 2002:a17:902:9341:b029:e1:7b4e:57a8 with SMTP id g1-20020a1709029341b02900e17b4e57a8mr1224058plp.34.1614309723597; Thu, 25 Feb 2021 19:22:03 -0800 (PST) From: frank.chang@sifive.com To: qemu-devel@nongnu.org, qemu-riscv@nongnu.org Subject: [PATCH v7 30/75] target/riscv: rvv-1.0: set-X-first mask bit instructions Date: Fri, 26 Feb 2021 11:18:14 +0800 Message-Id: <20210226031902.23656-31-frank.chang@sifive.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20210226031902.23656-1-frank.chang@sifive.com> References: <20210226031902.23656-1-frank.chang@sifive.com> Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::102f; envelope-from=frank.chang@sifive.com; helo=mail-pj1-x102f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sagar Karandikar , Frank Chang , Bastian Koppelmann , Richard Henderson , Alistair Francis , Palmer Dabbelt , LIU Zhiwei Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" From: Frank Chang Signed-off-by: Frank Chang Reviewed-by: Richard Henderson --- target/riscv/insn32.decode | 6 +++--- target/riscv/insn_trans/trans_rvv.c.inc | 5 ++++- target/riscv/vector_helper.c | 4 ---- 3 files changed, 7 insertions(+), 8 deletions(-) diff --git a/target/riscv/insn32.decode b/target/riscv/insn32.decode index 0b53ce432c1..6b3caef1721 100644 --- a/target/riscv/insn32.decode +++ b/target/riscv/insn32.decode @@ -604,9 +604,9 @@ vmornot_mm 011100 - ..... ..... 010 ..... 1010111 = @r vmxnor_mm 011111 - ..... ..... 010 ..... 1010111 @r vpopc_m 010000 . ..... 10000 010 ..... 1010111 @r2_vm vfirst_m 010000 . ..... 10001 010 ..... 1010111 @r2_vm -vmsbf_m 010110 . ..... 00001 010 ..... 1010111 @r2_vm -vmsif_m 010110 . ..... 00011 010 ..... 1010111 @r2_vm -vmsof_m 010110 . ..... 00010 010 ..... 1010111 @r2_vm +vmsbf_m 010100 . ..... 00001 010 ..... 1010111 @r2_vm +vmsif_m 010100 . ..... 00011 010 ..... 1010111 @r2_vm +vmsof_m 010100 . ..... 00010 010 ..... 1010111 @r2_vm viota_m 010110 . ..... 10000 010 ..... 1010111 @r2_vm vid_v 010110 . 00000 10001 010 ..... 1010111 @r1_vm vext_x_v 001100 1 ..... ..... 010 ..... 1010111 @r diff --git a/target/riscv/insn_trans/trans_rvv.c.inc b/target/riscv/insn_tr= ans/trans_rvv.c.inc index 97ad16f2b21..5b229d55307 100644 --- a/target/riscv/insn_trans/trans_rvv.c.inc +++ b/target/riscv/insn_trans/trans_rvv.c.inc @@ -2964,7 +2964,10 @@ static bool trans_vfirst_m(DisasContext *s, arg_rmr = *a) #define GEN_M_TRANS(NAME) \ static bool trans_##NAME(DisasContext *s, arg_rmr *a) \ { \ - if (vext_check_isa_ill(s)) { \ + if (require_rvv(s) && \ + vext_check_isa_ill(s) && \ + require_vm(a->vm, a->rd) && \ + (a->rd !=3D a->rs2)) { \ uint32_t data =3D 0; \ gen_helper_gvec_3_ptr *fn =3D gen_helper_##NAME; \ TCGLabel *over =3D gen_new_label(); \ diff --git a/target/riscv/vector_helper.c b/target/riscv/vector_helper.c index ecc9be77335..8ccf538141c 100644 --- a/target/riscv/vector_helper.c +++ b/target/riscv/vector_helper.c @@ -4466,7 +4466,6 @@ enum set_mask_type { static void vmsetm(void *vd, void *v0, void *vs2, CPURISCVState *env, uint32_t desc, enum set_mask_type type) { - uint32_t vlmax =3D env_archcpu(env)->cfg.vlen; uint32_t vm =3D vext_vm(desc); uint32_t vl =3D env->vl; int i; @@ -4496,9 +4495,6 @@ static void vmsetm(void *vd, void *v0, void *vs2, CPU= RISCVState *env, } } } - for (; i < vlmax; i++) { - vext_set_elem_mask(vd, i, 0); - } } =20 void HELPER(vmsbf_m)(void *vd, void *v0, void *vs2, CPURISCVState *env, --=20 2.17.1