From nobody Wed Nov 19 03:02:57 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.128.49 as permitted sender) client-ip=209.85.128.49; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-f49.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.49 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1614193083; cv=none; d=zohomail.com; s=zohoarc; b=BK2vS/aSppdpKDRNLZftjseYCV4IURda71mhmtNowSzcQ+56Wv31teVQ88r0a/cz459o6Dqq1Q239NB+d8Utu40RnV9L9IMFyloS8j5sjuzFj4d5EO3O1LPrqcKIHBNkorA4CMwPxpkypObRjMC+dOUDr949kIJ9kdZ6jbOXPA0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1614193083; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=KUBPOuShU9WosAKj4v1xzYezj3Sf3FaFiGpD3EYrTQc=; b=A50oXbCf+3E43d3AEbfJOdYQPQBkBPjT9NbL16qEVgQQH5XvUIqdOxZshyrNulcPLowZkfUFxsI7bRlCUEOoIDGiq8eKQn9+iWHF774Fqrozp1i+Sf2Ngxyed4UwneVt+w9zhE4z/SakS8+iLUKY4nwIyfYmGk6EOcC2shGTYFQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.49 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) by mx.zohomail.com with SMTPS id 161419308346640.322535505816745; Wed, 24 Feb 2021 10:58:03 -0800 (PST) Received: by mail-wm1-f49.google.com with SMTP id p3so2691334wmc.2 for ; Wed, 24 Feb 2021 10:58:02 -0800 (PST) Return-Path: Return-Path: Received: from x1w.redhat.com (68.red-83-57-175.dynamicip.rima-tde.net. [83.57.175.68]) by smtp.gmail.com with ESMTPSA id u8sm4733446wmb.36.2021.02.24.10.58.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Feb 2021 10:58:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=KUBPOuShU9WosAKj4v1xzYezj3Sf3FaFiGpD3EYrTQc=; b=gInBO7nOSVUd7lRBxOLMuybQZnTeve13QMrYYa3Fnkw5wjE7e84f5OQhspMzA1lJAq UHrbtG02+3wDuVshVMS4xYPfm/cWZEwSdP2RxXtutK0RQWsG99oAHP96BhvRJoCZuNXf eHMv+/r7ssrbSbjKGgp4QyLasxq6s8+R/UaopltpQ5AogT6TkcwCkfrSTOfA9SKIK62q OvwB/Sk8HOiQakA+voA1XmapN24euOq5fj+fz50BhQbIK6mr3K1M22VKwX1slTSJHeza A5/vcxmJtMDExBRJdSf8pd6Jjul5aYTulNJ7LigMQghHLqS+wOdEZ8mn6Aq4qBsMzU8q QtTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=KUBPOuShU9WosAKj4v1xzYezj3Sf3FaFiGpD3EYrTQc=; b=TTLL29p6gCxp+LIJwwmC766VBL+mr4VLtjiJEz7JxC+m5MVy1VY0r1+NU5hqkbM3WM d0RnQKhtqf7ZyKHjxCl6NgcQO1nY6cz+PgfWUDTuIdXX/KQAoSE701tqfoR37/wXJIpm TSHk+AYqZL1v1Drx5pqQDV1q9/5KIyLyApn9PCYNWVXmck/xfULanZ+Y0oXPUq0ye1wf WoOYM5jVTPhvPmiJ57GobI8dHotEcKphC9TxDgMQeSb1A8ZNG/iTd/wsxbwLpU0xhvV2 N9wIflRtCA7hTmn8txx5vFCY5ISXzgiGtzfKg90GpLNbCmc85C6RfL0Ft5SgYlnquq0J YbPg== X-Gm-Message-State: AOAM5314SaKfww3m6h1N+quWt59OxO18OHP3B/2PKUr5PqwlEJx4co8a aqv2GQ8th6bqdLi/DKvDLzE= X-Google-Smtp-Source: ABdhPJzIiM3LzqJcwuFI7YDHvFbZ0OLZDkSXv5lQOFL30uzV3U7+FKv36HhckwfolCsFT0vKernhhw== X-Received: by 2002:a7b:ca47:: with SMTP id m7mr5234274wml.112.1614193081553; Wed, 24 Feb 2021 10:58:01 -0800 (PST) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Craig Janeczek , Jiaxun Yang , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Aleksandar Rikalo , Richard Henderson , Aurelien Jarno Subject: [PATCH v4 08/12] target/mips: Move MUL opcode check from decode_mxu() to decode_legacy() Date: Wed, 24 Feb 2021 19:57:02 +0100 Message-Id: <20210224185706.3293058-9-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210224185706.3293058-1-f4bug@amsat.org> References: <20210224185706.3293058-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) Move the check for MUL opcode from decode_opc_mxu() callee to decode_opc_legacy() caller, so we can simplify the ifdef'ry and elide the call in few commits. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- target/mips/translate.c | 19 +++++-------------- 1 file changed, 5 insertions(+), 14 deletions(-) diff --git a/target/mips/translate.c b/target/mips/translate.c index 2d8ddbad112..df4868ebb95 100644 --- a/target/mips/translate.c +++ b/target/mips/translate.c @@ -25783,19 +25783,6 @@ static void decode_opc_mxu(DisasContext *ctx, uint= 32_t insn) { uint32_t opcode =3D extract32(insn, 0, 6); =20 - if (MASK_SPECIAL2(insn) =3D=3D OPC_MUL) { - uint32_t rs, rt, rd, op1; - - rs =3D extract32(insn, 21, 5); - rt =3D extract32(insn, 16, 5); - rd =3D extract32(insn, 11, 5); - op1 =3D MASK_SPECIAL2(insn); - - gen_arith(ctx, op1, rd, rs, rt); - - return; - } - if (opcode =3D=3D OPC_MXU_S32M2I) { gen_mxu_s32m2i(ctx); return; @@ -26994,7 +26981,11 @@ static bool decode_opc_legacy(CPUMIPSState *env, D= isasContext *ctx) #endif #if !defined(TARGET_MIPS64) if (ctx->insn_flags & ASE_MXU) { - decode_opc_mxu(ctx, ctx->opcode); + if (MASK_SPECIAL2(ctx->opcode) =3D=3D OPC_MUL) { + gen_arith(ctx, OPC_MUL, rd, rs, rt); + } else { + decode_opc_mxu(ctx, ctx->opcode); + } break; } #endif --=20 2.26.2