From nobody Wed Nov 19 03:02:58 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.128.52 as permitted sender) client-ip=209.85.128.52; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-f52.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.52 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1614193078; cv=none; d=zohomail.com; s=zohoarc; b=ajhK2yPZaPJA+hABXAUVRMIVNTcXJrgtON8N9Gt7n3N2Odzzd+HVj0BjBhGhvmuQTYfex5DxELkhlw6PVw8/w/DrJjnqnispVWvY/DxNdySVvN9bStYjqQI+lpeGpKpnEn0cl7esEKw2qTAv9Mz6TFSBjGbSaiT15eDdT1Yh424= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1614193078; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=VyX97rnCu0DJ6j05hLetfQh2Gc//wDyTV1nAcRxoU6Q=; b=MRzgPBiDstLfbY7YDXJ4qdPokOdphaKmleTIqLgZ46UJlWlQmoyUlB4399njRlNYHPx8Ww0MQP801oA43p7j5oOBwRgfAczPUgVkk3JuoERur4prEeW9vgFDuEDMbb2pzaMHeklqYyEvjaaacVjALFrgXXnOafAUZoUs3z3PrHY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.52 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) by mx.zohomail.com with SMTPS id 1614193078556154.29689602748692; Wed, 24 Feb 2021 10:57:58 -0800 (PST) Received: by mail-wm1-f52.google.com with SMTP id u187so768332wmg.4 for ; Wed, 24 Feb 2021 10:57:57 -0800 (PST) Return-Path: Return-Path: Received: from x1w.redhat.com (68.red-83-57-175.dynamicip.rima-tde.net. [83.57.175.68]) by smtp.gmail.com with ESMTPSA id 12sm4250050wmw.43.2021.02.24.10.57.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Feb 2021 10:57:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=VyX97rnCu0DJ6j05hLetfQh2Gc//wDyTV1nAcRxoU6Q=; b=TR1m8alkXSSWuh0ue70I80mRhl0mOiWP6wtnUgzIQJKi+vFbAyMQJccpHNfaBT9gf5 LxyxWthTKkhMKSo0fSTFOxONFUjyHcX2AKOTAQgW+Q7dGEzkG+ZHNGpUchHfgiDIiDTh B7yXxxrtSqFN54KfdwW5TNLiscRJZ0gVqc6HQoLP7sdqAHJVRvlKxIAxD3kIIJGUN9Ik +/F4bLr8z7ILPlo+VQeNe1HI6Pk1aneqi8n5s7CZMA4fX0p0Nu6Dpvtanx2f0EjadSq7 Ap0mBpKBXifpTE/XLoDSgczAfWMli5blK1TF5n9opRBw9f2ga2CWBRgGh9B4EWWZsd5b Vjxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=VyX97rnCu0DJ6j05hLetfQh2Gc//wDyTV1nAcRxoU6Q=; b=OXMcA5r6RLajxbzqXEI5vC6uFrpLvCjhrBiAG3+KTnv2kxaB91jKI1wl2Qpri5Ka+1 t5NJzKHPV3NqCGyB5Bldx2ZR/4UNoxrtS+mn8+5P9ONsCQn5dGGuScRJSCc0aPh9NI5Q k5yhE5WNqp9lEl/upv+wCFja7gB0Qzf6nZdjX6DJ+UmOqYork4c5cIqcDRCIiTvJTzlG GEWo1Eu+TNkXC8Gxkq+B/dHi6bVYQ+MOtjW2JqVT45l0udZ2nk2lgk9WodEubb6ZeBZ4 IM9mNfJkTfGT5NyA/jQ9NCkbQszAAzaeimyM6Nr/vktEESAsOKryIdCOwZefWmPwGzzt pkPQ== X-Gm-Message-State: AOAM530XrdnYqNzdfjJ4dDoEYqjG/gt6vbbKCJyLvH7+Xd329SrdQrjM tLmtCPj3PY1qSYJ/yVlMSsA= X-Google-Smtp-Source: ABdhPJzN3WamSth++Vw6oDKZYpgaGMkGaL8Xt/2+n3dH5aN/TmWLoKHgrURHrOxioxebn4qxfeMqDQ== X-Received: by 2002:a1c:2b05:: with SMTP id r5mr4980910wmr.179.1614193076703; Wed, 24 Feb 2021 10:57:56 -0800 (PST) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Craig Janeczek , Jiaxun Yang , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Aleksandar Rikalo , Richard Henderson , Aurelien Jarno Subject: [PATCH v4 07/12] target/mips: Use OPC_MUL instead of OPC__MXU_MUL Date: Wed, 24 Feb 2021 19:57:01 +0100 Message-Id: <20210224185706.3293058-8-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210224185706.3293058-1-f4bug@amsat.org> References: <20210224185706.3293058-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) We already have a macro and definition to extract / check the Special2 MUL opcode. Use it instead of the unnecessary OPC__MXU_MUL macro. Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- target/mips/translate.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/target/mips/translate.c b/target/mips/translate.c index 9e875fa4a25..2d8ddbad112 100644 --- a/target/mips/translate.c +++ b/target/mips/translate.c @@ -1464,7 +1464,6 @@ enum { */ =20 enum { - OPC__MXU_MUL =3D 0x02, OPC_MXU__POOL00 =3D 0x03, OPC_MXU_D16MUL =3D 0x08, OPC_MXU_D16MAC =3D 0x0A, @@ -25784,7 +25783,7 @@ static void decode_opc_mxu(DisasContext *ctx, uint3= 2_t insn) { uint32_t opcode =3D extract32(insn, 0, 6); =20 - if (opcode =3D=3D OPC__MXU_MUL) { + if (MASK_SPECIAL2(insn) =3D=3D OPC_MUL) { uint32_t rs, rt, rd, op1; =20 rs =3D extract32(insn, 21, 5); --=20 2.26.2