From nobody Wed Nov 19 03:02:57 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.43 as permitted sender) client-ip=209.85.221.43; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f43.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.43 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1614193093; cv=none; d=zohomail.com; s=zohoarc; b=DjqteGKhPA1G0rSSVzM1AYY1dlr/vIUwhvJHvyCgvL6kdnTShSi/oAhGI7q/spsHgzjCe7tGimIk2jBTRqog5kaV8S4NQCVeAcl0B9r80f4bMWRdhGmtRKb1iHFpyVfq9zj/BJaFn3lLAK9TniH8I24QqTEnDJJX7Zf+rVZmLp4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1614193093; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=VfTlNObaYV/Nh4K89JsqHN+ODkOHUE/vR/suP3n68ro=; b=JrbbLdDUXZc/JGXlq1QKaORGIFmAwbPCVuXzMrDz5ImZeGIochJrmwPhto6w+iLrOsSkXfcRuxes1qUfF62F4qkA8Z8t3wQHRM6YuqKqXQoSMnJVP4KeRlqqVGZgW9tfrGJ3Ol00QTlRZMdiOvGoio9l8MgzMc5mHt/RF3PURUg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.43 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) by mx.zohomail.com with SMTPS id 1614193093864849.8335143085563; Wed, 24 Feb 2021 10:58:13 -0800 (PST) Received: by mail-wr1-f43.google.com with SMTP id r3so2894883wro.9 for ; Wed, 24 Feb 2021 10:58:13 -0800 (PST) Return-Path: Return-Path: Received: from x1w.redhat.com (68.red-83-57-175.dynamicip.rima-tde.net. [83.57.175.68]) by smtp.gmail.com with ESMTPSA id e17sm4903551wrw.53.2021.02.24.10.58.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Feb 2021 10:58:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=VfTlNObaYV/Nh4K89JsqHN+ODkOHUE/vR/suP3n68ro=; b=Y4WBI7Hg0cVti85JFchVUvinH/gUHGyG1HTIZgdIfB5p9/8sdfezoUZt0TDIxperiy y8PP/tf628hrUQtYCj0RtOyk/ekeVV3d5QhQ/LE8z8KKUnlO34kCPMtRd39nm9qhtV9O Z2/xhUSL5mZqcq7Bdg5/dH27ElrpmMS+T/WOBl2EBdsCbNKuGbpmmnIbn00wMLZxRDMH Eq1vYCzN4kI+7Pe1MebB2ZotQhZInq4jFbQc/Bpl6aiqadtT3Gf9uQizagFw3arq0mEH vzLcLwjCjQwMA8gJq6ozh91rseGdHL4lzf51acU4gqUie4SKogHVYgEj7atQvMMLmfUv L3HQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=VfTlNObaYV/Nh4K89JsqHN+ODkOHUE/vR/suP3n68ro=; b=JB0q7o1O0eAsfeCgxlRSOLl0l1AT05krkmYLQHM8T3m8iAc6uitH0k5dZSKcTxswuP B/PnRVj/zlzM4KC8e0lOQRGKBIxntT+A61R4g0dPgvq2ITv0kShRjkw/LBTyuzeD25Ol th1t1523PXtJhOBP1M7sqDKhdaAX0VVXnVuc2nkqMlhSVFA5MYlAjxmlSkYHSytw85Ka QWZJ6MYVw/WJp+dTay91sqtsHWvJ6cNkvEYJb2+1xDlpxXNSOUrkw+s4v2/ilK07v4b5 GxJpDTIw6Pe4DzF3zS4V2tmSvn+5Si9gTtCSk036myPkwsjRlaGvahoy/i3Fp9aa7ppN F/vw== X-Gm-Message-State: AOAM5316bu851jwnMqeJ75iIA7/75xD+6ZExRW1ce3p5HAWI0tS7RBZa su1WDUVtUVlqr6+yFQdQWyI= X-Google-Smtp-Source: ABdhPJwVu8POxkZko0Wa7esZns6SxxSU1a3NUL1n/9QbLA38Ox9qchXmMUwp3brA6GUC/WZ2iNHP0g== X-Received: by 2002:a5d:4203:: with SMTP id n3mr4920035wrq.116.1614193091964; Wed, 24 Feb 2021 10:58:11 -0800 (PST) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Craig Janeczek , Jiaxun Yang , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Aleksandar Rikalo , Richard Henderson , Aurelien Jarno Subject: [PATCH v4 10/12] target/mips: Simplify decode_opc_mxu() ifdef'ry Date: Wed, 24 Feb 2021 19:57:04 +0100 Message-Id: <20210224185706.3293058-11-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210224185706.3293058-1-f4bug@amsat.org> References: <20210224185706.3293058-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) By making the prototype public and checking 'TARGET_LONG_BITS =3D=3D 32' we let the compiler elide the decode_opc_mxu() call. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- target/mips/translate.h | 3 +++ target/mips/translate.c | 6 ++---- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/target/mips/translate.h b/target/mips/translate.h index 468e29d7578..a5c49f1ee22 100644 --- a/target/mips/translate.h +++ b/target/mips/translate.h @@ -178,6 +178,9 @@ extern TCGv bcond; /* MSA */ void msa_translate_init(void); =20 +/* MXU */ +bool decode_ase_mxu(DisasContext *ctx, uint32_t insn); + /* decodetree generated */ bool decode_isa_rel6(DisasContext *ctx, uint32_t insn); bool decode_ase_msa(DisasContext *ctx, uint32_t insn); diff --git a/target/mips/translate.c b/target/mips/translate.c index f25b1fe4d8f..84948ab9ce0 100644 --- a/target/mips/translate.c +++ b/target/mips/translate.c @@ -25779,7 +25779,7 @@ static void decode_opc_mxu__pool19(DisasContext *ct= x) /* * Main MXU decoding function */ -static bool decode_ase_mxu(DisasContext *ctx, uint32_t insn) +bool decode_ase_mxu(DisasContext *ctx, uint32_t insn) { uint32_t opcode =3D extract32(insn, 0, 6); =20 @@ -26981,8 +26981,7 @@ static bool decode_opc_legacy(CPUMIPSState *env, Di= sasContext *ctx) break; } #endif -#if !defined(TARGET_MIPS64) - if (ctx->insn_flags & ASE_MXU) { + if (TARGET_LONG_BITS =3D=3D 32 && (ctx->insn_flags & ASE_MXU)) { if (MASK_SPECIAL2(ctx->opcode) =3D=3D OPC_MUL) { gen_arith(ctx, OPC_MUL, rd, rs, rt); } else { @@ -26990,7 +26989,6 @@ static bool decode_opc_legacy(CPUMIPSState *env, Di= sasContext *ctx) } break; } -#endif decode_opc_special2_legacy(env, ctx); break; case OPC_SPECIAL3: --=20 2.26.2