From nobody Wed Nov 19 03:02:58 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.128.46 as permitted sender) client-ip=209.85.128.46; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-f46.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.46 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1614193088; cv=none; d=zohomail.com; s=zohoarc; b=IySzC6sd7lgisOEYCcgkcfGLId+qoee1dK3jgggAm12nv74Pz6ZpoM74MhvGNTFZLFTRsMEf5Bb6ElsjRwN/7OlSDVImWupLI0aFUXIn7qxJnTzasdQUR67QM+gJW8ZkNO+M9Z1+SyqyNx060gEj3JiBeyS53GAETdDSDA0GfFw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1614193088; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=Q1CPhtB2nFX6/Karm+8y/5hrFOndLW7yZ9tpIdrVQP4=; b=DwptCRRS2buN1ino0FiXoZBycbuQaKxTfF239YNAcdio9/EXH/iKLPRbOkQ3Dla7wB+zNCmCBSNHVZGs3E1XQFKybbx/qEtMwr0a7ABOtBZDsXl6WrVEbIbuguQY22E+Xv1olLSy66EFN3lEXsyM1AUqannGGdc13l2m4z9dhyw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.46 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) by mx.zohomail.com with SMTPS id 1614193088662793.0072566231482; Wed, 24 Feb 2021 10:58:08 -0800 (PST) Received: by mail-wm1-f46.google.com with SMTP id w7so2682488wmb.5 for ; Wed, 24 Feb 2021 10:58:08 -0800 (PST) Return-Path: Return-Path: Received: from x1w.redhat.com (68.red-83-57-175.dynamicip.rima-tde.net. [83.57.175.68]) by smtp.gmail.com with ESMTPSA id a5sm5045195wrs.35.2021.02.24.10.58.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Feb 2021 10:58:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Q1CPhtB2nFX6/Karm+8y/5hrFOndLW7yZ9tpIdrVQP4=; b=ty9QNgS4pvkCxQC0mUdRz6NuEwCm/Glyc8pnBdDTG+Z//hlmyEdllR7/qqmalGjmHh MWZ7sEFaDjGl8x7QjNIISNJuH24PP/hkzcKwVXdr8buZ3/s1OeLl2YvYfJ4WhmgrnN+Z prgLkuMz/CrepGVQqb8d2g02s1B/N3hU5iFwkgxMkbztVPaTuIr57wPV/NtQC6V6N89w hX6pw6bRQa9sRVReKQcG0oqtkzsbkNG8abOhfxtYk6aNO2k9LmgrwicPxrqI9eODJ4Iv /yV4ePpQMlsjIV0bLpWD7xJHNZEhqWR7RZJNAzXBk7s0yr0AQQHlhhlgbP3sDpvCYgFu +NHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=Q1CPhtB2nFX6/Karm+8y/5hrFOndLW7yZ9tpIdrVQP4=; b=C0aCysXitvChmu07DcuVV1RiJgrzcxLvyvS4RO70xosI0XeAQFdRuXNSsUcgkjQhbn /F6btc5K/MGL3skO6pGHyTkQGNuk1rqAaMSEU5N8k+J7XBx0hs2c4PeemkQfV06Dgsdb f3avbFJqowgLDonVodWuhCuRxbid68sdIP8jzHD7VIGepY+3z+ZloK+9+YOIK2o6x4kQ nTPPoEB6ys/Q69E7XmwZELdkZkmwvMdoD57TvdaQg9BIxVxSCfwM4uFDF3efqG08IttK BkLEOLedPCpm/ZWsyEf+yyUAqIUj9iP2sMZ9uPqjk36uz8fzr9N5Mbp2Fhf8r+kmZbSo jMMg== X-Gm-Message-State: AOAM531qxD8wn7cW+dNwANAXlTQi3tbEvP87ExVraDSlFCFq6JnNb4iG Wxjs6J5m6eJHDGrSljDXNT0= X-Google-Smtp-Source: ABdhPJzniH1C4GNRK3mJoYumfIc1RwpqRSqJKhuQOupG0QhC6IDfsWYDxhoPS5sabUYKNCyIo35rSQ== X-Received: by 2002:a1c:3b02:: with SMTP id i2mr1023630wma.18.1614193086840; Wed, 24 Feb 2021 10:58:06 -0800 (PST) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Craig Janeczek , Jiaxun Yang , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Aleksandar Rikalo , Richard Henderson , Aurelien Jarno Subject: [PATCH v4 09/12] target/mips: Convert decode_opc_mxu() to decodetree prototype Date: Wed, 24 Feb 2021 19:57:03 +0100 Message-Id: <20210224185706.3293058-10-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210224185706.3293058-1-f4bug@amsat.org> References: <20210224185706.3293058-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) To easily convert MXU code to decodetree, making it return a boolean. Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- target/mips/translate.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/target/mips/translate.c b/target/mips/translate.c index df4868ebb95..f25b1fe4d8f 100644 --- a/target/mips/translate.c +++ b/target/mips/translate.c @@ -25779,18 +25779,18 @@ static void decode_opc_mxu__pool19(DisasContext *= ctx) /* * Main MXU decoding function */ -static void decode_opc_mxu(DisasContext *ctx, uint32_t insn) +static bool decode_ase_mxu(DisasContext *ctx, uint32_t insn) { uint32_t opcode =3D extract32(insn, 0, 6); =20 if (opcode =3D=3D OPC_MXU_S32M2I) { gen_mxu_s32m2i(ctx); - return; + return true; } =20 if (opcode =3D=3D OPC_MXU_S32I2M) { gen_mxu_s32i2m(ctx); - return; + return true; } =20 { @@ -25831,6 +25831,8 @@ static void decode_opc_mxu(DisasContext *ctx, uint3= 2_t insn) gen_set_label(l_exit); tcg_temp_free(t_mxu_cr); } + + return true; } =20 #endif /* !defined(TARGET_MIPS64) */ @@ -26984,7 +26986,7 @@ static bool decode_opc_legacy(CPUMIPSState *env, Di= sasContext *ctx) if (MASK_SPECIAL2(ctx->opcode) =3D=3D OPC_MUL) { gen_arith(ctx, OPC_MUL, rd, rs, rt); } else { - decode_opc_mxu(ctx, ctx->opcode); + decode_ase_mxu(ctx, ctx->opcode); } break; } --=20 2.26.2