From nobody Mon Nov 17 17:47:11 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1614092098; cv=none; d=zohomail.com; s=zohoarc; b=Q3QFkDUZO1RBuLT9cxfQhgQJNykWbsksl+Mcr6gXArV6jIYRhC04Mgz3alvr7F/SpF4mxpvyb2/tGFqyfuqnZDZq5JY0WKx/D/d82J4v20r7L0cYAruNMBDMjbTNoERYjCRhRLWHavhe+UtRSCMK/4aQ3OtzC8nZvZ07hnhAK9E= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1614092098; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=jYzwwFmbc9Ca0Ffjo2EmeanXIdgQj5ck1iF4xrYFOlQ=; b=PnWBJGZcbj1Pse8FOEpSea2C3b4+xBAcmzlufs1y2I0uno501FD75ir3SAH7H/qeIoN+g4nLwlah3E+afU6Lqk5K4QPkBBs2OQDDMeLfWdrBWUihlMcMpCjq4WH9hw/TQmlB04hrcwH9AWIIo4ZE/CvdJbmtbP3fV13UOpUGdTg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1614092098180187.2042496622562; Tue, 23 Feb 2021 06:54:58 -0800 (PST) Received: from localhost ([::1]:43124 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lEZ5V-0005RY-32 for importer@patchew.org; Tue, 23 Feb 2021 09:54:57 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:42568) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lEYzq-00066q-Ip for qemu-devel@nongnu.org; Tue, 23 Feb 2021 09:49:06 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:50724) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1lEYzn-0002rG-GJ for qemu-devel@nongnu.org; Tue, 23 Feb 2021 09:49:06 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-577-CKMxS4WKMEq3H5CNwjFvLQ-1; Tue, 23 Feb 2021 09:49:01 -0500 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 8875F83DCD3; Tue, 23 Feb 2021 14:48:12 +0000 (UTC) Received: from localhost (ovpn-114-203.ams2.redhat.com [10.36.114.203]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3976319C46; Tue, 23 Feb 2021 14:48:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1614091742; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jYzwwFmbc9Ca0Ffjo2EmeanXIdgQj5ck1iF4xrYFOlQ=; b=D8y6eOwSMOe1VA8SartD0pD9HdwX5W6ySjomcCB4tTV4b8jfLeOYMcra09/oGo6Gv362YR guslZg3rMaM5X7atp4a2dRkCgLNcwft3se3VLcjIG+EsFatZCT70Ypu5NITinb56/rzylE GHUlNMQjwn9GSTQuXL2obiaziQOIAJ0= X-MC-Unique: CKMxS4WKMEq3H5CNwjFvLQ-1 From: Stefan Hajnoczi To: qemu-devel@nongnu.org Subject: [PATCH v3 07/12] block/export: fix blk_size double byteswap Date: Tue, 23 Feb 2021 14:46:48 +0000 Message-Id: <20210223144653.811468-8-stefanha@redhat.com> In-Reply-To: <20210223144653.811468-1-stefanha@redhat.com> References: <20210223144653.811468-1-stefanha@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=stefanha@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=216.205.24.124; envelope-from=stefanha@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -10 X-Spam_score: -1.1 X-Spam_bar: - X-Spam_report: (-1.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, MIME_BASE64_TEXT=1.741, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Laurent Vivier , Thomas Huth , qemu-block@nongnu.org, "Michael S. Tsirkin" , Peter Maydell , Coiby Xu , Max Reitz , Stefan Hajnoczi , Paolo Bonzini , Raphael Norwitz Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" The config->blk_size field is little-endian. Use the native-endian blk_size variable to avoid double byteswapping. Fixes: 11f60f7eaee2630dd6fa0c3a8c49f792e46c4cf1 ("block/export: make vhost-= user-blk config space little-endian") Signed-off-by: Stefan Hajnoczi --- block/export/vhost-user-blk-server.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/export/vhost-user-blk-server.c b/block/export/vhost-user= -blk-server.c index ab2c4d44c4..7aea132f69 100644 --- a/block/export/vhost-user-blk-server.c +++ b/block/export/vhost-user-blk-server.c @@ -356,7 +356,7 @@ vu_blk_initialize_config(BlockDriverState *bs, config->num_queues =3D cpu_to_le16(num_queues); config->max_discard_sectors =3D cpu_to_le32(32768); config->max_discard_seg =3D cpu_to_le32(1); - config->discard_sector_alignment =3D cpu_to_le32(config->blk_size >> 9= ); + config->discard_sector_alignment =3D cpu_to_le32(blk_size >> 9); config->max_write_zeroes_sectors =3D cpu_to_le32(32768); config->max_write_zeroes_seg =3D cpu_to_le32(1); } --=20 2.29.2