From nobody Mon Nov 17 17:47:11 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1614091812; cv=none; d=zohomail.com; s=zohoarc; b=cX4jxIopFqBo10XaT7IbAEAiomyqwndovNKuEMZDsmYMyUVmdagYF8UBG2LQOYJovBByhqUhJnK4uQ/6Yee+d05RjVru4VfYuu7WG/E9+S40FTITSQIjhC54qYJyinfuihAURHsZVfkEdn4W8c1Wi3dq269mGw3H7n1b9sBBd5U= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1614091812; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=NSYjsB/pGxlEpzlJCJ6wq+mHOZNNGLTmoAPEm1ZXduU=; b=PxjMY4SLCpkIJ51NT/Y4mcU6el2k9CSMkIoYXBYmvkZ/gNP9Ueh6L4znFeR/Nbo9sykpfAPs5vdu7I5FcCS/50Y6SPj/3Op9VBhtOaNe+xXfRpi5z6t2oTn9YCp+oSqGlRE3kLafrHiGSsqQI7HwRDjL6GY4zlGYpuAOPMoRZ+0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1614091812085904.3075633081605; Tue, 23 Feb 2021 06:50:12 -0800 (PST) Received: from localhost ([::1]:55520 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lEZ0t-0007EX-0C for importer@patchew.org; Tue, 23 Feb 2021 09:50:11 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:42348) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lEYzQ-0005a1-5o for qemu-devel@nongnu.org; Tue, 23 Feb 2021 09:48:41 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:44512) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1lEYzM-0002fD-N2 for qemu-devel@nongnu.org; Tue, 23 Feb 2021 09:48:39 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-23-1M711JoxMPKY_KIU5wS1YA-1; Tue, 23 Feb 2021 09:48:34 -0500 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 0269110CE782; Tue, 23 Feb 2021 14:48:33 +0000 (UTC) Received: from localhost (ovpn-114-203.ams2.redhat.com [10.36.114.203]) by smtp.corp.redhat.com (Postfix) with ESMTP id B60F45D6AB; Tue, 23 Feb 2021 14:48:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1614091716; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NSYjsB/pGxlEpzlJCJ6wq+mHOZNNGLTmoAPEm1ZXduU=; b=LBe1O0TyvVAjQlRH3YWPg4jpjZxzdf+Ygb2fJq7tqzeQ4UbGVD8khwb4G3nq+ZQkc0BaOi GpMNGNy6bMsgggbiVFqlWQzA0p7TyhkzbDhxM2dBM+igdNCSQQAQ9OpvLKe2NKkdqHJHAP QYDNi3kmkjBoX08kTC4YdaO7JwFlt/0= X-MC-Unique: 1M711JoxMPKY_KIU5wS1YA-1 From: Stefan Hajnoczi To: qemu-devel@nongnu.org Subject: [PATCH v3 09/12] block/export: fix vhost-user-blk export sector number calculation Date: Tue, 23 Feb 2021 14:46:50 +0000 Message-Id: <20210223144653.811468-10-stefanha@redhat.com> In-Reply-To: <20210223144653.811468-1-stefanha@redhat.com> References: <20210223144653.811468-1-stefanha@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=stefanha@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=216.205.24.124; envelope-from=stefanha@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -10 X-Spam_score: -1.1 X-Spam_bar: - X-Spam_report: (-1.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, MIME_BASE64_TEXT=1.741, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Laurent Vivier , Thomas Huth , qemu-block@nongnu.org, "Michael S. Tsirkin" , Peter Maydell , Coiby Xu , Max Reitz , Stefan Hajnoczi , Paolo Bonzini , Raphael Norwitz Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" The driver is supposed to honor the blk_size field but the protocol still uses 512-byte sector numbers. It is incorrect to multiply req->sector_num by blk_size. VIRTIO 1.1 5.2.5 Device Initialization says: blk_size can be read to determine the optimal sector size for the driver to use. This does not affect the units used in the protocol (always 512 bytes), but awareness of the correct value can affect performance. Fixes: 3578389bcf76c824a5d82e6586a6f0c71e56f2aa ("block/export: vhost-user = block device backend server") Signed-off-by: Stefan Hajnoczi --- block/export/vhost-user-blk-server.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/export/vhost-user-blk-server.c b/block/export/vhost-user= -blk-server.c index 2614a63791..f74796241c 100644 --- a/block/export/vhost-user-blk-server.c +++ b/block/export/vhost-user-blk-server.c @@ -144,7 +144,7 @@ static void coroutine_fn vu_blk_virtio_process_req(void= *opaque) break; } =20 - int64_t offset =3D req->sector_num * vexp->blk_size; + int64_t offset =3D req->sector_num << VIRTIO_BLK_SECTOR_BITS; QEMUIOVector qiov; if (is_write) { qemu_iovec_init_external(&qiov, out_iov, out_num); --=20 2.29.2