From nobody Mon Feb 9 16:45:03 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1614010446; cv=none; d=zohomail.com; s=zohoarc; b=ih0rT8AusVar02UwLYUqn1eoSvpXVMhIl5Jm5F5fOpIRaniEK+OP9HKnNsRCoEXVX1Ff818H2WkgOnhXc3Ypi+Zx52QwqR/MzJBoJBG7iUqI6iyu6WZflX+JIM/ejhzPjISigESPE39yqfMYWvDlOsDkWVA0ffo2C81WUFS5g3Q= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1614010446; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=fE2ZqW7Abd0nNn/xz8kYfaU1Kg9VPxOJrShvvATcpvw=; b=JlIVeW5r1jumkCX5j339UP/mQfo142rEY85LF7H4y4ovbgG/EkpD2XILRtUC+Oxcw5tMYoDN0rtk09BvqvlBm6rkZSCiAUyErQp98gsvwZpzCHAfZghinSaxytSsU+RcxVd8oRg9WHSx5MpNk+GwdwgD5baXDw/SaOXMk0Ej+hc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 161401044582750.62857133152045; Mon, 22 Feb 2021 08:14:05 -0800 (PST) Received: from localhost ([::1]:60890 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lEDqW-0004In-Of for importer@patchew.org; Mon, 22 Feb 2021 11:14:04 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:51882) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lEDnf-0002XF-Ue for qemu-devel@nongnu.org; Mon, 22 Feb 2021 11:11:07 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:53730) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1lEDne-0002B1-C9 for qemu-devel@nongnu.org; Mon, 22 Feb 2021 11:11:07 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-199-DcsUX2HAMUyjUV34pjH8sg-1; Mon, 22 Feb 2021 11:11:00 -0500 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 77F39801A8A for ; Mon, 22 Feb 2021 16:10:59 +0000 (UTC) Received: from localhost (ovpn-112-255.ams2.redhat.com [10.36.112.255]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2A2F91054FDC; Mon, 22 Feb 2021 16:10:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1614010263; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fE2ZqW7Abd0nNn/xz8kYfaU1Kg9VPxOJrShvvATcpvw=; b=KJfeWeUuHMDlaQMIcXdDib5UVi7QXh2ZroDOacPnzIrTShTauj+ll9/tUpMqPj2Pf0EzZ3 X0Z5NOop6l2ynWroyWTdgEGL2f49pFf6HI1qC9/dEBjuEsKhu6vP1cU9Z7xcYJ68QlHPTD sbZGFP4pU67spcIxAZgrNJ+VMwx+hY4= X-MC-Unique: DcsUX2HAMUyjUV34pjH8sg-1 From: Stefan Hajnoczi To: qemu-devel@nongnu.org Subject: [PATCH 1/3] tests/qtest/vhost-user-test: use share=on with memfd Date: Mon, 22 Feb 2021 16:10:15 +0000 Message-Id: <20210222161017.570837-2-stefanha@redhat.com> In-Reply-To: <20210222161017.570837-1-stefanha@redhat.com> References: <20210222161017.570837-1-stefanha@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=stefanha@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=216.205.24.124; envelope-from=stefanha@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -10 X-Spam_score: -1.1 X-Spam_bar: - X-Spam_report: (-1.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, MIME_BASE64_TEXT=1.741, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kwolf@redhat.com, Laurent Vivier , Thomas Huth , "Michael S. Tsirkin" , Stefan Hajnoczi , Paolo Bonzini , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" For some reason memfd never used share=3Don. vhost-user relies on mmap(MAP_SHARED) so this seems like a problem, but the tests still run without it. Add share=3Don for consistency and to prevent future bugs in the test. Signed-off-by: Stefan Hajnoczi Acked-by: Thomas Huth Reviewed-by: Marc-Andr=C3=A9 Lureau --- tests/qtest/vhost-user-test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/qtest/vhost-user-test.c b/tests/qtest/vhost-user-test.c index 1a5f5313ff..2db98c4920 100644 --- a/tests/qtest/vhost-user-test.c +++ b/tests/qtest/vhost-user-test.c @@ -40,7 +40,7 @@ #define QEMU_CMD_MEM " -m %d -object memory-backend-file,id=3Dmem,size= =3D%dM," \ "mem-path=3D%s,share=3Don -numa node,memdev=3Dmem" #define QEMU_CMD_MEMFD " -m %d -object memory-backend-memfd,id=3Dmem,size= =3D%dM," \ - " -numa node,memdev=3Dmem" + "share=3Don -numa node,memdev=3Dmem" #define QEMU_CMD_CHR " -chardev socket,id=3D%s,path=3D%s%s" #define QEMU_CMD_NETDEV " -netdev vhost-user,id=3Dhs0,chardev=3D%s,vhostfo= rce" =20 --=20 2.29.2