From nobody Mon Feb 9 09:33:49 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1614000237; cv=none; d=zohomail.com; s=zohoarc; b=mE4pDwDOzeqA8Ur/PInEZyuXAY2hbu+A+1wDlgLm0jWaDJmjKMD7b4k7iCF6Fy2/8fHRw0uR3qRjJ6Ezw2JeFh+tDByZz73i3f3QTPD6dH0bv/m2hakz3TLj/rXuTatFWCrntI7PQS3mNfqOfpgHqvb+6OKFjP1Xt+TP2JIh+EA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1614000237; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=+UzSdyjSd904zCeIE0aTyBCjawmbJBRlBQ1EDG6ABek=; b=OCIx7oDxVKkzBngZ7EhzMZ4YLYRasi04Svce//effr8wtYsLa2NLxETh/sGBxo8LRsqKoYcFE3GhAsKcDJp+QpewCzMzFPYFX5XMIfhlt3+WnKsgLJ7CZX1FJnKMxQwniSzCeBg67KYo+5GYkBH4FOJSJhsg1uVheuEjS638+3s= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 161400023726281.7823269248521; Mon, 22 Feb 2021 05:23:57 -0800 (PST) Received: from localhost ([::1]:50018 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lEBBq-0006bS-2L for importer@patchew.org; Mon, 22 Feb 2021 08:23:54 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:59138) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lEB3x-0005uC-Kr; Mon, 22 Feb 2021 08:15:45 -0500 Received: from mail-pf1-x42d.google.com ([2607:f8b0:4864:20::42d]:41554) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lEB3o-00016M-Eg; Mon, 22 Feb 2021 08:15:45 -0500 Received: by mail-pf1-x42d.google.com with SMTP id q20so6557181pfu.8; Mon, 22 Feb 2021 05:15:35 -0800 (PST) Received: from i9-aorus-gtx1080.localdomain (144.168.56.201.16clouds.com. [144.168.56.201]) by smtp.gmail.com with ESMTPSA id p8sm17473190pgi.21.2021.02.22.05.15.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Feb 2021 05:15:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=+UzSdyjSd904zCeIE0aTyBCjawmbJBRlBQ1EDG6ABek=; b=H/vU+GcDF+rNYkcu4oMkbTRtvLcpM1uQ5Phuclloz9JjJfT//68zj6gUmkhK//vWBu NXiYx1WKHllQJ3AQU7WGUIcYECyEWS9erFs0t7Yv4cBN3d0i8IwH1LvlP3wDUK6wn/5e BVRbUfy9majf/6ZtnqE7lch16JosinS6Om1xEq7o5Q3yfbCa6xvlzchEE7Tn2BwS7li+ FRjsm0n6hqvofDgmg37MGQ+twVoRZ0OtiOYIj+mTod/rRhTtCHTJ/JrTa3VN2QzlC388 8oNmOxLAPxRjJ/lrahZakIIigxbeI9TJVMKXCvzeHTkMLfCNEeu6c1J0GtF3DffJRGcI DDfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=+UzSdyjSd904zCeIE0aTyBCjawmbJBRlBQ1EDG6ABek=; b=CK/RKb5kl1Q0r7uRuCr85FndgJ9v6SFTikoN5xqk3NtbvL/cQHM78i6SLvHjHbLYI3 2165gxExhrtUbsAw6FWEHkAhWUg66CMgNalCgnuu8Wm2ShchGPOLytdTWtAPD3mj4yDr Sa05YxuJBvVDkwt6zu/vOfA8NyP5isWTS1v2/1fAuVTtru8cD3ozxVd7jlLc/OqOvIPJ fLfS46vLIn0OvbsEq4ZirfrRtbMyNt5vJkMz6udqdUxgKHClKjmWwpvKXvDT35lwsF/m dA8LJqjQEAp38F4BzHLMwq6V1HgVLuDIRp83o3l9iupWmdrvwuWF3J+vk6b7rDkF+MXY Y+Tg== X-Gm-Message-State: AOAM532sEexjr5ni+sR4WPAZV2agltsa2Jgirn1BaP1bl8e69xW87lNR FmEQS6ejc4yfwxUfjxd6t1g= X-Google-Smtp-Source: ABdhPJwd914m3lKtsTuxBneLBgB6QZefxasTFf8Zku+ZKJuQmWLOpgTdNmovBBePClbPsC79BBNejg== X-Received: by 2002:aa7:9182:0:b029:1de:e96f:a866 with SMTP id x2-20020aa791820000b02901dee96fa866mr13986091pfa.67.1613999734882; Mon, 22 Feb 2021 05:15:34 -0800 (PST) From: Bin Meng To: Alistair Francis , "Edgar E . Iglesias" , Peter Maydell Subject: [RESEND PATCH v4 4/5] hw/ssi: xilinx_spips: Clean up coding convention issues Date: Mon, 22 Feb 2021 21:15:01 +0800 Message-Id: <20210222131502.3098-5-bmeng.cn@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210222131502.3098-1-bmeng.cn@gmail.com> References: <20210222131502.3098-1-bmeng.cn@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::42d; envelope-from=bmeng.cn@gmail.com; helo=mail-pf1-x42d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Edgar E . Iglesias" , Xuzhou Cheng , Bin Meng , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org, Francisco Iglesias , qemu-arm@nongnu.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) From: Xuzhou Cheng There are some coding convention warnings in xilinx_spips.c, as reported by: $ ./scripts/checkpatch.pl hw/ssi/xilinx_spips.c Let's clean them up. Signed-off-by: Xuzhou Cheng Signed-off-by: Bin Meng Reviewed-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Peter Maydell Reviewed-by: Edgar E. Iglesias --- (no changes since v1) hw/ssi/xilinx_spips.c | 23 ++++++++++++++--------- 1 file changed, 14 insertions(+), 9 deletions(-) diff --git a/hw/ssi/xilinx_spips.c b/hw/ssi/xilinx_spips.c index a897034601..8a0cc22d42 100644 --- a/hw/ssi/xilinx_spips.c +++ b/hw/ssi/xilinx_spips.c @@ -176,7 +176,8 @@ FIELD(GQSPI_FIFO_CTRL, GENERIC_FIFO_RESET, 0, 1) #define R_GQSPI_GFIFO_THRESH (0x150 / 4) #define R_GQSPI_DATA_STS (0x15c / 4) -/* We use the snapshot register to hold the core state for the currently +/* + * We use the snapshot register to hold the core state for the currently * or most recently executed command. So the generic fifo format is defined * for the snapshot register */ @@ -424,7 +425,8 @@ static void xlnx_zynqmp_qspips_reset(DeviceState *d) xlnx_zynqmp_qspips_update_ixr(s); } =20 -/* N way (num) in place bit striper. Lay out row wise bits (MSB to LSB) +/* + * N way (num) in place bit striper. Lay out row wise bits (MSB to LSB) * column wise (from element 0 to N-1). num is the length of x, and dir * reverses the direction of the transform. Best illustrated by example: * Each digit in the below array is a single bit (num =3D=3D 3): @@ -637,8 +639,10 @@ static void xilinx_spips_flush_txfifo(XilinxSPIPS *s) tx_rx[i] =3D tx; } } else { - /* Extract a dummy byte and generate dummy cycles according to= the - * link state */ + /* + * Extract a dummy byte and generate dummy cycles according to= the + * link state + */ tx =3D fifo8_pop(&s->tx_fifo); dummy_cycles =3D 8 / s->link_state; } @@ -721,8 +725,9 @@ static void xilinx_spips_flush_txfifo(XilinxSPIPS *s) } break; case (SNOOP_ADDR): - /* Address has been transmitted, transmit dummy cycles now if - * needed */ + /* + * Address has been transmitted, transmit dummy cycles now if = needed + */ if (s->cmd_dummies < 0) { s->snoop_state =3D SNOOP_NONE; } else { @@ -876,7 +881,7 @@ static void xlnx_zynqmp_qspips_notify(void *opaque) } =20 static uint64_t xilinx_spips_read(void *opaque, hwaddr addr, - unsigned size) + unsigned size) { XilinxSPIPS *s =3D opaque; uint32_t mask =3D ~0; @@ -970,7 +975,7 @@ static uint64_t xlnx_zynqmp_qspips_read(void *opaque, } =20 static void xilinx_spips_write(void *opaque, hwaddr addr, - uint64_t value, unsigned size) + uint64_t value, unsigned size) { int mask =3D ~0; XilinxSPIPS *s =3D opaque; @@ -1072,7 +1077,7 @@ static void xilinx_qspips_write(void *opaque, hwaddr = addr, } =20 static void xlnx_zynqmp_qspips_write(void *opaque, hwaddr addr, - uint64_t value, unsigned size) + uint64_t value, unsigned size) { XlnxZynqMPQSPIPS *s =3D XLNX_ZYNQMP_QSPIPS(opaque); uint32_t reg =3D addr / 4; --=20 2.25.1