From nobody Tue Feb 10 20:07:31 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.52 as permitted sender) client-ip=209.85.221.52; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f52.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.52 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1613918291; cv=none; d=zohomail.com; s=zohoarc; b=mb0VkyvjDgHENIgpuIrXA98qdJx+bPm2WbmTomzR4OcrkAZ5GPoQAktrS0IXgGHy4wDB0qHCrEwlqByQvILP+OJ3Q4IAZ3LJF3b0uqs1s0se4VHZEbsM9u2OdyxTg9eoPi8RYO6hB5kDaGajBbK8rXPSUOj7T6wVp5jti1xz6iU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1613918291; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=zw4iTXqwCfmL83vCtQL4WiNjLhPBYSVn760ReNY3gcU=; b=Ms+sA14/Pa+tLr23OrewK84yCF5q4E+LNKg6nm09SgPQw6ePD3xULLqKDLwR3ND3kbWxKbq8V4isbt3bn5yTYfpv1mKpWnwIlqEV+gK7VH6WrMR4+TckN6K6AfEu/FG5ymFsfl1ZY+06M9qOGL0AmThtrfT/8EULDXKt2wlZf44= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.52 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) by mx.zohomail.com with SMTPS id 1613918290643158.17460707050168; Sun, 21 Feb 2021 06:38:10 -0800 (PST) Received: by mail-wr1-f52.google.com with SMTP id a4so14117962wro.8 for ; Sun, 21 Feb 2021 06:38:10 -0800 (PST) Return-Path: Return-Path: Received: from localhost.localdomain (68.red-83-57-175.dynamicip.rima-tde.net. [83.57.175.68]) by smtp.gmail.com with ESMTPSA id z5sm25577308wrn.8.2021.02.21.06.38.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 21 Feb 2021 06:38:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=zw4iTXqwCfmL83vCtQL4WiNjLhPBYSVn760ReNY3gcU=; b=KfzZeD4dTJh9SvhGBrddSTUkMr9pLjmbd6mWrRnFp+W8JyYJVqcK9EG+w45hkZaIQZ yfvsAp/VaWQUdGZg2BMzvpQFZKsBhbgFbVqthuFGeQLxzUIhaAIm9Lwrv4JH6BSgetJn gDEacxYtvEg3yo+MHnP6MVzQ0Wt/GfLi6yEoRlAm1CJP1gdHeuFIuzLoGaDaQWmRkTOm mx8gPNGd8qgxMLBKXdV2xe8vJ+XiUQx5M6rbuAZZcsre8IhJx+d4eaU/h+RHXt3iAf7b KKRlBLl+PiKaqLNDPi88GvzdN1GIrE9NkaIp9lSJCR0PMumnIzNdsHyexE/43EoaycC8 ZtUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=zw4iTXqwCfmL83vCtQL4WiNjLhPBYSVn760ReNY3gcU=; b=rJJSwcDDobrGFJqC426ihKsff8RBXcyzokHIYtEoNaM4klJva4frqBWz6J5FfUAYtj 4SoaBT1WZP911PJe0AsrIMixyXHkw/slt3ej1Wofn5Qp1O4baxx7unSxLBZSwGFFos+k sk2FBn5yu3jFk0WBbXnNEbTOBDmcHLfxUY3JYEF5t1fk2u1iXBrP6jSiS0ROYlzT5LN4 cjWFx8gydJbceJnbg5Dr/wZa15hF0qyKZTj1ut4X7If1WZO0t9BCiDlDOG9DUVWMEaX2 +XXBW6tRxpiJvnsNkoGiUZVN452p6z3BPXlSIHtyUdl3pPDxTLHbCLKdHBQsQoelYxNv c6Mw== X-Gm-Message-State: AOAM53362gm3tZ869iLvaj5yBWO6oVpFR5n2heLNPqpwo7xlANPAPj8f AHvaHKa7krKz4+5/adjXi8Q= X-Google-Smtp-Source: ABdhPJzo4kuxSgDrnorUsaeLvfyCIQFxVqaqeyXZKzLkz6MISUhVuRiCU56M5fh7uMAbpksTIHiZlw== X-Received: by 2002:adf:fe09:: with SMTP id n9mr6659141wrr.104.1613918288998; Sun, 21 Feb 2021 06:38:08 -0800 (PST) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Paul Burton , Wainer dos Santos Moschetta , Aleksandar Rikalo , Aurelien Jarno , Marcel Apfelbaum , Cleber Rosa , "Michael S. Tsirkin" , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Huacai Chen , Jiaxun Yang , BALATON Zoltan Subject: [PULL 43/43] vt82c686: Fix superio_cfg_{read,write}() functions Date: Sun, 21 Feb 2021 15:34:32 +0100 Message-Id: <20210221143432.2468220-44-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210221143432.2468220-1-f4bug@amsat.org> References: <20210221143432.2468220-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) From: BALATON Zoltan These functions are memory region callbacks so we have to check against relative address not the mapped address. Signed-off-by: BALATON Zoltan Message-Id: <15b2968fd300a12d06b42368d084f6f80d3c3be5.1610223397.git.balato= n@eik.bme.hu> [PMD: Split original patch in 5, this is part 5/5] Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/isa/vt82c686.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/hw/isa/vt82c686.c b/hw/isa/vt82c686.c index 766584cabd0..5db9b1706c8 100644 --- a/hw/isa/vt82c686.c +++ b/hw/isa/vt82c686.c @@ -260,12 +260,13 @@ static void superio_cfg_write(void *opaque, hwaddr ad= dr, uint64_t data, SuperIOConfig *sc =3D opaque; uint8_t idx =3D sc->regs[0]; =20 - if (addr =3D=3D 0x3f0) { /* config index register */ - idx =3D data & 0xff; + if (addr =3D=3D 0) { /* config index register */ + sc->regs[0] =3D data; return; } - /* 0x3f1, config data register */ - trace_via_superio_write(idx, data & 0xff); + + /* config data register */ + trace_via_superio_write(idx, data); switch (idx) { case 0x00 ... 0xdf: case 0xe4: @@ -284,7 +285,7 @@ static void superio_cfg_write(void *opaque, hwaddr addr= , uint64_t data, "via_superio_cfg: unimplemented register 0x%x\n", id= x); break; } - sc->regs[idx] =3D data & 0xff; + sc->regs[idx] =3D data; } =20 static uint64_t superio_cfg_read(void *opaque, hwaddr addr, unsigned size) --=20 2.26.2