From nobody Tue Feb 10 04:02:18 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.45 as permitted sender) client-ip=209.85.221.45; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f45.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.45 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com; dmarc=fail(p=none dis=none) header.from=amsat.org ARC-Seal: i=1; a=rsa-sha256; t=1613918278; cv=none; d=zohomail.com; s=zohoarc; b=N9CFzbFIjEGzIQp/kg37ypEPGa35hyL9Bu6IO3/KgF8WdpErXlU0Q17dVcJXinLBgyI5gHbJocLm6DsdwnUDmOzM3uQJaIbVnxrZuPe60eh0xLao7t3Vqj0kWZoVqScJw1SS9L+WZCayXA8cGqXzkWSlLRmelISvmTRyE6e/W6Y= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1613918278; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=8uDjfWQ/sIxX8kRNXJ8euWqWigOjj7dJz0jCt5kTchs=; b=G2chTNTpoYM/mdKNrOc79xkPEinLD0qSRizZLJ+k+94UxgzHXCueGIShWUrL2nr1iuLYGn+NFlaToXOn/mMHey+DHI6C153Nl4PvWViq3Z6XXHuULIoAfuCYnPob4YYCTjwm/pj0iLGixrdoDIzuIoKrEvMXU3G/8iTQQSOMTBg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.45 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) by mx.zohomail.com with SMTPS id 1613918277840224.95414549212; Sun, 21 Feb 2021 06:37:57 -0800 (PST) Received: by mail-wr1-f45.google.com with SMTP id v14so16335067wro.7 for ; Sun, 21 Feb 2021 06:37:55 -0800 (PST) Return-Path: Return-Path: Received: from localhost.localdomain (68.red-83-57-175.dynamicip.rima-tde.net. [83.57.175.68]) by smtp.gmail.com with ESMTPSA id k15sm22512939wrn.0.2021.02.21.06.37.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 21 Feb 2021 06:37:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=8uDjfWQ/sIxX8kRNXJ8euWqWigOjj7dJz0jCt5kTchs=; b=p+pRljfKwjNP3bu+/xPFoCAtSM7PjIZHzBxwnCdsqY3abCuzVYPJPy3vsuf2dgZ/Wo hNSMZh+hlfljzvd2dNcRMh6sQLAHmZp9TeK9ZyixqBXwz/GcBFRTXYeWMq9/otYEEzA7 RYt1k/Td36/KeWih9I43NP0NuNXB7ssCC/ashlvjUugMHSbC4Mxzjg5iTZZ+IgSadrfw 5FQPtGAND3mOEqIFDJY6sM9hFekuMUe2rf+xDrmSuyGkc5aZWhqh9E8H18pdMgDFSpg/ uvQhp87H5tgT8U/dZ2ZlGvbli3URS4XncphfuT3fXIsCYVMsm0Es2BXh+uoH85KXW6Wz dGlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=8uDjfWQ/sIxX8kRNXJ8euWqWigOjj7dJz0jCt5kTchs=; b=Sv0RD5QfemRqF7HHGXqxwzby7MvE4sretr1SjjYiae3dAF0i8Gxj6BGN60J6r06ctY 0KkXm25Qsr9p9tn53JO/d6kCp+Q7uWAndlh1ZH/zfC4jW4m1uymRWWW/+meVGXpUlTsO Q/ddV3/wV44K96bS4vHSKK1FA5iZQx7RbixaBLfTaa54QdFBbvrXce0CBfonc+bCcRn8 wijk7lyn1foFVrbjZkH53/b5moUobesDaTU1fxS+Q2OJrNQfPdziFXLDI7hPkOYzr4HS 44heqJLBmBwHexKkieDTu+pMarPfgHgBatjJbcIRpqAp85wxUrGLlBZwvuyIDEgbli7o mK0g== X-Gm-Message-State: AOAM5325tXQ7tA56R9M4fUnAuehNbgD+H13EU6zpcXa07L/g9RUq8Jg6 yTOnI81hsAcxRm2z1+ko5p4= X-Google-Smtp-Source: ABdhPJwBnXMnOdM7BvaxmiRmkk4kGQ6WG4QlB3WoFoOpytBGhALFzaKm+Dq4Yu581qVCIZS2/aBwXw== X-Received: by 2002:a5d:4e10:: with SMTP id p16mr17614678wrt.360.1613918274100; Sun, 21 Feb 2021 06:37:54 -0800 (PST) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Paul Burton , Wainer dos Santos Moschetta , Aleksandar Rikalo , Aurelien Jarno , Marcel Apfelbaum , Cleber Rosa , "Michael S. Tsirkin" , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Huacai Chen , Jiaxun Yang , BALATON Zoltan Subject: [PULL 40/43] vt82c686: Reduce indentation by returning early Date: Sun, 21 Feb 2021 15:34:29 +0100 Message-Id: <20210221143432.2468220-41-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210221143432.2468220-1-f4bug@amsat.org> References: <20210221143432.2468220-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) From: BALATON Zoltan Signed-off-by: BALATON Zoltan Message-Id: <15b2968fd300a12d06b42368d084f6f80d3c3be5.1610223397.git.balato= n@eik.bme.hu> Reviewed-by: Philippe Mathieu-Daud=C3=A9 [PMD: Split patch original in 5, this is part 2/5] Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/isa/vt82c686.c | 47 +++++++++++++++++++++++------------------------ 1 file changed, 23 insertions(+), 24 deletions(-) diff --git a/hw/isa/vt82c686.c b/hw/isa/vt82c686.c index eebaa0d444c..2f69b4d531f 100644 --- a/hw/isa/vt82c686.c +++ b/hw/isa/vt82c686.c @@ -258,33 +258,32 @@ static void superio_cfg_write(void *opaque, hwaddr ad= dr, uint64_t data, { SuperIOConfig *sc =3D opaque; uint8_t idx =3D sc->regs[0]; + bool can_write =3D true; =20 if (addr =3D=3D 0x3f0) { /* config index register */ idx =3D data & 0xff; - } else { - bool can_write =3D true; - /* 0x3f1, config data register */ - trace_via_superio_write(idx, data & 0xff); - switch (idx) { - case 0x00 ... 0xdf: - case 0xe4: - case 0xe5: - case 0xe9 ... 0xed: - case 0xf3: - case 0xf5: - case 0xf7: - case 0xf9 ... 0xfb: - case 0xfd ... 0xff: - can_write =3D false; - break; - /* case 0xe6 ... 0xe8: Should set base port of parallel and serial= */ - default: - break; - - } - if (can_write) { - sc->regs[idx] =3D data & 0xff; - } + return; + } + /* 0x3f1, config data register */ + trace_via_superio_write(idx, data & 0xff); + switch (idx) { + case 0x00 ... 0xdf: + case 0xe4: + case 0xe5: + case 0xe9 ... 0xed: + case 0xf3: + case 0xf5: + case 0xf7: + case 0xf9 ... 0xfb: + case 0xfd ... 0xff: + can_write =3D false; + break; + /* case 0xe6 ... 0xe8: Should set base port of parallel and serial */ + default: + break; + } + if (can_write) { + sc->regs[idx] =3D data & 0xff; } } =20 --=20 2.26.2