From nobody Wed Feb 11 00:59:53 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.128.45 as permitted sender) client-ip=209.85.128.45; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-f45.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.45 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com; dmarc=fail(p=none dis=none) header.from=amsat.org ARC-Seal: i=1; a=rsa-sha256; t=1613918261; cv=none; d=zohomail.com; s=zohoarc; b=VdRtUINKzXa4lhulp3SUsSWiXCF/Msj1HpjkWkYjUPqXpFQTnRRL2U2xhactUV56mtAiUFSk9bczaXhSOY02oA+R/YI+GMjhn4CB10m6nE5kahtPH5inBDiG4wrvmcd8VdbeFLN2mE0SJuoadvd24wB+rJQ2Ml2D5hHCiulhCnw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1613918261; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=8x/mEIPP6SN5UeYnGwuR8cfhi2QpcZNzmhDjPXqrXro=; b=VRnTSe39IpCzhpfj6PJt8mzUn9hHRErfdB7wA1Iv9QO8kTsu7PfJ9cw7oIX1J8Eo/lAWE9aPAYh0mWrh/KXaH6lxUqHe2HqMPoPyX7tTQJVeB5HObhmgwAdUb/Evnvl62biWDIyrr0tJqLzo6Lfsn4W45ioz1oNmxSE0WgmcmQc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.128.45 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) by mx.zohomail.com with SMTPS id 1613918260729154.9487697014331; Sun, 21 Feb 2021 06:37:40 -0800 (PST) Received: by mail-wm1-f45.google.com with SMTP id l13so2519508wmg.5 for ; Sun, 21 Feb 2021 06:37:40 -0800 (PST) Return-Path: Return-Path: Received: from localhost.localdomain (68.red-83-57-175.dynamicip.rima-tde.net. [83.57.175.68]) by smtp.gmail.com with ESMTPSA id t16sm6602666wrq.53.2021.02.21.06.37.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 21 Feb 2021 06:37:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=8x/mEIPP6SN5UeYnGwuR8cfhi2QpcZNzmhDjPXqrXro=; b=bZkAYYt4xqcWLIIuVW+YsHWKj2hfdYxNLXsk+r81R0E6i1hXpnicbKcU0sXfZG0vX1 7YKheWgosr4fS/BsacsGHhDTXrYcNWZ74XDmV3uwUjnjBu1wzibjdhMguOCiwJSBrFHw goW5Si6pRH3zC6LS7on/ZcpegeFamrGemIv4liMpdIlSsdbVzrJbX/d3yuwMKSoVZe91 ID0L9W3swP4H8fa/tiEIP4rxVQ/v0CYtoK7ashf/VBwQc28+fjaHIMMvK3MdSFQ4c8BA r97dIWyL8vi/jHy39AyXeApjQM04Ckd0n5pI8QO9srMrkRfqEVOG0z/tiLYlq/JgYwGt YMeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=8x/mEIPP6SN5UeYnGwuR8cfhi2QpcZNzmhDjPXqrXro=; b=pobb9zsZVwmozAHL2RK0brHnbd21mL5n5PvmRTx2EdF98H345wMlLkQ84ebHlr285M ngiL50VQsBvh93qp7H4kX7BAwJjuTSIQN9m+aO7yCAQ5oaCZE4C4mHmvtMLB8pfY4TUe +2zmq+sZJXuoOob9Z+pICvhempQmPKd5b9zKvR4UCFI7twKD3nLKD9PnaMzxRE3BBUU8 atJQW+vF4mLnK76Arkr+qJeFIVEf1J0qk+6N0fHwBMRbsCgTCBxLjvovhnJCf/jKjdFI 2tZhELT1cQdFaBre2ExjbOId6AcXjZbxXOrnFKLs1IprJ2zK/a1mwgk5tKGct7aWpLAz 7Gxg== X-Gm-Message-State: AOAM533CIeeAz6ibtbmZNn7eQYHuogLsBmRfWQfX4Hzzksg/47rqxwAH 8biey/r3raf+2Rwnz4R+PsQ= X-Google-Smtp-Source: ABdhPJz7r0EjONDtIdNO3SwDc7gDDUKvSpmp5VJqc3SRZvP2vrDB7NyZNgMQfX15UKumEU90unIjvA== X-Received: by 2002:a1c:4683:: with SMTP id t125mr16240100wma.75.1613918259015; Sun, 21 Feb 2021 06:37:39 -0800 (PST) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Paul Burton , Wainer dos Santos Moschetta , Aleksandar Rikalo , Aurelien Jarno , Marcel Apfelbaum , Cleber Rosa , "Michael S. Tsirkin" , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Huacai Chen , Jiaxun Yang , BALATON Zoltan Subject: [PULL 37/43] vt82c686: Simplify vt82c686b_realize() Date: Sun, 21 Feb 2021 15:34:26 +0100 Message-Id: <20210221143432.2468220-38-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210221143432.2468220-1-f4bug@amsat.org> References: <20210221143432.2468220-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) From: BALATON Zoltan Remove unneeded variables and setting value to 0 on zero initialised data and replace check for error with error_fatal. Rationalise loop that sets PCI config header fields read only. Signed-off-by: BALATON Zoltan Reviewed-by: Philippe Mathieu-Daud=C3=A9 Message-Id: Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/isa/vt82c686.c | 20 ++++++-------------- 1 file changed, 6 insertions(+), 14 deletions(-) diff --git a/hw/isa/vt82c686.c b/hw/isa/vt82c686.c index 0e812c49241..7e5fa060f5f 100644 --- a/hw/isa/vt82c686.c +++ b/hw/isa/vt82c686.c @@ -363,24 +363,16 @@ static void vt82c686b_isa_reset(DeviceState *dev) static void vt82c686b_realize(PCIDevice *d, Error **errp) { VT82C686BISAState *s =3D VT82C686B_ISA(d); - uint8_t *pci_conf; + DeviceState *dev =3D DEVICE(d); ISABus *isa_bus; - uint8_t *wmask; int i; =20 - isa_bus =3D isa_bus_new(DEVICE(d), get_system_memory(), - pci_address_space_io(d), errp); - if (!isa_bus) { - return; - } + isa_bus =3D isa_bus_new(dev, get_system_memory(), pci_address_space_io= (d), + &error_fatal); =20 - pci_conf =3D d->config; - pci_config_set_prog_interface(pci_conf, 0x0); - - wmask =3D d->wmask; - for (i =3D 0x00; i < 0xff; i++) { - if (i <=3D 0x03 || (i >=3D 0x08 && i <=3D 0x3f)) { - wmask[i] =3D 0x00; + for (i =3D 0; i < PCI_CONFIG_HEADER_SIZE; i++) { + if (i < PCI_COMMAND || i >=3D PCI_REVISION_ID) { + d->wmask[i] =3D 0; } } =20 --=20 2.26.2