From nobody Wed Feb 11 01:00:08 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.51 as permitted sender) client-ip=209.85.221.51; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f51.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.51 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1613918240; cv=none; d=zohomail.com; s=zohoarc; b=OcSISKmXwdrTrI9G8Xe5WVz9wGXUg8EsyMG03mAsaoxAyOdmUQqRD9YHMX/zNDoH0l/jL0zgOZ9e1fMcSDdzzcGw7Q6IBX2jF3FAuPFjB3N7Ox+TcqsakWur5jOocNsTH0Xelr6Cr1w7QzbIevAdQImhiPGrPZUWA465lvEMMLc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1613918240; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=x9cE1zBzoVv13k5JjDSc8/IbSReFDXfoX7UFR/I2zeM=; b=PczmIzySiA+HslxvhSgp/p80KQ4DGSxw724m+gGtB9Phjt4zTi4/GrhezOb9ts+340BEc8KWipJWID+PQIIjNUh+4aNqpJoVpR4WYQAz+Qq9c/7JzcFR39JFOQ5Hc+erAKKmdyOZe2PP+yGOeueyQ6CJcDNGBpsBy0Eh3poFRlE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.51 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) by mx.zohomail.com with SMTPS id 1613918240369337.03177177596353; Sun, 21 Feb 2021 06:37:20 -0800 (PST) Received: by mail-wr1-f51.google.com with SMTP id b3so16337200wrj.5 for ; Sun, 21 Feb 2021 06:37:19 -0800 (PST) Return-Path: Return-Path: Received: from localhost.localdomain (68.red-83-57-175.dynamicip.rima-tde.net. [83.57.175.68]) by smtp.gmail.com with ESMTPSA id n5sm20626459wmq.7.2021.02.21.06.37.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 21 Feb 2021 06:37:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=x9cE1zBzoVv13k5JjDSc8/IbSReFDXfoX7UFR/I2zeM=; b=Jxyly28LjAA+m7WMXz3VkeZJKj+1I0IQILxbwMnJLTLSwc0gGlcfAJHKjxJVpW2R1m up3Fu8Wv2yqnTqi5kRorauIxv5pvDISvYsAKnuNvknZ3lqlBHjgklFsiGBZ8p5mLRpGI I5uif8hmVoLt+DDSvfoLjfG+E4nAspYFDKPhh5U9gpkbc6E98L/8CYRTAjjl2V77JTvt KGD4ma1MKXPmUPb8OI/DhflAQAYp47ScjQksCVHkc6J18wPP+NlwFox9cu6eLivqYb3g SziggGdTJpE8chov4qIm+qs7C4V43QxVWPoW2OxvlZRncq0KTPolbVHifrzSOKNAN/aO jE4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=x9cE1zBzoVv13k5JjDSc8/IbSReFDXfoX7UFR/I2zeM=; b=uPgaPy1B6FzaRnsZRnAhOsRmCf+8+DvpZbTEknI585ZQcGOuqo83Fcku7JoJP3AqVB jp9HeWcsRI62mkRh+A+yrGEtCblUUGzsx4QyTtFzeEYW6KXsUvy8FksFTEcDJr2e/rVP t/JqHS0B6b3mGT30gBIW8G5muDh464gg4dm9/sOLUJSkHgNrKJdECgt/Ek0LBILcwv48 fJ3icggzfPgo+X4uWsXG+HhLbwYr//+WsPtSjPP+Q38wLDk9CQVf7AapWUqsuvmenKP/ ll3JyhsVIbnR2vIhhoUMgttIuUdv/v2qk2J5bqmKhYlJvxxVmUDnnsAeR2jiTW149TZP 2gqw== X-Gm-Message-State: AOAM530kuBP0nrMrENpk1rc3RqAalmA2L8RS8NrIrj8sLLX99/uegRo3 v2AnsiY0vC7gD4YjFSXPNok= X-Google-Smtp-Source: ABdhPJxxZFdQWjQL50Uep4LIQyICYd6ny+mTU3AnDBKR+HTZrROuGqmbD2TRDX8sKW8JDwnd49FM4w== X-Received: by 2002:adf:fe0d:: with SMTP id n13mr1414282wrr.224.1613918238691; Sun, 21 Feb 2021 06:37:18 -0800 (PST) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Paul Burton , Wainer dos Santos Moschetta , Aleksandar Rikalo , Aurelien Jarno , Marcel Apfelbaum , Cleber Rosa , "Michael S. Tsirkin" , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Huacai Chen , Jiaxun Yang , BALATON Zoltan Subject: [PULL 33/43] vt82c686: Correctly reset all registers to default values on reset Date: Sun, 21 Feb 2021 15:34:22 +0100 Message-Id: <20210221143432.2468220-34-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210221143432.2468220-1-f4bug@amsat.org> References: <20210221143432.2468220-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) From: BALATON Zoltan Reset the registers in the DeviceReset() handler which is called on each device reset, not in DeviceRealize() which is called once. Bit 0 of 'Power Mgmt I/O Base' register (offset 0x48) is always set. Signed-off-by: BALATON Zoltan Message-Id: Reviewed-by: Philippe Mathieu-Daud=C3=A9 [PMD: Split original patch, this is part 3/4 (move to reset), document] Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/isa/vt82c686.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/isa/vt82c686.c b/hw/isa/vt82c686.c index fe8ae24c421..48ead5af551 100644 --- a/hw/isa/vt82c686.c +++ b/hw/isa/vt82c686.c @@ -149,9 +149,12 @@ static void vt82c686b_pm_reset(DeviceState *d) { VT686PMState *s =3D VT82C686B_PM(d); =20 + memset(s->dev.config + PCI_CONFIG_HEADER_SIZE, 0, + PCI_CONFIG_SPACE_SIZE - PCI_CONFIG_HEADER_SIZE); + /* Power Management IO base */ + pci_set_long(s->dev.config + 0x48, 1); /* SMBus IO base */ pci_set_long(s->dev.config + 0x90, 1); - s->dev.config[0xd2] =3D 0; =20 smb_io_space_update(s); } @@ -166,9 +169,6 @@ static void vt82c686b_pm_realize(PCIDevice *dev, Error = **errp) pci_set_word(pci_conf + PCI_STATUS, PCI_STATUS_FAST_BACK | PCI_STATUS_DEVSEL_MEDIUM); =20 - /* 0x48-0x4B is Power Management I/O Base */ - pci_set_long(pci_conf + 0x48, 0x00000001); - pm_smbus_init(DEVICE(s), &s->smb, false); memory_region_add_subregion(pci_address_space_io(dev), 0, &s->smb.io); memory_region_set_enabled(&s->smb.io, false); --=20 2.26.2