From nobody Tue Feb 10 20:07:37 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.49 as permitted sender) client-ip=209.85.221.49; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f49.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.49 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1613918185; cv=none; d=zohomail.com; s=zohoarc; b=GUTM21nMxwg/+PJWryu1kloZXDu/a4o8+VRCy9AjDAqv2lKeuyX01ATr50GTM/Zb49peVawLi+uc8q/G8WMQVgyUeGygUD0c/cPENY6EqOcDQ9prIcKPfsnmKHcO08nlSJti21aeS9u7XgOgDlpZSzuriHjD1k3OdA3M2xZKlGo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1613918185; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=mTEXW5LTfQRgc4V4bZmD0GoSDNu+cidmCKPRdeIGV08=; b=AhzY9oV2HKDYownNha9DPdaTOKxWZl4G3wNp7aD4HQd6/PqrO86kEwcvqgAuur7KBpQjIs1ciA+ZAx/4UKkHvLPkVbMSe3IEwvqHoeOYcgYzOLyMjZYTKj8DtzTwzG3gLnYDO6uqRMVhMDOTXrPbUdcK9RRkkg/AAm0Jo8f0nmU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.49 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) by mx.zohomail.com with SMTPS id 1613918185161443.7536658345384; Sun, 21 Feb 2021 06:36:25 -0800 (PST) Received: by mail-wr1-f49.google.com with SMTP id 7so16362520wrz.0 for ; Sun, 21 Feb 2021 06:36:24 -0800 (PST) Return-Path: Return-Path: Received: from localhost.localdomain (68.red-83-57-175.dynamicip.rima-tde.net. [83.57.175.68]) by smtp.gmail.com with ESMTPSA id t74sm26718292wmt.45.2021.02.21.06.36.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 21 Feb 2021 06:36:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=mTEXW5LTfQRgc4V4bZmD0GoSDNu+cidmCKPRdeIGV08=; b=TnzcuOE1b81LtnLzK1sU+dvhOL97LY4FhYz5yljj7nDTcYZTqiWUkaaHXve2+TK6un yjE7xpVItCCo4anRS+YB/eRQPu8ls1D93DcvjEHUDudAnILeFXCFlOzqqJ8iz9uleZX5 EIzrcS2gWOtrTWyX1k1PYJKeivKihVS5yBggs/RevPXsgVibPYgx7hvbbrCw8zcrKGwP J5ee1Di5slxGXa/hsqingnrYcQhZi9ZZ6ISuYM9aJAW05zc6c2vUZJ1/bCiju0lNm1IN MMeOKmBMjPFmhS2txAi78I3VdqzaKox/Q1n9bgW9dHfiwLd9KEljxAZG98lZNhvK7AY2 qz7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=mTEXW5LTfQRgc4V4bZmD0GoSDNu+cidmCKPRdeIGV08=; b=pu4zg8QO0JuJa5bpqadzbpGdFMX3w2hW/65CQ091isNna/1YagjMaB3muIkm2EtFiE wH2qFNETo00pec/YhfnLLr6MO0QhyfmsbKP6X9gWc0RdlzlxueQE7smxPlK8qzXDoEN0 R9Pd8N2LmjtnElW3TFPmBtw5BtgC/U5LSJPblHAZT+6xjTyHIzjFp19y2dGx0Jz2fVag n98uF1SH4Y++h/duaP6AFAnHp59XFOpnpFnDquaBQzURad6UsDVqsYKcBg0W69ipTrbK JurNb5J+at91WcVLyW0i4lIxkPc4vhkHpkTwlBQEFXng+Q4sOhQX1DvKWO+ci3FxcJCY T2gA== X-Gm-Message-State: AOAM532eIJL69Gn/VUTHtxrSLt1yF2nCplstiu54H4oNCh0tts/774kV 9cc1VQ/zQqez03g/0tJ6ZzM= X-Google-Smtp-Source: ABdhPJxwbIIBDKT9Dlr1h05GaMkVlm59OycVz8htDJPwwAZX2o3Pnjzu5H4zIygUl6HPqQRoto2XWQ== X-Received: by 2002:a5d:5441:: with SMTP id w1mr17587242wrv.366.1613918183462; Sun, 21 Feb 2021 06:36:23 -0800 (PST) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Paul Burton , Wainer dos Santos Moschetta , Aleksandar Rikalo , Aurelien Jarno , Marcel Apfelbaum , Cleber Rosa , "Michael S. Tsirkin" , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Huacai Chen , Jiaxun Yang Subject: [PULL 22/43] target/mips: Include missing "tcg/tcg.h" header Date: Sun, 21 Feb 2021 15:34:11 +0100 Message-Id: <20210221143432.2468220-23-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210221143432.2468220-1-f4bug@amsat.org> References: <20210221143432.2468220-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) Commit 83be6b54123 ("Fix MSA instructions LD. on big endian host") introduced use of typedef/prototypes declared in "tcg/tcg.h" without including it. This was not a problem because "tcg/tcg.h" is pulled in by "exec/cpu_ldst.h". To be able to remove this header there, we first need to include it here in op_helper.c, else we get: [222/337] Compiling C object libqemu-mips-softmmu.fa.p/target_mips_msa_he= lper.c.o target/mips/msa_helper.c: In function =E2=80=98helper_msa_ld_b=E2=80=99: target/mips/msa_helper.c:8214:9: error: unknown type name =E2=80=98TCGMem= OpIdx=E2=80=99 8214 | TCGMemOpIdx oi =3D make_memop_idx(MO_TE | DF | MO_UNALN, = \ | ^~~~~~~~~~~ target/mips/msa_helper.c:8224:5: note: in expansion of macro =E2=80=98MEM= OP_IDX=E2=80=99 8224 | MEMOP_IDX(DF_BYTE) | ^~~~~~~~~ target/mips/msa_helper.c:8214:26: error: implicit declaration of function= =E2=80=98make_memop_idx=E2=80=99 [-Werror=3Dimplicit-function-declaration] 8214 | TCGMemOpIdx oi =3D make_memop_idx(MO_TE | DF | MO_UNALN, = \ | ^~~~~~~~~~~~~~ target/mips/msa_helper.c:8227:18: error: implicit declaration of function= =E2=80=98helper_ret_ldub_mmu=E2=80=99 [-Werror=3Dimplicit-function-declara= tion] 8227 | pwd->b[0] =3D helper_ret_ldub_mmu(env, addr + (0 << DF_BYTE= ), oi, GETPC()); | ^~~~~~~~~~~~~~~~~~~ cc1: all warnings being treated as errors Signed-off-by: Philippe Mathieu-Daud=C3=A9 Message-Id: <20210207232310.2505283-4-f4bug@amsat.org> --- target/mips/msa_helper.c | 1 + 1 file changed, 1 insertion(+) diff --git a/target/mips/msa_helper.c b/target/mips/msa_helper.c index 1298a1917ce..4caefe29ad7 100644 --- a/target/mips/msa_helper.c +++ b/target/mips/msa_helper.c @@ -20,6 +20,7 @@ #include "qemu/osdep.h" #include "cpu.h" #include "internal.h" +#include "tcg/tcg.h" #include "exec/exec-all.h" #include "exec/helper-proto.h" #include "exec/memop.h" --=20 2.26.2