From nobody Wed Feb 11 00:59:56 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.221.50 as permitted sender) client-ip=209.85.221.50; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-f50.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.50 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1613918150; cv=none; d=zohomail.com; s=zohoarc; b=c0feIVC+Eac8uXITdI7x18hv5JxKf4S7g79AYVR8XIOaxCJ/NWaa1aImYV0qDZ9epf50/N36XT2wl7dYijWLhOiX5pftaMH/NTfyI0/hqj0j1UbrzykjC2EeQ2tha2nL0m60ngwvSNIg2y02Q1CH0nO1eoSpyAsfpAzBmBUzlt8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1613918150; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=D6VYexV1cpoyJ2slRh52R88zZ65uYGwbs5LIn6CZfrA=; b=CV0rHnGCWlonhlUNZeDsARI3e2EhUiYv3pC5HPO1QmCxF33ApbHp9uVCigIGd5k3Pud1kWCEm5ALEGvlUWO2lr1ekh59Z3wOkfBBPs5+Zs0HoDreDI8h1kPS0mvNa1VBYQdVTdCwgs8Mvx4xgcWQFfv6lm2vAEAxNLeUZP2OFnw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.221.50 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) by mx.zohomail.com with SMTPS id 1613918150558708.5531614333348; Sun, 21 Feb 2021 06:35:50 -0800 (PST) Received: by mail-wr1-f50.google.com with SMTP id h98so11532684wrh.11 for ; Sun, 21 Feb 2021 06:35:50 -0800 (PST) Return-Path: Return-Path: Received: from localhost.localdomain (68.red-83-57-175.dynamicip.rima-tde.net. [83.57.175.68]) by smtp.gmail.com with ESMTPSA id z13sm2276073wrh.65.2021.02.21.06.35.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 21 Feb 2021 06:35:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=D6VYexV1cpoyJ2slRh52R88zZ65uYGwbs5LIn6CZfrA=; b=Kwc3YhJ2HVeRK47bimLkMJdPy5Al26U2B4fn2XwD2+siH1013miOzfuclWO8ZWPmda YvNEZ3H3gwGXzJVk7A8zM/jINq+gCQ32tcyOHkL/hHub3Fb4oPm6iNU8Z8wZTuamwZgy FuHlTsUr4Gu+y3rp0Ao0q4qQt7JBfkmgtxOn6iQXVXJZNj9fx0CERvwkmmaGR7lnl17H oS8YjmMYLK622i5MoEXlcCGI6w3u6+lJ00YQoiQAceKqpYeD1oRUjNhVTw9zhL1bRlLu XPfuyuvzRsXtj1tYHrqmyY/MLX84MbWF69ktWsNK44uo6ldEsg2751xlEfTTJN4Eg3YE 0xXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=D6VYexV1cpoyJ2slRh52R88zZ65uYGwbs5LIn6CZfrA=; b=G32wSPM7eWtgFG5ehmSQ+9HmitGDRvtkCMJe+nzSmq2VQeWZhYZYY2qn1xsFXTlLau FHYWVKAnmOpKPBCcVMty2eNtF2r3T5oqLGd9YLmghDdxgIwBrKwrN303Yui1bs7fSlQE lAGp5+ZkBuMC01olsWlvKEutG+N30MVk04qPgzbvBGStD7/7QFFbLkpGQLPCtD7YCCCE 03pRSr+iE1fAOPkFm37iewBmZXjR28mYI6E9IpfkK+Wg7P4Las/NdS+6mL+ljrJgKgwS iX6R+LyOEZ2uEO3J9WEIOPiBaZMfnoNhm+2V0xAeb+uUFdmUqS+VcoZmLBWsL3a+bRPB MRPA== X-Gm-Message-State: AOAM530TSmPUj3HlN0Ri+4lafNSb4mTX1VT5gBaWgN2dd5GPBasKX15X 8sWH7f6JSFu2Yyo4ZC2kgBs= X-Google-Smtp-Source: ABdhPJy42raJalYXebbYQkkHS1WUscl2cCV7GhsKnBJILSGWF3l4V3XaPcN0KLBG9iyt1eSqyMV5hw== X-Received: by 2002:adf:ef86:: with SMTP id d6mr17695840wro.419.1613918148911; Sun, 21 Feb 2021 06:35:48 -0800 (PST) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Paul Burton , Wainer dos Santos Moschetta , Aleksandar Rikalo , Aurelien Jarno , Marcel Apfelbaum , Cleber Rosa , "Michael S. Tsirkin" , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Huacai Chen , Jiaxun Yang , Richard Henderson Subject: [PULL 15/43] target/mips: Let do_translate_address() take MMUAccessType argument Date: Sun, 21 Feb 2021 15:34:04 +0100 Message-Id: <20210221143432.2468220-16-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210221143432.2468220-1-f4bug@amsat.org> References: <20210221143432.2468220-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) The single caller, HELPER_LD_ATOMIC(), passes MMUAccessType to do_translate_address(). Let the prototype use it as argument, as it is stricter than an integer. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson Reviewed-by: Jiaxun Yang Message-Id: <20210128144125.3696119-9-f4bug@amsat.org> --- target/mips/op_helper.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/target/mips/op_helper.c b/target/mips/op_helper.c index 9fce0194b3e..b80e8f75401 100644 --- a/target/mips/op_helper.c +++ b/target/mips/op_helper.c @@ -288,13 +288,14 @@ target_ulong helper_rotx(target_ulong rs, uint32_t sh= ift, uint32_t shiftx, #ifndef CONFIG_USER_ONLY =20 static inline hwaddr do_translate_address(CPUMIPSState *env, - target_ulong address, - int rw, uintptr_t re= taddr) + target_ulong address, + MMUAccessType access_type, + uintptr_t retaddr) { hwaddr paddr; CPUState *cs =3D env_cpu(env); =20 - paddr =3D cpu_mips_translate_address(env, address, rw); + paddr =3D cpu_mips_translate_address(env, address, access_type); =20 if (paddr =3D=3D -1LL) { cpu_loop_exit_restore(cs, retaddr); --=20 2.26.2