From nobody Tue Feb 10 06:59:01 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.218.49 as permitted sender) client-ip=209.85.218.49; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-ej1-f49.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.218.49 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1613780031; cv=none; d=zohomail.com; s=zohoarc; b=ake7GY60uQd+jW1Vm4YkGlShpOL6v+f7D7mLV41MPAOvjcm7skl1p6Lkqz4m4H3iS56ElWHgkAH0MEu1bOYOb/66+Jw2zeul2Ojzrw38zRXo30brcyWJy/LSbSW8bfQXUY14CCeRaI4L2F9sffD7W0kox8/JkPfrjTgQ9hZpimA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1613780031; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=oGPDZTaV0ikSGAYkSsSAAwTyV1EcBkuaVgyp/NFAuhI=; b=UHN5n0MJPr3nl9ESAJ8UDKK/P97DOSqYbEJ9bDwm/2zHSLgEiHJeMuwLGotWP97Ivs4hDB/LNL1HU5j1D5OTjac7NuoEERzkOVyfXuHTFKcFXGG2o9eB3pEzzZPXQIOYJUFKswrUnGjXmgu3EY4gPzV/sUAOuq4RVJy9UhfYBxU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.218.49 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-ej1-f49.google.com (mail-ej1-f49.google.com [209.85.218.49]) by mx.zohomail.com with SMTPS id 1613780031016279.8812047130838; Fri, 19 Feb 2021 16:13:51 -0800 (PST) Received: by mail-ej1-f49.google.com with SMTP id lu16so16843608ejb.9 for ; Fri, 19 Feb 2021 16:13:50 -0800 (PST) Return-Path: Return-Path: Received: from x1w.redhat.com (68.red-83-57-175.dynamicip.rima-tde.net. [83.57.175.68]) by smtp.gmail.com with ESMTPSA id bz20sm5666154ejc.28.2021.02.19.16.13.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Feb 2021 16:13:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=oGPDZTaV0ikSGAYkSsSAAwTyV1EcBkuaVgyp/NFAuhI=; b=T7Dy+sGGWdm05YCG8xIboJpe+caUC17ZEB/Bai9RWD00PjwhfhMWNCUI82vQAwSK4z ZJD3uDw+Dn5U1q4kgRq8H7y7vSu0fuwW1iNMXZ1Rm/NKndq2b7DcBgm+AXyqZbcC6TPm eN9eqOE/ZmOFCjueVnxNYw3yv9htkN7uQUdDEpRExeejd3mm73ivHLl+ntztuzecS7X7 EEqursh43LM5RxbCTbiuNtURsKXs2cYea6O2gnNO/UJkMF1OwBSRo0wC9jdn/WYaIgwv GD525xKLm2QIVkPSu+iRFEvsR44M1egYdxbnhTO1ceBlle7R9ussYcuuZ9zzqkYhE7QH tmQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=oGPDZTaV0ikSGAYkSsSAAwTyV1EcBkuaVgyp/NFAuhI=; b=P5/bh/+3xAGcZr1maQTLY758NPHdvU1Gm9sJ0qw9pp6ji7uDdS20gdjh4P8jV572IX bl2ocVN/mLbKVLlckh5xphyRpfvtmj9WCSaJfraEXjUWVfRx5bWXb8Flr8UYbwaqqARW 3cypBVbRATWHqyo02jzhcaCzyU86MLEZcLundH/AUHJwxysJ99ZZNshTE/xsRuModnnl ncTSfjjYrX0h59qwo04adpnMZ4Cr9/wh7nZrqj2tTTGy9KxZhuTv2mS7hw7pxA7JsYFF WXcqZn+McA3gsa2jaVTQ/r4YGM5ih1SnKUbOxSvMQek1VZqn33zCQY5FyZGfsRNCgd3c Z4Yg== X-Gm-Message-State: AOAM531olCMbCyvBK2N6ebtSCvhk74B79IHkqZ+VALRFe2kuRT/P+sDX 8gejcuEnP/jhhVL923n2O64= X-Google-Smtp-Source: ABdhPJwgW+/hOEULvSwJxsLnWdLkxFnsH7do3LOmKTuVScmAso0HPG13Jj/y0Pki8795P+mL0Oktsg== X-Received: by 2002:a17:906:a090:: with SMTP id q16mr10853089ejy.236.1613780029307; Fri, 19 Feb 2021 16:13:49 -0800 (PST) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Bin Meng , qemu-block@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PULL 07/18] hw/sd: ssi-sd: Fix SEND_IF_COND (CMD8) response Date: Sat, 20 Feb 2021 01:12:58 +0100 Message-Id: <20210220001309.2225022-8-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210220001309.2225022-1-f4bug@amsat.org> References: <20210220001309.2225022-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) From: Bin Meng The SEND_IF_COND command (CMD8) response is of format R7, but current code returns R1 for CMD8. Fix it. Fixes: 775616c3ae8c ("Partial SD card SPI mode support") Signed-off-by: Bin Meng Reviewed-by: Philippe Mathieu-Daud=C3=A9 Message-Id: <20210128063035.15674-8-bmeng.cn@gmail.com> Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/sd/ssi-sd.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/sd/ssi-sd.c b/hw/sd/ssi-sd.c index 200e885225a..84c873b3fd4 100644 --- a/hw/sd/ssi-sd.c +++ b/hw/sd/ssi-sd.c @@ -176,9 +176,9 @@ static uint32_t ssi_sd_transfer(SSIPeripheral *dev, uin= t32_t val) s->arglen =3D 1; s->response[0] =3D 4; DPRINTF("SD command failed\n"); - } else if (s->cmd =3D=3D 58) { - /* CMD58 returns R3 response (OCR) */ - DPRINTF("Returned OCR\n"); + } else if (s->cmd =3D=3D 8 || s->cmd =3D=3D 58) { + /* CMD8/CMD58 returns R3/R7 response */ + DPRINTF("Returned R3/R7\n"); s->arglen =3D 5; s->response[0] =3D 1; memcpy(&s->response[1], longresp, 4); --=20 2.26.2