From nobody Tue Feb 10 10:07:56 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.208.52 as permitted sender) client-ip=209.85.208.52; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-ed1-f52.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.208.52 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1613780026; cv=none; d=zohomail.com; s=zohoarc; b=fs1OobZHwRiZeMaM0jYbrFGBigkQMfNLC5W7RgW3mfMFXMtd0BhF0PEQoAVLmwe25MFa6u0yyTYhC0/XjUoImJ7Xl8RkK/EmCuFmsz1dXIvEBF1n1RKSEcqLfm+5yjSHJb6XirAcwuCsLPoKHuYcQGA8Pz55FhemgHS5MAPLryg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1613780026; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=02M7HfeR1O9C/gJijTKiVQeyuhKE0/PPtd8pPEOGOuk=; b=nHPI7+j+k9rUJI1Pauw+djWaa8xwSKaEUWFjiD69OzYAT2TQWVAQjadf6oGzMsNyh0XGZHw+M7DRWyjeDNkEezLIxt803lkBgYvyr10wQUXSM/8aN7y0/eJz9klId8LVv5GRpi2vP/rXBhJFTfYzLzh8LbL3xP8iszYQ685SwUY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.208.52 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-ed1-f52.google.com (mail-ed1-f52.google.com [209.85.208.52]) by mx.zohomail.com with SMTPS id 1613780025866342.8906798697981; Fri, 19 Feb 2021 16:13:45 -0800 (PST) Received: by mail-ed1-f52.google.com with SMTP id v22so12633275edx.13 for ; Fri, 19 Feb 2021 16:13:45 -0800 (PST) Return-Path: Return-Path: Received: from x1w.redhat.com (68.red-83-57-175.dynamicip.rima-tde.net. [83.57.175.68]) by smtp.gmail.com with ESMTPSA id t4sm2378460edw.24.2021.02.19.16.13.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Feb 2021 16:13:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=02M7HfeR1O9C/gJijTKiVQeyuhKE0/PPtd8pPEOGOuk=; b=Sk32K2oPN0bBLFaOwRWSGrzA4pjWUcI1bqGBnMqN3i8YKe7Gvn794AnhOU6OEx5nuH RzQgFSHhBzhgmhDdZEFX2ycQg9PDKfCXbwdL8md4EyHvtkOE91H4cjrEf/g9G3k5P+nR AaQJmy4ev8HYOa6ET2ciPjyXOLNKKi/vLu+nojQrd7llj/3rCcXm/DtsQAEGroW0WJV9 16OU9lr8oU9anZhDtHgnpcNoLwONp8mSkOnBJ2VqQaVnWJmrgCCUE9205zVFSgwotsRD D49KQ+mSJO9pBj6VFBf7O+wAaq3nFDWARQujQ4s+Rwg8TvAnGuWxbR0aosF5QXPXljum dDTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=02M7HfeR1O9C/gJijTKiVQeyuhKE0/PPtd8pPEOGOuk=; b=q4NNObxFLotKYJ6jA+hxSTe0hbsC9Xm8/pbxsHSKIMtB4dMV+DHuPRS+0Xiwoz/yWd E+fkLQvPIouR/E5WmGDMIqZlb1FmHbu4IQfqprJp1Olb6RN00d/e/IhvPCdFeZpJndcN zK67pYs765DVXCqQ8tyRHqncwePUEB7DVTKM3uLQwnCi5zFsu5ff9xrAKBuqdb7vRlyZ DZGEVkS03ATdHVlieNHzJvLj64tweMsDHtyND7pIboqgnXg7/HT3AEVJu34kg/MQMkSW wUq80JzIFwLNGNcoskDQqse0Ns4BmBAcz+c2UPv/sdEHhkv5NKYfraA6CuCaZJ/S+f5u DIrg== X-Gm-Message-State: AOAM533cYx87YTvpqPZ/9+d+HPV6Wz7gBaSGnyAyNmsE+0sNzKJQLyPq plHMD4umEIyja9oVgaRi+uE= X-Google-Smtp-Source: ABdhPJxIGurQM15Myq8VdqH7/rDLBbQvd3BzeufolaizPYsGw3Cg7WG8WPknoM/lGv+au7JWDW98Dg== X-Received: by 2002:a50:fa89:: with SMTP id w9mr11475465edr.22.1613780024115; Fri, 19 Feb 2021 16:13:44 -0800 (PST) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Bin Meng , qemu-block@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Alistair Francis Subject: [PULL 06/18] hw/sd: ssi-sd: Support multiple block write Date: Sat, 20 Feb 2021 01:12:57 +0100 Message-Id: <20210220001309.2225022-7-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210220001309.2225022-1-f4bug@amsat.org> References: <20210220001309.2225022-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) From: Bin Meng For a multiple block write operation, each block begins with a multi write start token. Unlike the SD mode that the multiple block write ends when receiving a STOP_TRAN command (CMD12), a special stop tran token is used to signal the card. Emulating this by manually sending a CMD12 to the SD card core, to bring it out of the receiving data state. Signed-off-by: Bin Meng Tested-by: Philippe Mathieu-Daud=C3=A9 Acked-by: Alistair Francis Message-Id: <20210128063035.15674-7-bmeng.cn@gmail.com> Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/sd/ssi-sd.c | 33 +++++++++++++++++++++++++++++++-- 1 file changed, 31 insertions(+), 2 deletions(-) diff --git a/hw/sd/ssi-sd.c b/hw/sd/ssi-sd.c index 1205ad8b52c..200e885225a 100644 --- a/hw/sd/ssi-sd.c +++ b/hw/sd/ssi-sd.c @@ -4,6 +4,11 @@ * Copyright (c) 2007-2009 CodeSourcery. * Written by Paul Brook * + * Copyright (c) 2021 Wind River Systems, Inc. + * Improved by Bin Meng + * + * Validated with U-Boot v2021.01 and Linux v5.10 mmc_spi driver + * * This code is licensed under the GNU GPL v2. * * Contributions after 2012-01-13 are licensed under the terms of the @@ -82,6 +87,10 @@ OBJECT_DECLARE_SIMPLE_TYPE(ssi_sd_state, SSI_SD) #define SSI_SDR_ADDRESS_ERROR 0x2000 #define SSI_SDR_PARAMETER_ERROR 0x4000 =20 +/* multiple block write */ +#define SSI_TOKEN_MULTI_WRITE 0xfc +/* terminate multiple block write */ +#define SSI_TOKEN_STOP_TRAN 0xfd /* single block read/write, multiple block read */ #define SSI_TOKEN_SINGLE 0xfe =20 @@ -94,6 +103,8 @@ OBJECT_DECLARE_SIMPLE_TYPE(ssi_sd_state, SSI_SD) static uint32_t ssi_sd_transfer(SSIPeripheral *dev, uint32_t val) { ssi_sd_state *s =3D SSI_SD(dev); + SDRequest request; + uint8_t longresp[16]; =20 /* * Special case: allow CMD12 (STOP TRANSMISSION) while reading data. @@ -125,8 +136,28 @@ static uint32_t ssi_sd_transfer(SSIPeripheral *dev, ui= nt32_t val) return SSI_DUMMY; break; case SSI_TOKEN_SINGLE: + case SSI_TOKEN_MULTI_WRITE: DPRINTF("Start write block\n"); s->mode =3D SSI_SD_DATA_WRITE; + return SSI_DUMMY; + case SSI_TOKEN_STOP_TRAN: + DPRINTF("Stop multiple write\n"); + + /* manually issue cmd12 to stop the transfer */ + request.cmd =3D 12; + request.arg =3D 0; + s->arglen =3D sdbus_do_command(&s->sdbus, &request, longresp); + if (s->arglen <=3D 0) { + s->arglen =3D 1; + /* a zero value indicates the card is busy */ + s->response[0] =3D 0; + DPRINTF("SD card busy\n"); + } else { + s->arglen =3D 1; + /* a non-zero value indicates the card is ready */ + s->response[0] =3D SSI_DUMMY; + } + return SSI_DUMMY; } =20 @@ -136,8 +167,6 @@ static uint32_t ssi_sd_transfer(SSIPeripheral *dev, uin= t32_t val) return SSI_DUMMY; case SSI_SD_CMDARG: if (s->arglen =3D=3D 4) { - SDRequest request; - uint8_t longresp[16]; /* FIXME: Check CRC. */ request.cmd =3D s->cmd; request.arg =3D ldl_be_p(s->cmdarg); --=20 2.26.2