From nobody Wed Feb 11 01:00:03 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.218.44 as permitted sender) client-ip=209.85.218.44; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-ej1-f44.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.218.44 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1613780078; cv=none; d=zohomail.com; s=zohoarc; b=k5JZAuz9nM7cUV7Rs1DEpr4fmtKMH6C0UjL9wZdWVOu5SEVnRzTTXtPO8vu57fT1ShLyJXASffFnbjS1uIXxpjKhhG0zZjy9GJ8k9G5xLnHCqiyk2ntTL2i6sXbWPpzblUtMhsJwT/zxXNvUlg2mAyQAAE27Ot2rqnJn06zHrLU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1613780078; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=Qh/0Ss/cVm5EwuEbhAfkwZcS/qVzMmiRGBnEd0cOA9M=; b=CrQgGStg6osL1zPJ4oNzKnJpSaQFrxWWOBnQQyHcVW3hTUSsJL4LPYm0H5u48wIvMrO1t9QPlDGh2nYNcyk5gvCoSaRDifWeSQeUZJJxK25eAE66Geh05e5O0YhBCA39mDYzY0cSrXcMqd4ji8g6byf9PfEn+pXuZeCFxS252eg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.218.44 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-ej1-f44.google.com (mail-ej1-f44.google.com [209.85.218.44]) by mx.zohomail.com with SMTPS id 1613780077724658.682540997569; Fri, 19 Feb 2021 16:14:37 -0800 (PST) Received: by mail-ej1-f44.google.com with SMTP id d8so16919887ejc.4 for ; Fri, 19 Feb 2021 16:14:37 -0800 (PST) Return-Path: Return-Path: Received: from x1w.redhat.com (68.red-83-57-175.dynamicip.rima-tde.net. [83.57.175.68]) by smtp.gmail.com with ESMTPSA id i18sm6027138edt.68.2021.02.19.16.14.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Feb 2021 16:14:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Qh/0Ss/cVm5EwuEbhAfkwZcS/qVzMmiRGBnEd0cOA9M=; b=WENlvlvSpzopF/e/Z5IR279XevIjs3VVJKxBNg3wVJDMGxaPT0k7PmtSrAcp1xvF1s TMqF5S2A20nYCEamCPtoJszE3wD35gS5xZUv4fCaPBXiuQMj/x5tvEHXgJpyq+uoH17n 0dxwj2BG3wEEsj62Bds/1yTBB8up+OTnaIzfNLoNyCj8qT4fxX/8O22ISiuxWeOvGB0r WRKvqM+DtUqwMj2Wfo85TM+nYif7erwWB8FYZTtjPFB67ZCxns93FQuqOPcotrsl+r30 N3+KheR38fTY2gMRopMNr0+6vRn3NyFwNljLSPe/SN5Ugu6DWNoJRfvx2D8Plj0mQU9n Y5kQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=Qh/0Ss/cVm5EwuEbhAfkwZcS/qVzMmiRGBnEd0cOA9M=; b=bbWSo8GmcxcQ7MBmKNrjTrutXwMuQ67xOSvB8ZrWMtKbchXOUa2QbbBHtzBnTuWq8i rH+B+5atrxj1eCp3AL2OxUPI70TcHTKAgfB/eTYX/eBV2dTljlKKEd3P1xnmNGCVA51I mpJLkUdVEMBqeQPPE/RdaAnMIibUd8wyr9Jg+pUhDrlXZ+pGVvsiSAVyh8CeetkrvZ3M HmaAn3J7+e/B9gysAw7brj2Ns+X3WOU2d2VgHrWKCBQhszbNFoepklWtqdvPIrZ3CJMS /coHu4lj5lxVTQKc8opFdCN5LWHNWen3WmWEO7+BpRIIA5HlDcBp2yqyqWR0d5MQ6USW 1llQ== X-Gm-Message-State: AOAM531FZ0VFrOm6fQY4bTpn6amOF2LvSi75qM3JyKH0ewX+7V5mnFr0 0ckJObFx85z4FvoQ7u64zvo= X-Google-Smtp-Source: ABdhPJx5jvqNcbIkJDaW5lB7B+zF2YB2Ldcpwkl47brphddQfdnAGaXUZQ2c204H+gZsI2gPS8/oEQ== X-Received: by 2002:a17:906:7d87:: with SMTP id v7mr7564939ejo.214.1613780075971; Fri, 19 Feb 2021 16:14:35 -0800 (PST) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Bin Meng , qemu-block@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PULL 16/18] hw/sd: sd: Bypass the RCA check for CMD13 in SPI mode Date: Sat, 20 Feb 2021 01:13:07 +0100 Message-Id: <20210220001309.2225022-17-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210220001309.2225022-1-f4bug@amsat.org> References: <20210220001309.2225022-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) From: Bin Meng Unlike SD mode, when SD card is working in SPI mode, the argument of CMD13 is stuff bits. Hence we should bypass the RCA check. See "Physical Layer Specification Version 8.00", chapter 7.3.1.3 Detailed Command Description (SPI mode): "The card shall ignore stuff bits and reserved bits in an argument" and Table 7-3 Commands and Arguments (SPI mode): "CMD13 Argument [31:0] stuff bits" Signed-off-by: Bin Meng Reviewed-by: Philippe Mathieu-Daud=C3=A9 Message-Id: <20210216150225.27996-9-bmeng.cn@gmail.com> Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/sd/sd.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/sd/sd.c b/hw/sd/sd.c index 3a515a5365f..8b397effbcc 100644 --- a/hw/sd/sd.c +++ b/hw/sd/sd.c @@ -1163,8 +1163,9 @@ static sd_rsp_type_t sd_normal_command(SDState *sd, S= DRequest req) case 13: /* CMD13: SEND_STATUS */ switch (sd->mode) { case sd_data_transfer_mode: - if (sd->rca !=3D rca) + if (!sd->spi && sd->rca !=3D rca) { return sd_r0; + } =20 return sd_r1; =20 --=20 2.26.2