From nobody Tue Feb 10 09:40:47 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of _spf.google.com designates 209.85.218.43 as permitted sender) client-ip=209.85.218.43; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-ej1-f43.google.com; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.218.43 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1613780052; cv=none; d=zohomail.com; s=zohoarc; b=LgyctodlpoZjDmhvTptPvk7xeXzbaskcahZLe0hQpxI8K0AhlnYDGaLTN/MkhDOJRAR3EnSz3GfnwsoQTkwyO6qWbHagwpqDwlbpdOk5BaeMF/CiAXfm5LI+3JmEZMyDpsvTjXj0JEJ4XPzp3dzeYnpj/uX1YQOQ0DXNqDleTS8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1613780052; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Sender:Subject:To; bh=Fy9SqTT3Pn6dnjUOO63fiY72ONZWC5VONbRFMJ3FRcE=; b=hUgypI+DPeWPI7MTFdXHhXbxqskbig38xLwZ+t0+JOOTrOQi6vt6ITlBV3aTeaCMmC0l4CSloFatEhN8a79DX+aYJKV8hC/UMNHp1K0fAriqvGu7moWNtkpedvVmAF1QDbSumKVQ1RZDfFCyXOPY3exGaHEZrCw+zj+5DG7CTGA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of _spf.google.com designates 209.85.218.43 as permitted sender) smtp.mailfrom=philippe.mathieu.daude@gmail.com Received: from mail-ej1-f43.google.com (mail-ej1-f43.google.com [209.85.218.43]) by mx.zohomail.com with SMTPS id 161378005197321.90220213883208; Fri, 19 Feb 2021 16:14:11 -0800 (PST) Received: by mail-ej1-f43.google.com with SMTP id t11so16890783ejx.6 for ; Fri, 19 Feb 2021 16:14:11 -0800 (PST) Return-Path: Return-Path: Received: from x1w.redhat.com (68.red-83-57-175.dynamicip.rima-tde.net. [83.57.175.68]) by smtp.gmail.com with ESMTPSA id r23sm5774296edp.34.2021.02.19.16.14.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Feb 2021 16:14:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Fy9SqTT3Pn6dnjUOO63fiY72ONZWC5VONbRFMJ3FRcE=; b=TswmdrwOJrMQUYVUhYL49m9C86/WnHdBw03bfxBqvcMjasokaLaRQO/Xe8eJEVTBSt cw+exWhCfvmo1cN+mGctC+9qrAkYO43s1RYWg66Efz26cJ91jSvg5Jc0/d0OhPZe/OOu VvaCamZbilIzh3iTnNkKWYBpJ3e7Y1tGZsrBLdUEn72ootnxOQsb/7BszD4J88I0aEUU BU35YATAnSLpobhtZ2lcw2Sv9cPQdPlOhAW3rrChC7PDbhMDYyToC/b/UECCwdXPEthQ ez0yppPDph87vqS0M/jb/HVVXNe93IY3HiWY9abGKS9NBmIkYmq3a7rYSq7lrtgEg8MD AadQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=Fy9SqTT3Pn6dnjUOO63fiY72ONZWC5VONbRFMJ3FRcE=; b=IVSTtozXMrUGRZ4MaGPomc6AzVBxOzwjtnf6wMWOQi696UFKPc95vv8kkgDD3sbRr9 eQweumyUdKngdovT8qsQfwglPGDXJr3HJM4HK1qWAXPJfsvlsFPUM6NFl6z+ryKT7mcp xoWjGERrEkrJ5MsmXAV94Zq7ajejHoUHwE/LpOb3NwoOviBSLYW8J4OEw4q1bnWJGAw9 LnuyMfZWEayvJLuJPQz4RbwuDWgdLzjt+ebq8AoqOyehk2Xv3DCsI0e3BNb6VOfP0WsB eXCHqNBHkMLMcax8xkLADigkXeF8RVFSxde0Rjk5hpsRDViiHVQjkR2cvnmDoEsjmWEQ a2mg== X-Gm-Message-State: AOAM532bXxKSqiJ1YTpa7pXLLluG/YG0tVBe5D/ez++tPRu+y1Ys4Nrq ef6VKev1a0J+gwW2J6FqWFk= X-Google-Smtp-Source: ABdhPJwZj7y0U83TUCnOve8zdFimlXLondbECqMCeYkqM71lT/qWRctgHTUjErOMTmvHY3/uDGRFiA== X-Received: by 2002:a17:906:240c:: with SMTP id z12mr10942774eja.314.1613780050256; Fri, 19 Feb 2021 16:14:10 -0800 (PST) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Bin Meng , qemu-block@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PULL 11/18] hw/sd: sd: Only SDSC cards support CMD28/29/30 Date: Sat, 20 Feb 2021 01:13:02 +0100 Message-Id: <20210220001309.2225022-12-f4bug@amsat.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210220001309.2225022-1-f4bug@amsat.org> References: <20210220001309.2225022-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @gmail.com) From: Bin Meng Per the "Physical Layer Specification Version 8.00", table 4-26 (SD mode) and table 7-3 (SPI mode) command descriptions, the following commands: - CMD28 (SET_WRITE_PROT) - CMD29 (CLR_WRITE_PROT) - CMD30 (SEND_WRITE_PROT) are only supported by SDSC cards. Signed-off-by: Bin Meng Reviewed-by: Philippe Mathieu-Daud=C3=A9 Message-Id: <20210216150225.27996-3-bmeng.cn@gmail.com> Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/sd/sd.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/hw/sd/sd.c b/hw/sd/sd.c index 7adcb4edfaa..dd1ce0bdae4 100644 --- a/hw/sd/sd.c +++ b/hw/sd/sd.c @@ -1284,6 +1284,10 @@ static sd_rsp_type_t sd_normal_command(SDState *sd, = SDRequest req) =20 /* Write protection (Class 6) */ case 28: /* CMD28: SET_WRITE_PROT */ + if (sd->size > SDSC_MAX_CAPACITY) { + return sd_illegal; + } + switch (sd->state) { case sd_transfer_state: if (addr >=3D sd->size) { @@ -1303,6 +1307,10 @@ static sd_rsp_type_t sd_normal_command(SDState *sd, = SDRequest req) break; =20 case 29: /* CMD29: CLR_WRITE_PROT */ + if (sd->size > SDSC_MAX_CAPACITY) { + return sd_illegal; + } + switch (sd->state) { case sd_transfer_state: if (addr >=3D sd->size) { @@ -1322,6 +1330,10 @@ static sd_rsp_type_t sd_normal_command(SDState *sd, = SDRequest req) break; =20 case 30: /* CMD30: SEND_WRITE_PROT */ + if (sd->size > SDSC_MAX_CAPACITY) { + return sd_illegal; + } + switch (sd->state) { case sd_transfer_state: sd->state =3D sd_sendingdata_state; --=20 2.26.2