From nobody Tue May 14 14:55:41 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1613750037; cv=none; d=zohomail.com; s=zohoarc; b=UZH4TWpQtVcrppvBym6OPFKBV60JkKTmrnxQvIWPW0VNAAK1UgtOTtdSvtZTEp0SQN3Rv4S28iPesZ9npaBpc3ULaQWXEJw6oScJ1PZ0qbxRrFmY33AuWludvylDxd9ta9fDrFoYQCti6WNvaMyfupPwV8W7Tzv82FgRg4lh42g= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1613750037; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=jhyplz4z2JTDluTugxtAWQyUQxGVhu1tswFD6jY9vXQ=; b=ZPTwiPTDF5LsWjScgNLjC68ptjZvswnIGsMTYDA3qPo6ZKbQIE6F7vpaiCiKAeD8F7dVpWNuOGyBFPvaTqzUMof++VqWq52ahgdDNpGyit1Egj7XrI5dag3oiYfkTM+rKqf+NvjFa6k0lZe8DPuzTi4ks7f8wLmqjEaaOmzaqx0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1613750036819343.1077448638529; Fri, 19 Feb 2021 07:53:56 -0800 (PST) Received: from localhost ([::1]:39268 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lD86M-0001Xc-LV for importer@patchew.org; Fri, 19 Feb 2021 10:53:54 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:45110) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lD7n6-0000JR-KT for qemu-devel@nongnu.org; Fri, 19 Feb 2021 10:34:01 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:45739) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1lD7n3-0005xM-Oe for qemu-devel@nongnu.org; Fri, 19 Feb 2021 10:34:00 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-567-vdtayVPWOgmyygdkKmQErw-1; Fri, 19 Feb 2021 10:33:54 -0500 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id BBDD5C73AE; Fri, 19 Feb 2021 15:33:52 +0000 (UTC) Received: from localhost (ovpn-112-191.ams2.redhat.com [10.36.112.191]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 555A41970D; Fri, 19 Feb 2021 15:33:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1613748835; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jhyplz4z2JTDluTugxtAWQyUQxGVhu1tswFD6jY9vXQ=; b=OV3ZU8pyCd4X1onrQXrpFDcY05FWLvR8DPx1aAZmL8g5ClDGbjXbxzgBSwLwMB4RX6e5OI ZD8suWJx/xWTCBWi9zqK7/Xegc5a3tDWObcrlbBTdcnbhIH8bbeQTW4VTxXLsBCuV0fyAI +AjlGggMVc4RMN7fMWIyDjUbBiEG3ag= X-MC-Unique: vdtayVPWOgmyygdkKmQErw-1 From: Max Reitz To: qemu-block@nongnu.org Subject: [PATCH 1/3] backup: Remove nodes from job in .clean() Date: Fri, 19 Feb 2021 16:33:46 +0100 Message-Id: <20210219153348.41861-2-mreitz@redhat.com> In-Reply-To: <20210219153348.41861-1-mreitz@redhat.com> References: <20210219153348.41861-1-mreitz@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=mreitz@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=216.205.24.124; envelope-from=mreitz@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Vladimir Sementsov-Ogievskiy , John Snow , qemu-devel@nongnu.org, Max Reitz Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" The block job holds a reference to the backup-top node (because it is passed as the main job BDS to block_job_create()). Therefore, bdrv_backup_top_drop() cannot delete the backup-top node (replacing it by its child does not affect the job parent, because that has .stay_at_node set). That is a problem, because all of its I/O functions assume the BlockCopyState (s->bcs) to be valid and that it has a filtered child; but after bdrv_backup_top_drop(), neither of those things are true. It does not make sense to add new parents to backup-top after backup_clean(), so we should detach it from the job before bdrv_backup_top_drop(). Because there is no function to do that for a single node, just detach all of the job's nodes -- the job does not do anything past backup_clean() anyway. Signed-off-by: Max Reitz Reviewed-by: Kevin Wolf --- block/backup.c | 1 + 1 file changed, 1 insertion(+) diff --git a/block/backup.c b/block/backup.c index 94e6dcd72e..6cf2f974aa 100644 --- a/block/backup.c +++ b/block/backup.c @@ -103,6 +103,7 @@ static void backup_abort(Job *job) static void backup_clean(Job *job) { BackupBlockJob *s =3D container_of(job, BackupBlockJob, common.job); + block_job_remove_all_bdrv(&s->common); bdrv_backup_top_drop(s->backup_top); } =20 --=20 2.29.2 From nobody Tue May 14 14:55:41 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1613748991; cv=none; d=zohomail.com; s=zohoarc; b=CyozmnZ5DNPtoqJHon+J40P6GOLQj3KEga9sVRnxdBqhuW8WDJwIY0KOuncAZ3E1CZO1C/oqhSHRd19NQG6YtiEZ5XjdaKzobcDVwJyNdGNebulkpgsm/wqbD9Xe40s9hE6dgfl4JqhqNNhN8YKOnRkGHCz01rmPkHQVEYWH+Hg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1613748991; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=jWrH+Pder/mK6sQSG6o0NdAqsT2RDmV3RSZzGujPIgQ=; b=moszyWILNNdyQ72Spna/XKULkBrj2sSZAojP700qm1gVgq7B0bccvc8ybVsmu8BQzA/45ELuMee1dSU0Dikv3dfKWi48LDtNYx56wxdiuJkSLCKeSV6YPTl46o3NehPSRhJFKTTR0o9aP8TqwOMY7k0Q3U81uCVUrpaUQZvN/Hc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1613748990793547.9215805187283; Fri, 19 Feb 2021 07:36:30 -0800 (PST) Received: from localhost ([::1]:41890 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lD7pV-0003xn-PL for importer@patchew.org; Fri, 19 Feb 2021 10:36:29 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:45236) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lD7nW-0000jy-HU for qemu-devel@nongnu.org; Fri, 19 Feb 2021 10:34:28 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:39431) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1lD7nQ-0006AB-J6 for qemu-devel@nongnu.org; Fri, 19 Feb 2021 10:34:24 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-198-99xXD8DLOJu5v18wsYRaCA-1; Fri, 19 Feb 2021 10:33:55 -0500 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D867510082F6; Fri, 19 Feb 2021 15:33:54 +0000 (UTC) Received: from localhost (ovpn-112-191.ams2.redhat.com [10.36.112.191]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7C5E26A035; Fri, 19 Feb 2021 15:33:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1613748859; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jWrH+Pder/mK6sQSG6o0NdAqsT2RDmV3RSZzGujPIgQ=; b=N0TD9uOe+Q7xVGiZDbAln6ZVPmifTw/YTSHrMuugAKk904ICCc16vJwG7/9Dnr3mWAHE86 gcrLM6Hn4N5u3Eh7Zf2445v5rdgMxnVe3NdYjcUxpZRvQc072J41OgnNqfdfK/EuT3KPh9 DZT0RpzTbuzxNQ7p6dvlOU67g7uLL7o= X-MC-Unique: 99xXD8DLOJu5v18wsYRaCA-1 From: Max Reitz To: qemu-block@nongnu.org Subject: [PATCH 2/3] backup-top: Refuse I/O in inactive state Date: Fri, 19 Feb 2021 16:33:47 +0100 Message-Id: <20210219153348.41861-3-mreitz@redhat.com> In-Reply-To: <20210219153348.41861-1-mreitz@redhat.com> References: <20210219153348.41861-1-mreitz@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=mreitz@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=63.128.21.124; envelope-from=mreitz@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Vladimir Sementsov-Ogievskiy , John Snow , qemu-devel@nongnu.org, Max Reitz Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" When the backup-top node transitions from active to inactive in bdrv_backup_top_drop(), the BlockCopyState is freed and the filtered child is removed, so the node effectively becomes unusable. However, noone told its I/O functions this, so they will happily continue accessing bs->backing and s->bcs. Prevent that by aborting early when s->active is false. (After the preceding patch, the node should be gone after bdrv_backup_top_drop(), so this should largely be a theoretical problem. But still, better to be safe than sorry, and also I think it just makes sense to check s->active in the I/O functions.) Signed-off-by: Max Reitz --- block/backup-top.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/block/backup-top.c b/block/backup-top.c index d1253e1aa6..589e8b651d 100644 --- a/block/backup-top.c +++ b/block/backup-top.c @@ -45,6 +45,12 @@ static coroutine_fn int backup_top_co_preadv( BlockDriverState *bs, uint64_t offset, uint64_t bytes, QEMUIOVector *qiov, int flags) { + BDRVBackupTopState *s =3D bs->opaque; + + if (!s->active) { + return -EIO; + } + return bdrv_co_preadv(bs->backing, offset, bytes, qiov, flags); } =20 @@ -54,6 +60,10 @@ static coroutine_fn int backup_top_cbw(BlockDriverState = *bs, uint64_t offset, BDRVBackupTopState *s =3D bs->opaque; uint64_t off, end; =20 + if (!s->active) { + return -EIO; + } + if (flags & BDRV_REQ_WRITE_UNCHANGED) { return 0; } --=20 2.29.2 From nobody Tue May 14 14:55:41 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1613750671; cv=none; d=zohomail.com; s=zohoarc; b=cNG4EaHsg/JS0E5tOGfNDhGOu4YiCIFDIGgjvEnPcX9FyajVbKYqaPyjq2nUvd8A7EFHfRLKbOgVzF9CWlUrcA82TNrsAOG0jWS+65bo3CsPLFukMxaMX9fLOYyBPW8VQi93JH4XCxEBPgiB5vq4HmzSK+nNJgJqWO/Dn0Yasyw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1613750671; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=hIvuFSRFrWaR1FxrpC6M0vrFiav01eM5D765IvhF2r8=; b=K4ow9vFxxnpqX9/mV4AJ4I92SnAp7PWZSsWR9meWXdgnbioCOqB3C8j8Z/qkjEXVu71CW4xLZBJoVZyb5FpdqSiaTXJ0bZvUB4JfCpnbwGQZ8hS+VntDvE2lFiyHfv7YcJOOISionCOWhzmNZ0q6dSjJWaNOxkk33cqX72uLh4U= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1613750670641787.0594086813757; Fri, 19 Feb 2021 08:04:30 -0800 (PST) Received: from localhost ([::1]:59962 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lD8Ga-0002gf-Ll for importer@patchew.org; Fri, 19 Feb 2021 11:04:28 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:45136) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lD7nC-0000Tf-Bz for qemu-devel@nongnu.org; Fri, 19 Feb 2021 10:34:07 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:35658) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1lD7n9-00060E-SD for qemu-devel@nongnu.org; Fri, 19 Feb 2021 10:34:06 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-263-Ys8CpWioMeyViZ3gk2t8-Q-1; Fri, 19 Feb 2021 10:33:58 -0500 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 316E11936B60; Fri, 19 Feb 2021 15:33:57 +0000 (UTC) Received: from localhost (ovpn-112-191.ams2.redhat.com [10.36.112.191]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C40FE5D734; Fri, 19 Feb 2021 15:33:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1613748842; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hIvuFSRFrWaR1FxrpC6M0vrFiav01eM5D765IvhF2r8=; b=ceWspYEPJwdkO9LzUh5Sw0X00oDenvmoAq7M1uenOgUq7dBzmw7eImCG2j9jOJDjWJVOW7 ogTSVPYbvXPQh/rGcCKMd4zdwx7n7wgt7u/1W13/KiytHCajbJzk0ICrEI1Gnmv+LeQXXe M5+I1eNFYdPvmxo8d9OXW/3eRacmhfs= X-MC-Unique: Ys8CpWioMeyViZ3gk2t8-Q-1 From: Max Reitz To: qemu-block@nongnu.org Subject: [PATCH 3/3] iotests/283: Check that finalize drops backup-top Date: Fri, 19 Feb 2021 16:33:48 +0100 Message-Id: <20210219153348.41861-4-mreitz@redhat.com> In-Reply-To: <20210219153348.41861-1-mreitz@redhat.com> References: <20210219153348.41861-1-mreitz@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=mreitz@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=216.205.24.124; envelope-from=mreitz@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Vladimir Sementsov-Ogievskiy , John Snow , qemu-devel@nongnu.org, Max Reitz Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" Without any of HEAD^ or HEAD^^ applied, qemu will most likely crash on the qemu-io invocation, for a variety of immediate reasons. The underlying problem is generally a use-after-free access into backup-top's BlockCopyState. With only HEAD^ applied, qemu-io will run into an EIO (which is not capture by the output, but you can see that the qemu-io invocation will be accepted (i.e., qemu-io will run) in contrast to the reference output, where the node name cannot be found), and qemu will then crash in query-named-block-nodes: bdrv_get_allocated_file_size() detects backup-top to be a filter and passes the request through to its child. However, after bdrv_backup_top_drop(), that child is NULL, so the recursive call crashes. With HEAD^^ applied, this test should pass. Signed-off-by: Max Reitz --- tests/qemu-iotests/283 | 55 ++++++++++++++++++++++++++++++++++++++ tests/qemu-iotests/283.out | 15 +++++++++++ 2 files changed, 70 insertions(+) diff --git a/tests/qemu-iotests/283 b/tests/qemu-iotests/283 index 79643e375b..509dcbbcf4 100755 --- a/tests/qemu-iotests/283 +++ b/tests/qemu-iotests/283 @@ -97,3 +97,58 @@ vm.qmp_log('blockdev-add', **{ vm.qmp_log('blockdev-backup', sync=3D'full', device=3D'source', target=3D'= target') =20 vm.shutdown() + + +""" +Check that the backup-top node is gone after job-finalize. + +During finalization, the node becomes inactive and can no longer +function. If it is still present, new parents might be attached, and +there would be no meaningful way to handle their I/O requests. +""" + +print('\n=3D=3D=3D backup-top should be gone after job-finalize =3D=3D=3D\= n') + +vm =3D iotests.VM() +vm.launch() + +vm.qmp_log('blockdev-add', **{ + 'node-name': 'source', + 'driver': 'null-co', +}) + +vm.qmp_log('blockdev-add', **{ + 'node-name': 'target', + 'driver': 'null-co', +}) + +vm.qmp_log('blockdev-backup', + job_id=3D'backup', + device=3D'source', + target=3D'target', + sync=3D'full', + filter_node_name=3D'backup-filter', + auto_finalize=3DFalse, + auto_dismiss=3DFalse) + +vm.event_wait('BLOCK_JOB_PENDING', 5.0) + +# The backup-top filter should still be present prior to finalization +assert vm.node_info('backup-filter') is not None + +vm.qmp_log('job-finalize', id=3D'backup') +vm.event_wait('BLOCK_JOB_COMPLETED', 5.0) + +# The filter should be gone now. Check that by trying to access it +# with qemu-io (which will most likely crash qemu if it is still +# there.). +vm.qmp_log('human-monitor-command', + command_line=3D'qemu-io backup-filter "write 0 1M"') + +# (Also, do an explicit check.) +assert vm.node_info('backup-filter') is None + +vm.qmp_log('job-dismiss', id=3D'backup') +vm.event_wait('JOB_STATUS_CHANGE', 5.0, {'data': {'status': 'null'}}) + +vm.shutdown() diff --git a/tests/qemu-iotests/283.out b/tests/qemu-iotests/283.out index d8cff22cc1..7e9cd9a7d4 100644 --- a/tests/qemu-iotests/283.out +++ b/tests/qemu-iotests/283.out @@ -6,3 +6,18 @@ {"return": {}} {"execute": "blockdev-backup", "arguments": {"device": "source", "sync": "= full", "target": "target"}} {"error": {"class": "GenericError", "desc": "Cannot set permissions for ba= ckup-top filter: Conflicts with use by other as 'image', which uses 'write'= on base"}} + +=3D=3D=3D backup-top should be gone after job-finalize =3D=3D=3D + +{"execute": "blockdev-add", "arguments": {"driver": "null-co", "node-name"= : "source"}} +{"return": {}} +{"execute": "blockdev-add", "arguments": {"driver": "null-co", "node-name"= : "target"}} +{"return": {}} +{"execute": "blockdev-backup", "arguments": {"auto-dismiss": false, "auto-= finalize": false, "device": "source", "filter-node-name": "backup-filter", = "job-id": "backup", "sync": "full", "target": "target"}} +{"return": {}} +{"execute": "job-finalize", "arguments": {"id": "backup"}} +{"return": {}} +{"execute": "human-monitor-command", "arguments": {"command-line": "qemu-i= o backup-filter \"write 0 1M\""}} +{"return": "Error: Cannot find device=3D nor node_name=3Dbackup-filter\r\n= "} +{"execute": "job-dismiss", "arguments": {"id": "backup"}} +{"return": {}} --=20 2.29.2